From patchwork Fri Feb 17 09:39:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13144464 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AD4C64ED8 for ; Fri, 17 Feb 2023 09:40:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbjBQJkM (ORCPT ); Fri, 17 Feb 2023 04:40:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbjBQJkK (ORCPT ); Fri, 17 Feb 2023 04:40:10 -0500 Received: from post.baikalelectronics.com (post.baikalelectronics.com [213.79.110.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E358362FDC; Fri, 17 Feb 2023 01:40:00 -0800 (PST) Received: from post.baikalelectronics.com (localhost.localdomain [127.0.0.1]) by post.baikalelectronics.com (Proxmox) with ESMTP id 0AB62E0EAA; Fri, 17 Feb 2023 12:39:59 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= baikalelectronics.ru; h=cc:cc:content-transfer-encoding :content-type:content-type:date:from:from:message-id :mime-version:reply-to:subject:subject:to:to; s=post; bh=s4GbBTn mS7KrQ6aqqnSvUqvcmPEcQprtwoDeUBF0LW8=; b=Sfm6jUMN3ZM8vSCUU3xAYzO RdpbO0KpLb3sao8ZZ+8rGH+ZCZKbNfWRnmXmTd1Pqk4YZ+N99oFNbQsCfieP9bSf UdIsupNm9T1lMOIPOP6Xhqm45XBuR6wbEjgZv2cLHvRFeSxi4uNxR3y5rY/1zeSu VuR351U3Gx18abMRJYSY= Received: from mail.baikal.int (mail.baikal.int [192.168.51.25]) by post.baikalelectronics.com (Proxmox) with ESMTP id D65ABE0E6A; Fri, 17 Feb 2023 12:39:58 +0300 (MSK) Received: from localhost (10.8.30.14) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 17 Feb 2023 12:39:58 +0300 From: Serge Semin To: Bjorn Helgaas , Lorenzo Pieralisi , Cai Huoqing , Jingoo Han , Gustavo Pimentel , Vinod Koul , Manivannan Sadhasivam , Yoshihiro Shimoda , Rob Herring CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , , , Subject: [PATCH 00/11] PCI: dwc: Relatively simple fixes and cleanups Date: Fri, 17 Feb 2023 12:39:45 +0300 Message-ID: <20230217093956.27126-1-Sergey.Semin@baikalelectronics.ru> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Originating-IP: [10.8.30.14] X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org It turns out the recent DW PCIe-related patchset was merged in with several relatively trivial issues left unsettled (noted by Bjorn and Manivannan). All of these lefovers have been fixed in this patchset. Namely the series starts with two bug-fixes. The first one concerns the improper link-mode initialization in case if the CDM-check is enabled. The second unfortunate mistake I made in the IP-core version type helper. In particular instead of testing the IP-core version type the macro function referred to the just IP-core version which obviously wasn't what I intended. Afterwards two @Mani-noted fixes follow. Firstly the dma-ranges related warning message is fixed to start with "DMA-ranges" word instead of "Dma-ranges". Secondly the Baikal-T1 PCIe Host driver is converted to perform the asynchronous probe type which saved us of about 15% of bootup time if no any PCIe peripheral device attached to the port. Then the patchset contains the Baikal-T1 PCIe driver fix. The corresponding patch removes the false error message printed during the controller probe procedure. I accidentally added the unconditional dev_err_probe() method invocation. It was obviously wrong. Then two trivial cleanups are introduced. The first one concerns the duplicated fast-link-mode flag unsetting. The second one implies dropping a redundant empty line from the dw_pcie_link_set_max_speed() function. The series continues with a patch inspired by the last @Bjorn note regarding the generic resources request interface. As @Bjorn correctly said it would be nice to have the new interface used wider in the DW PCIe subsystem. Aside with the Baikal-T1 PCIe Host driver the Toshiba Visconti PCIe driver can be easily converted to using the generic clock names. That's what is done in the noted patch. The patchset is closed with a series of MAINTAINERS-list related patches. Firstly after getting the DW PCIe RP/EP DT-schemas refactored I forgot to update the MAINTAINER-list with the new files added in the framework of that procedure. All the snps,dw-pcie* schemas shall be maintained by the DW PCIe core driver maintainers. Secondly seeing how long it took for my patchsets to review and not having any comments from the original driver maintainers I'd suggest to add myself as the reviewer to the DW PCIe and eDMA drivers. Thus hopefully the new updates review process will be performed with much less latencies. For the same reason I would also like to suggest to add @Manivannan as the DW PCIe/eDMA drivers maintainer if he isn't against that idea. What do you think about the last suggestion? Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: linux-pci@vger.kernel.org Cc: dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (11): PCI: dwc: Fix port link CSR improper init if CDM check enabled PCI: dwc: Fix erroneous version type test helper PCI: dwc: Fix inbound iATU entries out-of-bounds warning message PCI: bt1: Enable async probe type PCI: bt1: Fix printing false error message PCI: dwc: Drop duplicated fast-link-mode flag unsetting PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() PCI: visconti: Convert to using generic resources getter MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas MAINTAINERS: Add myself as the DW PCIe core reviewer MAINTAINERS: Add myself as the DW eDMA driver reviewer MAINTAINERS | 5 ++- drivers/pci/controller/dwc/pcie-bt1.c | 5 ++- .../pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/dwc/pcie-designware.c | 3 +- drivers/pci/controller/dwc/pcie-designware.h | 7 +++- drivers/pci/controller/dwc/pcie-visconti.c | 37 +++++++++---------- 6 files changed, 31 insertions(+), 28 deletions(-)