From patchwork Thu May 11 19:08:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13238395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30624C77B7C for ; Thu, 11 May 2023 19:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233472AbjEKTJa (ORCPT ); Thu, 11 May 2023 15:09:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238725AbjEKTJY (ORCPT ); Thu, 11 May 2023 15:09:24 -0400 Received: from post.baikalelectronics.com (post.baikalelectronics.com [213.79.110.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B6C36A52; Thu, 11 May 2023 12:09:20 -0700 (PDT) Received: from post.baikalelectronics.com (localhost.localdomain [127.0.0.1]) by post.baikalelectronics.com (Proxmox) with ESMTP id 7FA95E0EB3; Thu, 11 May 2023 22:09:17 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= baikalelectronics.ru; h=cc:cc:content-transfer-encoding :content-type:content-type:date:from:from:message-id :mime-version:reply-to:subject:subject:to:to; s=post; bh=PuMGmJI UhZCmLfTOtaUizJFxzeU1KYOXEXJs6qIN77o=; b=tF+SiV6M/G7aifDcie3zMw4 HkYTLQmf1ATR3mrtBCuojJisOfQaqlGJbJ/JNgXkNyeU4ael7BYze4SFt4D7Cj3q W0XUPYYZ3GSCMBcQIYFl3rqncaD6eIeMJBC3OZTcuFe7bFopjMkjyCQHqHFZ36uD ww/lL9BasqZSfDtuyrI0= Received: from mail.baikal.int (mail.baikal.int [192.168.51.25]) by post.baikalelectronics.com (Proxmox) with ESMTP id 644BEE0EB1; Thu, 11 May 2023 22:09:17 +0300 (MSK) Received: from localhost (10.8.30.6) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 May 2023 22:09:16 +0300 From: Serge Semin To: Bjorn Helgaas , Lorenzo Pieralisi , Cai Huoqing , Jingoo Han , Gustavo Pimentel , Vinod Koul , Manivannan Sadhasivam , Yoshihiro Shimoda , Rob Herring CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , , , Subject: [PATCH RESEND v5 00/14] PCI: dwc: Relatively simple fixes and cleanups Date: Thu, 11 May 2023 22:08:48 +0300 Message-ID: <20230511190902.28896-1-Sergey.Semin@baikalelectronics.ru> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Originating-IP: [10.8.30.6] X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org It turns out the recent DW PCIe-related patchset was merged in with several relatively trivial issues left unsettled (noted by Bjorn and Manivannan). All of these lefovers have been fixed in this patchset. Namely the series starts with two bug-fixes. The first one concerns the improper link-mode initialization in case if the CDM-check is enabled. The second unfortunate mistake I made in the IP-core version type helper. In particular instead of testing the IP-core version type the macro function referred to the just IP-core version which obviously wasn't what I intended. Afterwards two @Mani-noted fixes follow. Firstly the dma-ranges related warning message is fixed to start with "DMA-ranges" word instead of "Dma-ranges". Secondly the Baikal-T1 PCIe Host driver is converted to perform the asynchronous probe type which saved us of about 15% of bootup time if no any PCIe peripheral device attached to the port. Then the patchset contains the Baikal-T1 PCIe driver fix. The corresponding patch removes the false error message printed during the controller probe procedure. I accidentally added the unconditional dev_err_probe() method invocation. It was obviously wrong. Then two trivial cleanups are introduced. The first one concerns the duplicated fast-link-mode flag unsetting. The second one implies dropping a redundant empty line from the dw_pcie_link_set_max_speed() function. The series continues with a patch inspired by the last @Bjorn note regarding the generic resources request interface. As @Bjorn correctly said it would be nice to have the new interface used wider in the DW PCIe subsystem. Aside with the Baikal-T1 PCIe Host driver the Toshiba Visconti PCIe driver can be easily converted to using the generic clock names. That's what is done in the noted patch. The patchset is closed with a series of MAINTAINERS-list related patches. Firstly after getting the DW PCIe RP/EP DT-schemas refactored I forgot to update the MAINTAINER-list with the new files added in the framework of that procedure. All the snps,dw-pcie* schemas shall be maintained by the DW PCIe core driver maintainers. Secondly seeing how long it took for my patchsets to review and not having any comments from the original driver maintainers I'd suggest to add myself as the reviewer to the DW PCIe and eDMA drivers. Thus hopefully the new updates review process will be performed with much less latencies. For the same reason @Manivannan is added to the maintainers list of the DW PCIe/eDMA drivers as he already agreed to be in. Link: https://lore.kernel.org/linux-pci/20230217093956.27126-1-Sergey.Semin@baikalelectronics.ru/ Changelog v2: - Rebase onto the kernel 6.3-rc2. Link: https://lore.kernel.org/linux-pci/20230313200816.30105-1-Sergey.Semin@baikalelectronics.ru/ Changelog v3: - Drop the patch: [PATCH v2 01/11] PCI: dwc: Fix port link CSR improper init if CDM check enabled and rebase onto the already submitted by @Yoshihiro fix: commit cdce67099117 ("PCI: dwc: Fix PORT_LINK_CONTROL update when CDM check enabled") - Just resend. Link: https://lore.kernel.org/linux-pci/20230411033928.30397-1-Sergey.Semin@baikalelectronics.ru/ Changelog v4: - Demote @Gustavo to being DW PCIe/eDMA drivers reviewer: [PATCH v4 9/14] MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer [PATCH v4 12/14] MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer - Add Manivannan to the DW PCIe/eDMA drivers maintainers list: [PATCH v4 10/14] MAINTAINERS: Add Manivannan to DW PCIe core maintainers list [PATCH v4 13/14] MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list Link: https://lore.kernel.org/linux-pci/20230414021832.13167-1-Sergey.Semin@baikalelectronics.ru/ Changelog v5: - Rebase onto the kernel 6.4-rc1. - Just resend. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: linux-pci@vger.kernel.org Cc: dmaengine@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (14): PCI: dwc: Fix erroneous version type test helper PCI: dwc: Fix inbound iATU entries out-of-bounds warning message PCI: bt1: Enable async probe type PCI: bt1: Fix printing false error message PCI: dwc: Drop duplicated fast-link-mode flag unsetting PCI: dwc: Drop empty line from dw_pcie_link_set_max_speed() PCI: visconti: Convert to using generic resources getter MAINTAINERS: Add all generic DW PCIe RP/EP DT-schemas MAINTAINERS: Demote Gustavo Pimentel to DW PCIe core reviewer MAINTAINERS: Add Manivannan to DW PCIe core maintainers list MAINTAINERS: Add myself as the DW PCIe core reviewer MAINTAINERS: Demote Gustavo Pimentel to DW EDMA driver reviewer MAINTAINERS: Add Manivannan to DW eDMA driver maintainers list MAINTAINERS: Add myself as the DW eDMA driver reviewer MAINTAINERS | 11 ++++-- drivers/pci/controller/dwc/pcie-bt1.c | 5 ++- .../pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/dwc/pcie-designware.c | 2 - drivers/pci/controller/dwc/pcie-designware.h | 7 +++- drivers/pci/controller/dwc/pcie-visconti.c | 37 +++++++++---------- 6 files changed, 34 insertions(+), 30 deletions(-)