| Message ID | 20230927100802.46620-1-minda.chen@starfivetech.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Refactoring Microchip PCIe driver and add StarFive PCIe | expand |
On 2023/9/27 18:07, Minda Chen wrote: > This patchset final purpose is add PCIe driver for StarFive JH7110 SoC. > JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the > same IP and have commit their codes, which are mixed with PLDA > controller codes and Microchip platform codes. > > For re-use the PLDA controller codes, I request refactoring microchip > codes, move PLDA common codes to PLDA files. > Desigware and Cadence is good example for refactoring codes. > > So first step is extract the PLDA common codes from microchip, and > refactoring the microchip codes.(patch1 - 16) > Then, add Starfive codes. (patch17 - 19) > > This patchset is base on v6.6-rc3 > > patch1 is move PLDA XpressRICH PCIe host common properties dt-binding > docs from microchip,pcie-host.yaml > patch2 is move PolarFire codes to PLDA directory. > patch3 is move PLDA IP register macros to plda-pcie.h > patch4 is rename data structure in microchip codes. > patch5 is rename two setup functions in microchip codes, prepare to move > to common file. > patch6 is change the arguments of plda_pcie_setup_iomems() > patch7 is move the two setup functions to common file pcie-plda-host.c > patch8 is Add PLDA event interrupt codes and IRQ domain ops. > patch9 is rename the IRQ related functions, prepare to move to > pcie-plda-host. > patch10 - 14 is modify the event codes, preparing for support starfive > and microchip two platforms. > patch15 is move IRQ related functions to pcie-plda-host.c > patch16 is set plda_event_handler to static. > patch17 is add StarFive JH7110 PCIe dt-binding doc. > patch18 is add StarFive JH7110 Soc PCIe codes. > patch19 is Starfive dts config > Hi Conor and Daire Have you ever test this patchset？ I'm sure I am not change logic of the PolarFire PCIe driver, But I can not test it. Since this series patch is delegate to nobody and no response now. I don't know when this patch set can be accepted. I still hope the refactoring patches can be accepted first. (I know you want to add the function of inbound and outbound address translation, Hope this series patch do not influence your upstream plan)
On Mon, Oct 09, 2023 at 06:58:42PM +0800, Minda Chen wrote: > > > On 2023/9/27 18:07, Minda Chen wrote: > > This patchset final purpose is add PCIe driver for StarFive JH7110 SoC. > > JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the > > same IP and have commit their codes, which are mixed with PLDA > > controller codes and Microchip platform codes. > > > > For re-use the PLDA controller codes, I request refactoring microchip > > codes, move PLDA common codes to PLDA files. > > Desigware and Cadence is good example for refactoring codes. > > > > So first step is extract the PLDA common codes from microchip, and > > refactoring the microchip codes.(patch1 - 16) > > Then, add Starfive codes. (patch17 - 19) > > > > This patchset is base on v6.6-rc3 > > > > patch1 is move PLDA XpressRICH PCIe host common properties dt-binding > > docs from microchip,pcie-host.yaml > > patch2 is move PolarFire codes to PLDA directory. > > patch3 is move PLDA IP register macros to plda-pcie.h > > patch4 is rename data structure in microchip codes. > > patch5 is rename two setup functions in microchip codes, prepare to move > > to common file. > > patch6 is change the arguments of plda_pcie_setup_iomems() > > patch7 is move the two setup functions to common file pcie-plda-host.c > > patch8 is Add PLDA event interrupt codes and IRQ domain ops. > > patch9 is rename the IRQ related functions, prepare to move to > > pcie-plda-host. > > patch10 - 14 is modify the event codes, preparing for support starfive > > and microchip two platforms. > > patch15 is move IRQ related functions to pcie-plda-host.c > > patch16 is set plda_event_handler to static. > > patch17 is add StarFive JH7110 PCIe dt-binding doc. > > patch18 is add StarFive JH7110 Soc PCIe codes. > > patch19 is Starfive dts config > > > Hi Conor and Daire > Have you ever test this patchset？ I'm sure I am not change logic of the PolarFire PCIe driver, > But I can not test it. > Since this series patch is delegate to nobody and no response now. I don't know when this patch set can be accepted. I'll try to look at this series again this week. I've been AFK a bit with holidays etc recently, and been a bit delayed in general. I was mostly happy with it before, and had left reviewed-bys on most of the series I think. > I still hope the refactoring patches can be accepted first The last patchset Daire sent has been applied: https://lore.kernel.org/all/169149233963.79399.5232296870054239065.b4-ty@kernel.org/ > (I know you want to add the function of inbound and outbound address translation, Hope this series patch do not influence your upstream plan) I'd expect this series to go in before the inbound/outbound translation one, since this is a lot closer to ready & is being resent more often. Cheers, Conor.
On 2023/10/9 19:16, Conor Dooley wrote: > On Mon, Oct 09, 2023 at 06:58:42PM +0800, Minda Chen wrote: >> >> >> On 2023/9/27 18:07, Minda Chen wrote: >> > This patchset final purpose is add PCIe driver for StarFive JH7110 SoC. >> > JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the >> > same IP and have commit their codes, which are mixed with PLDA >> > controller codes and Microchip platform codes. >> > >> > For re-use the PLDA controller codes, I request refactoring microchip >> > codes, move PLDA common codes to PLDA files. >> > Desigware and Cadence is good example for refactoring codes. >> > >> > So first step is extract the PLDA common codes from microchip, and >> > refactoring the microchip codes.(patch1 - 16) >> > Then, add Starfive codes. (patch17 - 19) >> > >> > This patchset is base on v6.6-rc3 >> > >> > patch1 is move PLDA XpressRICH PCIe host common properties dt-binding >> > docs from microchip,pcie-host.yaml >> > patch2 is move PolarFire codes to PLDA directory. >> > patch3 is move PLDA IP register macros to plda-pcie.h >> > patch4 is rename data structure in microchip codes. >> > patch5 is rename two setup functions in microchip codes, prepare to move >> > to common file. >> > patch6 is change the arguments of plda_pcie_setup_iomems() >> > patch7 is move the two setup functions to common file pcie-plda-host.c >> > patch8 is Add PLDA event interrupt codes and IRQ domain ops. >> > patch9 is rename the IRQ related functions, prepare to move to >> > pcie-plda-host. >> > patch10 - 14 is modify the event codes, preparing for support starfive >> > and microchip two platforms. >> > patch15 is move IRQ related functions to pcie-plda-host.c >> > patch16 is set plda_event_handler to static. >> > patch17 is add StarFive JH7110 PCIe dt-binding doc. >> > patch18 is add StarFive JH7110 Soc PCIe codes. >> > patch19 is Starfive dts config >> > >> Hi Conor and Daire >> Have you ever test this patchset？ I'm sure I am not change logic of the PolarFire PCIe driver, >> But I can not test it. >> Since this series patch is delegate to nobody and no response now. I don't know when this patch set can be accepted. > > I'll try to look at this series again this week. I've been AFK a bit > with holidays etc recently, and been a bit delayed in general. I was > mostly happy with it before, and had left reviewed-bys on most of the > series I think. > >> I still hope the refactoring patches can be accepted first > > The last patchset Daire sent has been applied: > https://lore.kernel.org/all/169149233963.79399.5232296870054239065.b4-ty@kernel.org/ > >> (I know you want to add the function of inbound and outbound address translation, Hope this series patch do not influence your upstream plan) > > I'd expect this series to go in before the inbound/outbound translation > one, since this is a lot closer to ready & is being resent more often. > > Cheers, > Conor. Thanks! I will follow the comments and send v8 in this week.
This patchset final purpose is add PCIe driver for StarFive JH7110 SoC. JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the same IP and have commit their codes, which are mixed with PLDA controller codes and Microchip platform codes. For re-use the PLDA controller codes, I request refactoring microchip codes, move PLDA common codes to PLDA files. Desigware and Cadence is good example for refactoring codes. So first step is extract the PLDA common codes from microchip, and refactoring the microchip codes.(patch1 - 16) Then, add Starfive codes. (patch17 - 19) This patchset is base on v6.6-rc3 patch1 is move PLDA XpressRICH PCIe host common properties dt-binding docs from microchip,pcie-host.yaml patch2 is move PolarFire codes to PLDA directory. patch3 is move PLDA IP register macros to plda-pcie.h patch4 is rename data structure in microchip codes. patch5 is rename two setup functions in microchip codes, prepare to move to common file. patch6 is change the arguments of plda_pcie_setup_iomems() patch7 is move the two setup functions to common file pcie-plda-host.c patch8 is Add PLDA event interrupt codes and IRQ domain ops. patch9 is rename the IRQ related functions, prepare to move to pcie-plda-host. patch10 - 14 is modify the event codes, preparing for support starfive and microchip two platforms. patch15 is move IRQ related functions to pcie-plda-host.c patch16 is set plda_event_handler to static. patch17 is add StarFive JH7110 PCIe dt-binding doc. patch18 is add StarFive JH7110 Soc PCIe codes. patch19 is Starfive dts config previous version: v1:https://patchwork.kernel.org/project/linux-pci/cover/20230719102057.22329-1-minda.chen@starfivetech.com/ v2:https://patchwork.kernel.org/project/linux-pci/cover/20230727103949.26149-1-minda.chen@starfivetech.com/ v3:https://patchwork.kernel.org/project/linux-pci/cover/20230814082016.104181-1-minda.chen@starfivetech.com/ v4:https://patchwork.kernel.org/project/linux-pci/cover/20230825090129.65721-1-minda.chen@starfivetech.com/ v5:https://patchwork.kernel.org/project/linux-pci/cover/20230907091058.125630-1-minda.chen@starfivetech.com/ v6:https://patchwork.kernel.org/project/linux-pci/cover/20230915102243.59775-1-minda.chen@starfivetech.com/ change: v7: patch8: fix the build warning. patch18: Some format changes (Emil's comment) patch19: change the pcie node sequences by alphabetical delete the "interupt-parent" in pcie node. v6: v5 patch 4 split to patch 4 -6. New patches just contain one function modification. It is more reguluar. patch 7: Just move the two setup functions only patch 8 : draw a graph of PLDA local register, make it easier to review the codes. v5 patch 7 split to patch 9- 14. Each patch just contain one function modification. It is more regular. patch 9: rename IRQ related functions. patch 10 - 14 : modify the events codes, total five patch. patch 15: move IRQ related functions to pcie-plda-host.c patch 16: Add new patch 16. patch 18- 19 using "linux,pci-domain" dts setting. v5: patch 9 -14: - Some variables names changed (evt->event). - plda_handle_event() using a unify callback function to get events num. - Add plda_event_ops data structure. patch 18: plda_event_ops changed which is related to patch 6- 8 changed. v4: patch 3: Copy the interrupt events macros to pcie-plda-host.c patch 13: get_events() change in patch 7. Patch 8 is just move the codes. other change: All the functions in commit message add (). v3: patch 2- 16: - splite refactoring patches to multiple patch. - rename plda_pcie to plda_pcie_rp. Maybe other vendor will upstream PLDA ep codes. patch 17: - Remove the redundant reference. - move the offset value to codes in starfive,stg-syscon - change reset-gpio to prest-gpio. patch18: - Add 100ms delay after preset for PCIe 6.0 spec. - stg-syscon related modification. patch19: - Add dts configure. v2: patch1: - squash dt-bindings patches to patch1 - add 'required' list. - plda doc rename to plda,xpressrich-axi-common.yaml patch2 - 16: - squash the microchip modification patch. patch17: - remove the plda common required property. patch18: - Sync the hide rc bar ops with config read function. - Revert the T_PVPERL to 100ms and add comments for the source. - Replace the link check function by the standard link ops. - Convert to new pm ops marcos. - Some formats modification. - pcie-plda-host modification merge to patch4. other: - remove the pcie-plda-plat.c - remove the starfive dts patch first. for it depends on stg clock and syscon setting. Minda Chen (19): dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties PCI: microchip: Move pcie-microchip-host.c to plda directory PCI: microchip: Move PLDA IP register macros to pcie-plda.h PCI: microchip: Rename data structure PCI: microchip: Rename two setup functions PCI: microchip: Change the argument of plda_pcie_setup_iomems() PCI: plda: Move the setup functions to pcie-plda-host.c PCI: plda: Add event interrupt codes and IRQ domain ops PCI: microchip: Rename interrupt related functions PCI: microchip: Add num_events field to struct plda_pcie_rp PCI: microchip: Add request_event_irq() callback function PCI: microchip: Add INTx and MSI event num to struct plda_event PCI: microchip: Add get_events() callback function PCI: microchip: Add event IRQ domain ops to struct plda_event PCI: microchip: Move IRQ functions to pcie-plda-host.c PCI: plda: Set plda_event_handler() and event ops to static dt-bindings: PCI: Add StarFive JH7110 PCIe controller PCI: starfive: Add JH7110 PCIe controller riscv: dts: starfive: add PCIe dts configuration for JH7110 .../bindings/pci/microchip,pcie-host.yaml | 55 +- .../pci/plda,xpressrich3-axi-common.yaml | 75 ++ .../bindings/pci/starfive,jh7110-pcie.yaml | 120 ++++ MAINTAINERS | 19 +- .../jh7110-starfive-visionfive-2.dtsi | 64 ++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 86 +++ drivers/pci/controller/Kconfig | 9 +- drivers/pci/controller/Makefile | 2 +- drivers/pci/controller/plda/Kconfig | 30 + drivers/pci/controller/plda/Makefile | 4 + .../{ => plda}/pcie-microchip-host.c | 603 ++-------------- drivers/pci/controller/plda/pcie-plda-host.c | 659 ++++++++++++++++++ drivers/pci/controller/plda/pcie-plda.h | 266 +++++++ drivers/pci/controller/plda/pcie-starfive.c | 448 ++++++++++++ 14 files changed, 1835 insertions(+), 605 deletions(-) create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich3-axi-common.yaml create mode 100644 Documentation/devicetree/bindings/pci/starfive,jh7110-pcie.yaml create mode 100644 drivers/pci/controller/plda/Kconfig create mode 100644 drivers/pci/controller/plda/Makefile rename drivers/pci/controller/{ => plda}/pcie-microchip-host.c (54%) create mode 100644 drivers/pci/controller/plda/pcie-plda-host.c create mode 100644 drivers/pci/controller/plda/pcie-plda.h create mode 100644 drivers/pci/controller/plda/pcie-starfive.c base-commit: 6465e260f48790807eef06b583b38ca9789b6072