From patchwork Mon Nov 20 21:59:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Stanner X-Patchwork-Id: 13462166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31D1EC197A0 for ; Mon, 20 Nov 2023 22:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232296AbjKTWAM (ORCPT ); Mon, 20 Nov 2023 17:00:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjKTWAI (ORCPT ); Mon, 20 Nov 2023 17:00:08 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB93BD2 for ; Mon, 20 Nov 2023 14:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700517604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oA/MReMENGME90F/W03bez9d20d3Hm8W5WtwK1MjIOQ=; b=OIbDiAeFoXWBJkiTT4Z79jm/2Py2kz71imxvsO5nOQsNC+HTihRSX21/auiAysLuokG0zJ omkIwE5RTqOwGIIIGCHVhjA/invm7juATERoju3CLS/U1zDpy4F+GDnYzplk1RNRVvGdVZ xHbX+ax1d24KjX+dynZ+FIyQ3YQZkyw= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-339-GXJK58ygMpCp8zLG4nB5-Q-1; Mon, 20 Nov 2023 17:00:02 -0500 X-MC-Unique: GXJK58ygMpCp8zLG4nB5-Q-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6755f01ca7dso13029316d6.1 for ; Mon, 20 Nov 2023 14:00:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700517602; x=1701122402; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oA/MReMENGME90F/W03bez9d20d3Hm8W5WtwK1MjIOQ=; b=E0UCvx+8w4vS2pVRzuQNuaohp7Js/89cHRprDKPcI5G/FJbONpeB9ot1vKMzH70KYt Y7BS/jZ98tVmSLV72ovL02MoZjp1vg+QidJ261ksJ6/bAznhUqPrh9sjVHDgDTPXeWfT I7aemvrEXcTd/mqSMI0rADrh4jy2cyqdgkA5n+i5e6Zcf8TZxoZy1FYE95mbcgY/k9iO LqW0qZxH8G6UInDaOpXNp3XVDlxdWiUi3nJy4eBncMbcSaa9Cd58uadhZnhCxMvhAESz 4DHvrs4/tQtJgX86wbbbhHuCugRFwbnFSejXtSbi0LqxvsBjwBZ3u4cjMHqK9Hnb75fz 2C1g== X-Gm-Message-State: AOJu0Yw0UsuAGJukHIzvWjbhbVGnGyxW/9ipHKYmB0CMbGNESRvANLB7 VkK60sHixqdIHZGJK0rxwS7HWC9eirfG9/FrCxSQQlXIxSjvzAMK5Ok0WkRBQ302oAJnHG+WAcN IecL6kZAuJ3Ht6Tq4YXQ7 X-Received: by 2002:a05:6214:76a:b0:679:d92e:3915 with SMTP id f10-20020a056214076a00b00679d92e3915mr4464246qvz.6.1700517602291; Mon, 20 Nov 2023 14:00:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2cPaXvk02xjS9PSNBCsY1AIobgVcOVGaCj4dyFYAj777vhrd+5qp4n0siM1HRkrv0dpUL4Q== X-Received: by 2002:a05:6214:76a:b0:679:d92e:3915 with SMTP id f10-20020a056214076a00b00679d92e3915mr4464214qvz.6.1700517602018; Mon, 20 Nov 2023 14:00:02 -0800 (PST) Received: from pstanner-thinkpadt14sgen1.remote.csb ([2001:9e8:32dd:2700:227b:d2ff:fe26:2a7a]) by smtp.gmail.com with ESMTPSA id 3-20020ad45ba3000000b00677fb918337sm2762398qvq.53.2023.11.20.13.59.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 14:00:01 -0800 (PST) From: Philipp Stanner To: Bjorn Helgaas , Arnd Bergmann , Andrew Morton , Randy Dunlap , Jason Gunthorpe , Eric Auger , Kent Overstreet , Niklas Schnelle , NeilBrown , Philipp Stanner , John Sanpe , Dave Jiang , Yury Norov , Kees Cook , "Masami Hiramatsu (Google)" , David Gow , Herbert Xu , Thomas Gleixner , "wuqiang.matt" , Jason Baron , Ben Dooks , Danilo Krummrich Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH 0/4] Regather scattered PCI-Code Date: Mon, 20 Nov 2023 22:59:42 +0100 Message-ID: <20231120215945.52027-2-pstanner@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi! So it seems that since ca. 2007 the PCI code has been scattered a bit. PCI's devres code, which is only ever used by users of the entire PCI-subsystem anyways, resides in lib/devres.c and is guarded by an #ifdef PCI, just as the content of lib/pci_iomap.c is. It, thus, seems reasonable to move all of that. As I were at it, I moved as much of the devres-specific code from pci.c to devres.c, too. The only exceptions are four functions that are currently difficult to move. More information about that can be read here [1]. I noticed these scattered files while working on (new) PCI-specific devres functions. If we can get this here merged, I'll soon send another patch series that addresses some API-inconsistencies and could move the devres-part of the four remaining functions. I don't want to do that in this series as this here is only about moving code, whereas the next series would have to actually change API behavior. I successfully (cross-)built this for x86, x86_64, AARCH64 and ARM (allyesconfig). I booted a kernel with it on x86_64, with a Fedora desktop environment as payload. The OS came up fine I hope this is OK. If we can get it in, we'd soon have a very consistent PCI API again. Regards, P. [1] https://lore.kernel.org/all/84be1049e41283cf8a110267646320af9ffe59fe.camel@redhat.com/ Philipp Stanner (4): lib: move pci_iomap.c to drivers/pci/ lib: move pci-specific devres code to drivers/pci/ pci: move devres code from pci.c to devres.c lib/iomap.c: improve comment about pci anomaly drivers/pci/Kconfig | 3 + drivers/pci/Makefile | 3 +- drivers/pci/devres.c | 449 +++++++++++++++++++++++++ lib/pci_iomap.c => drivers/pci/iomap.c | 3 - drivers/pci/pci.c | 249 -------------- drivers/pci/pci.h | 24 ++ lib/Kconfig | 3 - lib/Makefile | 1 - lib/devres.c | 208 +----------- lib/iomap.c | 13 +- 10 files changed, 490 insertions(+), 466 deletions(-) create mode 100644 drivers/pci/devres.c rename lib/pci_iomap.c => drivers/pci/iomap.c (99%)