mbox series

[0/3] PCI/MSI: Remove IMS (Interrupt Message Store) support for now

Message ID 20240401232326.1794707-1-helgaas@kernel.org (mailing list archive)
Headers show
Series PCI/MSI: Remove IMS (Interrupt Message Store) support for now | expand

Message

Bjorn Helgaas April 1, 2024, 11:23 p.m. UTC
From: Bjorn Helgaas <bhelgaas@google.com>

IMS (Interrupt Message Store) support appeared in v6.2, but there are no
users yet.

Remove it for now.  We can add it back when a user comes along.

Bjorn Helgaas (3):
  Revert "PCI/MSI: Provide stubs for IMS functions"
  Revert "PCI/MSI: Provide pci_ims_alloc/free_irq()"
  Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support"

 drivers/pci/msi/api.c       | 50 -------------------------------
 drivers/pci/msi/irqdomain.c | 59 -------------------------------------
 include/linux/pci.h         | 26 ----------------
 3 files changed, 135 deletions(-)

Comments

Tian, Kevin April 2, 2024, 2:45 a.m. UTC | #1
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Tuesday, April 2, 2024 7:23 AM
> 
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> IMS (Interrupt Message Store) support appeared in v6.2, but there are no
> users yet.
> 
> Remove it for now.  We can add it back when a user comes along.
> 
> Bjorn Helgaas (3):
>   Revert "PCI/MSI: Provide stubs for IMS functions"
>   Revert "PCI/MSI: Provide pci_ims_alloc/free_irq()"
>   Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support"
> 

What about the other IMS related commits which are also dead
code after above are reverted?

fa5745aca1dc ("iommu/amd: Enable PCI/IMS")
810531a1af53 ("iommu/vt-d: Enable PCI/IMS")
6e24c8877329 ("x86/apic/msi: Enable PCI/IMS")
e23d4192bf9b ("genirq/msi: Provide constants for PCI/IMS support")
Bjorn Helgaas April 2, 2024, 4:42 p.m. UTC | #2
On Tue, Apr 02, 2024 at 02:45:50AM +0000, Tian, Kevin wrote:
> > From: Bjorn Helgaas <helgaas@kernel.org>
> > Sent: Tuesday, April 2, 2024 7:23 AM
> > 
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > 
> > IMS (Interrupt Message Store) support appeared in v6.2, but there are no
> > users yet.
> > 
> > Remove it for now.  We can add it back when a user comes along.
> > 
> > Bjorn Helgaas (3):
> >   Revert "PCI/MSI: Provide stubs for IMS functions"
> >   Revert "PCI/MSI: Provide pci_ims_alloc/free_irq()"
> >   Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support"
> > 
> 
> What about the other IMS related commits which are also dead
> code after above are reverted?
> 
> fa5745aca1dc ("iommu/amd: Enable PCI/IMS")
> 810531a1af53 ("iommu/vt-d: Enable PCI/IMS")
> 6e24c8877329 ("x86/apic/msi: Enable PCI/IMS")
> e23d4192bf9b ("genirq/msi: Provide constants for PCI/IMS support")

Thanks, I didn't catch those; will add in a v2.

Also, sorry for inadvertently sending this in the middle of an
unrelated thread.  I copied --in-reply-to from my notes when I
shouldn't have.

Bjorn