From patchwork Tue Jul 16 21:31:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13734955 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D53FB46522 for ; Tue, 16 Jul 2024 21:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721165501; cv=none; b=DGiTb91XH2/SzL4fsJU7bSH0lZWDUsbDuEZcoaLN1D/aWX9Mla2KNPwyv9FWYPCZiftdQ1RGQRUyy7jAO4U5IB8eXGNg6rvlozMZesFedWPB11abE3SmfdcGCtkbTgMv1xKHWmf7YLpkmcp+bxfYfJrqolHYlyMknVhJAaicJnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721165501; c=relaxed/simple; bh=ZVp7F1+bYdxfUiYoxdzSRZrb4SdWKMHCl9xsvg8QTvI=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type; b=sO9CP6CNxdNYzLjCLOwmsrQBO/KKRLkp7luswE+pu1dmGYaJfjGYQ782MdhyxnzAjFXmyQtlnBko8ZcnWRhvzdaUd4SSPMQhHcPODha8QAZoY69ZMHIpDZ1vdjKvwIF5nDHZargDAdKT7V1PSoq7R4VmiywLLItrcKjZOy84JA8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=TlDMEUrg; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="TlDMEUrg" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-70b42250526so4565746b3a.1 for ; Tue, 16 Jul 2024 14:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1721165498; x=1721770298; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wa5tmuQVcKiDOQoEvUw30VX/uu13BTnidnng1zJA09Y=; b=TlDMEUrg71SlOyorE2iPBooqLyCW+Y4ohcjR5CUBU/V9iGSbj3HCYs3Whx612uWC7R ia5oDl8kDakrXxCpxesB5PsPXz22B9ijGgbBp/k7aI1G1sjUt2dykhEAh678VsXNLnEH mQRJY9VpWmiaag/yLSVEFbJSxEdRO0PNUNhzU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721165498; x=1721770298; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wa5tmuQVcKiDOQoEvUw30VX/uu13BTnidnng1zJA09Y=; b=XygnARfvl/N3r8fSrx2diKHD0J3HJ3h4RZn35zm5LWjuU4tLyUGW3aZ1kthF+5MkBW SHMxwlNwa7iXtQM38mqiNKeLqpaMpQdGOJQjfEr16rR804VD/mwBCUP/K7yuqWu/n5KV n7rC3OxDkDWJmaUDakZQPpYOzRjzdMNEkj2XdRUEYTwuoRL/dHWaeZGDoDqd655kjwzC oh7atberG3gNty73z1wgyd/n+QReGZZdaefLL4wEfsmT9euJTpUVNJSCL0o3JktHc0Hk F1V0B4j4b2nCIg+TMtHT8GhTq08MTVinGpXUdDyugekojb+LWhY2pmlVeapWpHcm6C8f teXA== X-Gm-Message-State: AOJu0Yx5IOzetXXJ319y8NJHF8ylZpG9f9AhC7qzxBt0p9WpIBU4ELfd hPbDlBZdp8vWRYaoy6qJtGOWMBqntbqI4G/l8OCfo/s/xHIi8UvMigT4E+mgYFEfsVPP1yIjuA2 hPYHGD9r0v6GvcZROveDNSvuEm/ov0/HKjUoXE3SFPjhwwZFDh566GbFQLG38oAmRpj6peca+uj /7kTUWq7XAl/Qx068cujsP9gAwm9ct4k27Lv26Ggl3EaGu0Q== X-Google-Smtp-Source: AGHT+IG9HYpepCxv2KZOShWkFuwZ+7DZXo2ArHdag9+jBKbfi2yX5HXeXJfYEwjq7wrq1Qem3RU7Mg== X-Received: by 2002:a05:6a00:2304:b0:706:251d:d98 with SMTP id d2e1a72fcca58-70c1fb673fbmr3948563b3a.4.1721165497815; Tue, 16 Jul 2024 14:31:37 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b7eb9e20fsm6812828b3a.31.2024.07.16.14.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 14:31:36 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Rob Herring Subject: [PATCH v4 00/12] PCI: brcnstb: Enable STB 7712 SOC Date: Tue, 16 Jul 2024 17:31:15 -0400 Message-Id: <20240716213131.6036-1-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: V4 Changes: o Commit "Check return value of all reset_control_xxx calls" -- Blank line before "return" (Stan) o Commit "Use common error handling code in brcmstb_probe()" -- Drop the "Fixes" tag (Stan) o Commit "dt-bindings: PCI ..." -- Separate the main commit into two: cleanup and adding the 7712 SoC (Krzysztof) -- Fold maintainer change commit into cleanup change (Krzysztof) -- Use minItems/maxItems where appropriate (Krzysztof) -- Consistent order of resets/reset-names in decl and usage (Krzysztof) V3 Changes: o Commit "Enable 7712 SOCs" -- Move "model" check from outside to inside func (Stan) o Commit "Check return value of all reset_control_xxx calls" -- Propagate errors up the chain instead of ignoring them (Stan) o Commit "Refactor for chips with many regular inbound BARs" -- Nine suggestions given, nine implemented (Stan) o Commit "Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific" -- Drop tab, add parens around macro params in expression (Stan) o Commit "Use swinit reset if available" -- Treat swinit the same as other reset controllers (Stan) Stan suggested to use dev_err_probe() for getting resources but I will defer that to future series (if that's okay). o Commit "Get resource before we start asserting resets" -- Squash this with previous commit (Stan) o Commit "Use "clk_out" error path label" -- Move clk_prepare_enable() after getting resouurces (Stan) -- Change subject to "Use more common error handling code in brcm_pcie_probe()" (Markus) -- Use imperative commit description (Markus) -- "Fixes:" tag added for missing error return. (Markus) o Commit "dt-bindings: PCI ..." -- Split off maintainer change in separate commit. -- Tried to accomodate Krzysztof's requests, I'm not sure I have succeeded. Krzysztof, please see [1] below. [1] Wrt the YAML of brcmstb PCIe resets, here is what I am trying to describe: CHIP NUM_RESETS NAMES ==== ========== ===== 4908 1 perst 7216 1 rescal 7712 3 rescal, bridge, swinit Others 0 - V2 Changes (note: four new commits): o Commit "dt-bindings: PCI ..." -- s/Adds/Add/, fix spelling error (Bjorn) -- Order compatible strings alphabetically (Krzysztof) -- Give definitions first then rules (Krzysztof) -- Add reason for change in maintainer (Krzysztof) o Commit "Use swinit reset if available" -- no need for "else" clause (Philipp) -- fix improper use of dev_err_probe() (Philipp) o Commit "Use "clk_out" error path label" -- Improve commit message (Bjorn) o Commit "PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific" -- Improve commit subject line (Bjorn) o Commit (NEW) -- Change field name from 'type' to 'model' -- Added as requested (Stanimir) o Commit (NEW) -- Check return value of all reset_control_xxx calls -- Added as requested (Stanimir) o Commit (NEW) "Get resource before we start asserting reset controllers" -- Added as requested (Stanimir) o Commit (NEW) -- "Remove two unused constants from driver" V1: This submission is for the Broadcom STB 7712, sibling SOC of the RPi5 chip. Stanimir has already submitted a patch "Add PCIe support for bcm2712" for the RPi version of the SOC. It is hoped that Stanimir will allow us to submit this series first and subsequently rebase his patch(es). The largest commit, "Refactor for chips with many regular inbound BARs" affects both the STB and RPi SOCs. It allows for multiple inbound ranges where previously only one was effectively used. This feature will also be present in future STB chips, as well as Broadcom's Cable Modem group. Jim Quinlan (12): dt-bindings: PCI: Cleanup of brcmstb YAML and add 7712 SoC dt-bindings: PCI: brcmstb: Add 7712 SoC description PCI: brcmstb: Use common error handling code in brcm_pcie_probe() PCI: brcmstb: Use bridge reset if available PCI: brcmstb: Use swinit reset if available PCI: brcmstb: PCI: brcmstb: Make HARD_DEBUG, INTR2_CPU_BASE offsets SoC-specific PCI: brcmstb: Remove two unused constants from driver PCI: brcmstb: Don't conflate the reset rescal with phy ctrl PCI: brcmstb: Refactor for chips with many regular inbound BARs PCI: brcmstb: Check return value of all reset_control_xxx calls PCI: brcmstb: Change field name from 'type' to 'model' PCI: brcmstb: Enable 7712 SOCs .../bindings/pci/brcm,stb-pcie.yaml | 50 +- drivers/pci/controller/pcie-brcmstb.c | 485 +++++++++++++----- 2 files changed, 400 insertions(+), 135 deletions(-) base-commit: 55027e689933ba2e64f3d245fb1ff185b3e7fc81