[v2,0/2] PCI: shpchp: Debug & logging cleanup

Message

Ilpo Järvinen Feb. 17, 2025, 9:55 a.m. UTC

Hi all,

This series cleans up debug/logging in shpchp driver.

The series is an update for the only remaining patch in the pci_printk()
removal series. To avoid breaking build, pci_printk() itself will only
be removed in the next kernel release because both AER and shpchp used
it and are in different topic branches.

v2:
- Split removal of logging wrappers and module parameter removal to
  own patches
- Explain how dynamic debugging can be enabled

Ilpo Järvinen (2):
  PCI: shpchp: Remove unused logging wrappers
  PCI: shpchp: Remove "shpchp_debug" module parameter

 drivers/pci/hotplug/shpchp.h      | 18 +-----------------
 drivers/pci/hotplug/shpchp_core.c |  3 ---
 2 files changed, 1 insertion(+), 20 deletions(-)


base-commit: d75ee0a7b0125636687a3f71c169bec04a576107

Comments

Bjorn Helgaas Feb. 18, 2025, 10:46 p.m. UTC | #1

On Mon, Feb 17, 2025 at 11:55:48AM +0200, Ilpo Järvinen wrote:
> Hi all,
> 
> This series cleans up debug/logging in shpchp driver.
> 
> The series is an update for the only remaining patch in the pci_printk()
> removal series. To avoid breaking build, pci_printk() itself will only
> be removed in the next kernel release because both AER and shpchp used
> it and are in different topic branches.
> 
> v2:
> - Split removal of logging wrappers and module parameter removal to
>   own patches
> - Explain how dynamic debugging can be enabled
> 
> Ilpo Järvinen (2):
>   PCI: shpchp: Remove unused logging wrappers
>   PCI: shpchp: Remove "shpchp_debug" module parameter
> 
>  drivers/pci/hotplug/shpchp.h      | 18 +-----------------
>  drivers/pci/hotplug/shpchp_core.c |  3 ---
>  2 files changed, 1 insertion(+), 20 deletions(-)

Applied to pci/hotplug for v6.15, thanks, Ilpo!

Bjorn Helgaas Feb. 19, 2025, 11 p.m. UTC | #2

On Tue, Feb 18, 2025 at 04:46:02PM -0600, Bjorn Helgaas wrote:
> On Mon, Feb 17, 2025 at 11:55:48AM +0200, Ilpo Järvinen wrote:
> > Hi all,
> > 
> > This series cleans up debug/logging in shpchp driver.
> > 
> > The series is an update for the only remaining patch in the pci_printk()
> > removal series. To avoid breaking build, pci_printk() itself will only
> > be removed in the next kernel release because both AER and shpchp used
> > it and are in different topic branches.
> > 
> > v2:
> > - Split removal of logging wrappers and module parameter removal to
> >   own patches
> > - Explain how dynamic debugging can be enabled
> > 
> > Ilpo Järvinen (2):
> >   PCI: shpchp: Remove unused logging wrappers
> >   PCI: shpchp: Remove "shpchp_debug" module parameter
> > 
> >  drivers/pci/hotplug/shpchp.h      | 18 +-----------------
> >  drivers/pci/hotplug/shpchp_core.c |  3 ---
> >  2 files changed, 1 insertion(+), 20 deletions(-)
> 
> Applied to pci/hotplug for v6.15, thanks, Ilpo!

And I added the previous patches:

  7d5f1e615e69 ("PCI: shpchp: Remove logging from module init/exit functions")
  499982200892 ("PCI: shpchp: Change dbg() -> ctrl_dbg()")

that you mentioned that I forgot to include here, which should fix the
build failure.