[v14,0/3] Add support for AMD MDB IP as Root Port

Message

Havalige, Thippeswamy Feb. 24, 2025, 7:31 a.m. UTC

This series of patch add support for AMD MDB IP as Root Port.

The AMD MDB IP support's 32 bit and 64bit BAR's at Gen5 speed.
As Root Port it supports MSI and legacy interrupts.

Thippeswamy Havalige (3):
  dt-bindings: PCI: dwc: Add AMD Versal2 mdb slcr support
  dt-bindings: PCI: amd-mdb: Add AMD Versal2 MDB PCIe Root Port Bridge
  PCI: amd-mdb: Add AMD MDB Root Port driver

 .../bindings/pci/amd,versal2-mdb-host.yaml    | 121 +++++
 .../devicetree/bindings/pci/snps,dw-pcie.yaml |   2 +
 drivers/pci/controller/dwc/Kconfig            |  11 +
 drivers/pci/controller/dwc/Makefile           |   1 +
 drivers/pci/controller/dwc/pcie-amd-mdb.c     | 481 ++++++++++++++++++
 5 files changed, 616 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/amd,versal2-mdb-host.yaml
 create mode 100644 drivers/pci/controller/dwc/pcie-amd-mdb.c

Comments

Niklas Cassel Feb. 24, 2025, 1:38 p.m. UTC | #1

On Mon, Feb 24, 2025 at 01:01:14PM +0530, Thippeswamy Havalige wrote:
> This series of patch add support for AMD MDB IP as Root Port.
> 
> The AMD MDB IP support's 32 bit and 64bit BAR's at Gen5 speed.

Which PCIe controller does not support 64-bit BARs?

Seems like quite a random sentence IMO.


> As Root Port it supports MSI and legacy interrupts.

You are not submitting Endpoint mode support for your controller,
so it seems a bit weird to talk about "As Root Port ...".

Your patch only includes Root Complex mode, and makes no reference
to Endpoint mode anywhere, so perhaps just state that the controller
supports MSI and INTx interrupts.


Kind regards,
Niklas