[v2,0/2] Preserve the flags portion on 1:1 dma-ranges mapping

Message

Andrea della Porta Nov. 24, 2024, 10:05 a.m. UTC

Empty dma-ranges in DT nodes using 3-cell address spcifier cause the
flag portion to be dropped by of_translate_one(), failing the translation
chain. This patch aims at fixing this issue.

Part of this patchset was originally preparatory for a bigger patchset
(see [1]). It has been split in a standalone one for better management
and because it contains a bugfix which is probably of interest to stable
branch.
I've also added new tests to unittest to prove it.

Many thanks,
Andrea

References:
[1] - https://lore.kernel.org/all/3029[e-mail]/


Changes in V2:

- Added blank lines between paragraphs in commit message for patch 2
- Fixed a comment to explain the code behaviour in a straighter way


Andrea della Porta (2):
  of/unittest: Add empty dma-ranges address translation tests
  of: address: Preserve the flags portion on 1:1 dma-ranges mapping

 drivers/of/address.c                        |  3 +-
 drivers/of/unittest-data/tests-address.dtsi |  2 ++
 drivers/of/unittest.c                       | 39 +++++++++++++++++++++
 3 files changed, 43 insertions(+), 1 deletion(-)

Comments

Rob Herring Nov. 27, 2024, 1:44 p.m. UTC | #1

On Sun, Nov 24, 2024 at 11:05:35AM +0100, Andrea della Porta wrote:
> Empty dma-ranges in DT nodes using 3-cell address spcifier cause the
> flag portion to be dropped by of_translate_one(), failing the translation
> chain. This patch aims at fixing this issue.
> 
> Part of this patchset was originally preparatory for a bigger patchset
> (see [1]). It has been split in a standalone one for better management
> and because it contains a bugfix which is probably of interest to stable
> branch.
> I've also added new tests to unittest to prove it.
> 
> Many thanks,
> Andrea
> 
> References:
> [1] - https://lore.kernel.org/all/3029[e-mail]/
> 
> 
> Changes in V2:
> 
> - Added blank lines between paragraphs in commit message for patch 2
> - Fixed a comment to explain the code behaviour in a straighter way
> 
> 
> Andrea della Porta (2):
>   of/unittest: Add empty dma-ranges address translation tests
>   of: address: Preserve the flags portion on 1:1 dma-ranges mapping
> 
>  drivers/of/address.c                        |  3 +-
>  drivers/of/unittest-data/tests-address.dtsi |  2 ++
>  drivers/of/unittest.c                       | 39 +++++++++++++++++++++
>  3 files changed, 43 insertions(+), 1 deletion(-)

Applied, thanks!

Rob