From patchwork Tue Sep 17 05:27:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2900871 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 18EEBBFF05 for ; Tue, 17 Sep 2013 05:27:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9760920326 for ; Tue, 17 Sep 2013 05:27:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD9B0201BF for ; Tue, 17 Sep 2013 05:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275Ab3IQF1e (ORCPT ); Tue, 17 Sep 2013 01:27:34 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:64043 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247Ab3IQF1d (ORCPT ); Tue, 17 Sep 2013 01:27:33 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MT900ERJ8HP32O0@mailout1.samsung.com> for linux-pci@vger.kernel.org; Tue, 17 Sep 2013 14:27:32 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id D5.C3.29948.448E7325; Tue, 17 Sep 2013 14:27:32 +0900 (KST) X-AuditID: cbfee691-b7f4a6d0000074fc-bc-5237e84427e4 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id FB.17.05832.448E7325; Tue, 17 Sep 2013 14:27:32 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MT9001VD8HVMQ50@mmp1.samsung.com>; Tue, 17 Sep 2013 14:27:32 +0900 (KST) From: Jingoo Han To: 'Bjorn Helgaas' Cc: linux-pci@vger.kernel.org, 'Thomas Petazzoni' , 'Jason Cooper' , 'Jingoo Han' References: <001a01ceb366$5e9481b0$1bbd8510$%han@samsung.com> In-reply-to: <001a01ceb366$5e9481b0$1bbd8510$%han@samsung.com> Subject: [PATCH V2 3/3] PCI: mvebu: add missing __iomem annotation Date: Tue, 17 Sep 2013 14:27:31 +0900 Message-id: <001c01ceb366$9bad8740$d30895c0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6zZl5+kmbKEZAhToGpxpyQ271bsQAACV1g Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t8zY12XF+ZBBhfeClgsacqwaFxymcXi 8sJLrBZn5x1ns3j6oInJgdXjyaaLjB4LNpV6NBw4z+LRt2UVo8fnTXIBrFFcNimpOZllqUX6 dglcGW2nZzMWvOaqmLz2KmsD43+OLkYODgkBE4lXc/W6GDmBTDGJC/fWs3UxcnEICSxjlHj2 dC4zRMJE4sGhRcwQiUWMEn9aV7JAOL8YJZqf/GIHqWITUJP48uUwmC0ioCkxe8UWJhCbGWTU opeuINuEBGwlnp23BwlzCthJXNr6nR0kLCzgJPF2vTBImEVAVeLcrvcsIGFeoOpJf1VBwrwC ghI/Jt9jgRioJbF+53Go4fISm9e8ZYZ4RV3i0V9diP1GEkdXPWSDKBGR2PfiHSPIwRIC19gl /p/azQixSkDi2+RDLBC9shKbDkB9KylxcMUNlgmMErOQbJ6FZPMsJJtnIVmxgJFlFaNoakFy QXFSepGpXnFibnFpXrpecn7uJkZIfE7cwXj/gPUhxmSg9ROZpUST84HxnVcSb2hsZmRhamJq bGRuaUaasJI4r3qLdaCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGxvByBucbaSdFmEvE71+b sHOz0Z9Viawr9mgJ7Hk365KFjJqiJjujarHn3mqH7hu7LFgsWXbplP2b+uPol3snHu8IlLtl f1Wn6vH2hvLX8hkTJQw+3nRyT00UsxCPbEiuckpecWg6p8n399/T569JKEyX77n2JtD53fv7 q9I8HRwn7lATnnrbTomlOCPRUIu5qDgRAJ6JyZDlAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAKsWRmVeSWpSXmKPExsVy+t9jAV2XF+ZBBofX8VosacqwaFxymcXi 8sJLrBZn5x1ns3j6oInJgdXjyaaLjB4LNpV6NBw4z+LRt2UVo8fnTXIBrFENjDYZqYkpqUUK qXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QLuVFMoSc0qBQgGJxcVK +naYJoSGuOlawDRG6PqGBMH1GBmggYR1jBltp2czFrzmqpi89iprA+N/ji5GTg4JAROJB4cW MUPYYhIX7q1n62Lk4hASWMQo8ad1JQuE84tRovnJL3aQKjYBNYkvXw6D2SICmhKzV2xhArGZ BZYxSix66drFyAHUYCvx7Lw9SJhTwE7i0tbv7CBhYQEnibfrhUHCLAKqEud2vWcBCfMCVU/6 qwoS5hUQlPgx+R4LxEAtifU7j0MNl5fYvOYtM0i5hIC6xKO/uhD7jSSOrnrIBlEiIrHvxTvG CYxCs5BMmoVk0iwkk2YhaVnAyLKKUTS1ILmgOCk910ivODG3uDQvXS85P3cTIzj+n0nvYFzV YHGIUYCDUYmHd4aUeZAQa2JZcWXuIUYJDmYlEd4wXaAQb0piZVVqUX58UWlOavEhxmSgPycy S4km5wNTU15JvKGxiZmRpZGZhZGJuTlpwkrivAdbrQOFBNITS1KzU1MLUotgtjBxcEo1MDI4 PrvjlVAfuvWitGPQ9PwgteZiiz3Xr03dYDfVXcrz2Q2HjB3Tzta6ekZd5HG576f2zzFc/vuJ X7/+nG+N7H6ad1dEQbzIKqHp7bcriu2n06S5X9TPTNAt9X4r0GmVprreVWGG1ylr+dn76oUu Bj9MidO+KWzk2L/OosdDoi1p5S65bdO2KLEUZyQaajEXFScCALlIN5pDAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Added missing __iomem annotation in order to fix the following sparse warning: drivers/pci/host/pci-mvebu.c:744:31: warning: incorrect type in return expression (different address spaces) drivers/pci/host/pci-mvebu.c:744:31: expected void [noderef] * drivers/pci/host/pci-mvebu.c:744:31: got void * Signed-off-by: Jingoo Han Acked-by: Thomas Petazzoni --- drivers/pci/host/pci-mvebu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c index b54ceb1..fb2474f 100644 --- a/drivers/pci/host/pci-mvebu.c +++ b/drivers/pci/host/pci-mvebu.c @@ -741,7 +741,7 @@ static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev, ret = of_address_to_resource(np, 0, ®s); if (ret) - return ERR_PTR(ret); + return NULL; return devm_ioremap_resource(&pdev->dev, ®s); } @@ -940,11 +940,10 @@ static int mvebu_pcie_probe(struct platform_device *pdev) continue; port->base = mvebu_pcie_map_registers(pdev, child, port); - if (IS_ERR(port->base)) { + if (!port->base) { dev_err(&pdev->dev, "PCIe%d.%d: cannot map registers\n", port->port, port->lane); clk_disable_unprepare(port->clk); - port->base = NULL; continue; }