From patchwork Fri Apr 28 04:29:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan Ramabadhran X-Patchwork-Id: 9703847 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 35E64602B7 for ; Fri, 28 Apr 2017 04:29:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2AD622862A for ; Fri, 28 Apr 2017 04:29:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F5082863D; Fri, 28 Apr 2017 04:29:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB29B2862A for ; Fri, 28 Apr 2017 04:29:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163060AbdD1E3m (ORCPT ); Fri, 28 Apr 2017 00:29:42 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46266 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162958AbdD1E3k (ORCPT ); Fri, 28 Apr 2017 00:29:40 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DC24C61490; Fri, 28 Apr 2017 04:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1493353779; bh=Jd3svo4r/rFCsU3+Uy/mGFr88vOH/keK+FIrIcGYxGk=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=E+aIu912Hv2dazQyQfUgckPR4BqIIEbTKqVCDQo64OKMzBhO1adaKirXSIHD56hx6 JtiLWM2pg6DKlcEN3XR+ZhJS8eEUT1LkoFllwHE3LuM9gBIV73t3ry+Okbi9t/53EA puzOiZK91zD5cehFmiMcifB7+05shmtvrOa9pzKM= Received: from [192.168.1.5] (unknown [171.76.36.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6056C61490; Fri, 28 Apr 2017 04:29:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1493353779; bh=Jd3svo4r/rFCsU3+Uy/mGFr88vOH/keK+FIrIcGYxGk=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=E+aIu912Hv2dazQyQfUgckPR4BqIIEbTKqVCDQo64OKMzBhO1adaKirXSIHD56hx6 JtiLWM2pg6DKlcEN3XR+ZhJS8eEUT1LkoFllwHE3LuM9gBIV73t3ry+Okbi9t/53EA puzOiZK91zD5cehFmiMcifB7+05shmtvrOa9pzKM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6056C61490 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [REGRESSION next-20170426] Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices") causes oops in mvneta From: Sricharan R To: Ralph Sennhauser Cc: "Rafael J. Wysocki" , Joerg Roedel , Bjorn Helgaas , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Thomas Petazzoni , netdev@vger.kernel.org References: <20170426181508.687b52af@gmail.com> <2fb57b9b-3944-d9cc-1fac-8dcccaa0c37a@codeaurora.org> Message-ID: <0a3e7a85-babb-8ae7-2c19-480c5203a8e5@codeaurora.org> Date: Fri, 28 Apr 2017 09:59:32 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <2fb57b9b-3944-d9cc-1fac-8dcccaa0c37a@codeaurora.org> Content-Language: en-US Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Ralph, On 4/27/2017 7:05 PM, Sricharan R wrote: > Hi, > > On 4/26/2017 9:45 PM, Ralph Sennhauser wrote: >> Hi Sricharan R, >> >> Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe time >> for platform/amba/pci bus devices") causes a kernel panic as in the log >> below on an armada-385. Reverting the commit fixes the issue. >> >> Regards >> Ralph > > Somehow not getting a obvious clue on whats going wrong with the logs > below. From the log and looking in to dts, the drivers seems to the one for > "marvell,armada-370-neta". Issue looks the data from the dma has gone bad > and subsequently referring the wrong data has resulted in the crash. > Looks like the dma_masks is the one going wrong. > Can i get some logs from mvneta_probe, about dev->dma_mask, > dev->coherent_dma_mask and dev->dma_ops with and without the patch > to see whats the difference ? > Attached the patch with debug prints. Regards, Sricharan From fe77d3968d6bc35b46e5f30d5c67c7603aa10597 Mon Sep 17 00:00:00 2001 From: Sricharan R Date: Fri, 28 Apr 2017 09:43:26 +0530 Subject: [PATCH] Debug prints Signed-off-by: Sricharan R --- drivers/net/ethernet/marvell/mvneta.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index d297011..250f0b2 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4146,6 +4146,12 @@ static int mvneta_probe(struct platform_device *pdev) int phy_mode; int err; int cpu; + struct device *ddev = &pdev->dev; + + + dev_err(ddev, "dev->dma_mask 0x%llx\n", *(ddev->dma_mask)); + dev_err(ddev, "dev->coherent_dma_mask 0x%llx\n", ddev->coherent_dma_mask); + dev_err(ddev, "dev->dma_ops 0x%llx\n", ddev->dma_ops); dev = alloc_etherdev_mqs(sizeof(struct mvneta_port), txq_number, rxq_number); if (!dev)