From patchwork Wed Dec 16 22:54:23 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 68454 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id nBI4ixr3005715 for ; Fri, 18 Dec 2009 04:46:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763126AbZLPWyg (ORCPT ); Wed, 16 Dec 2009 17:54:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763123AbZLPWyg (ORCPT ); Wed, 16 Dec 2009 17:54:36 -0500 Received: from gate.crashing.org ([63.228.1.57]:45190 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308AbZLPWyd (ORCPT ); Wed, 16 Dec 2009 17:54:33 -0500 Received: from [IPv6:::1] (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id nBGMsNSH012837; Wed, 16 Dec 2009 16:54:24 -0600 Subject: Re: [PATCH] cardbus: Add a fixup hook and fix powerpc From: Benjamin Herrenschmidt To: Jesse Barnes Cc: linux-pci@vger.kernel.org, "linux-kernel@vger.kernel.org" , linuxppc-dev , blofeldus@yahoo.com, Olof Johansson In-Reply-To: <20091216140128.16afbeb7@jbarnes-piketon> References: <1260341533.16132.20.camel@pasglop> <20091216140128.16afbeb7@jbarnes-piketon> Date: Thu, 17 Dec 2009 09:54:23 +1100 Message-ID: <1261004063.20129.113.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org --- linux-work.orig/drivers/pci/pci.c 2009-12-09 17:33:24.000000000 +1100 +++ linux-work/drivers/pci/pci.c 2009-12-09 17:34:16.000000000 +1100 @@ -2723,6 +2723,11 @@ int __attribute__ ((weak)) pci_ext_cfg_a return 1; } +void __weak pci_fixup_cardbus(struct pci_bus *bus) +{ +} +EXPORT_SYMBOL(pci_fixup_cardbus); Or is that broken in some way ? I'm starting to regret trying to use weak stuff :-) I may turn it into a good