From patchwork Wed Aug 1 15:54:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiang Liu X-Patchwork-Id: 1264851 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 58441DF280 for ; Wed, 1 Aug 2012 15:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755949Ab2HAP5M (ORCPT ); Wed, 1 Aug 2012 11:57:12 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:56250 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753913Ab2HAP5I (ORCPT ); Wed, 1 Aug 2012 11:57:08 -0400 Received: by ghrr11 with SMTP id r11so985545ghr.19 for ; Wed, 01 Aug 2012 08:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=WQ3LSTOs2cT3JnWsXfzcEME6MiaF937+FCSMh3zeF+s=; b=Y0J9KNykHFBkgPGF7pTPVwj+7b1AN4u2kznv6jfpH2xmgGjxoU3DNXS34hop/+p5Rf X9K+vFNeVoOI4nq4Y6YOzGNSLy74gDzYhdHOoDlukYk3GbDmKEFpc7aPkY+9w/NhGPzl VWTTfwQSFs+yPFbG2Vm+BCOn+muGeP5dlh/r8LFaSK+9tBhjBC2wNoexZartZAkyjJT+ VU7068gwy7erO7cYi1T3MfamdOIiXMbIF9KLHq2V+ub8A23Z+8hHtFEaTJCF0ttB+mBJ oLd8ckdW4+abkryBOrgqKchZ41R683glRUsU1XzFnMPB5fsj1tmz1JuDQmmJMFdVMcIa 3Hdw== Received: by 10.68.235.236 with SMTP id up12mr52924239pbc.79.1343836627203; Wed, 01 Aug 2012 08:57:07 -0700 (PDT) Received: from localhost.localdomain ([58.250.81.2]) by mx.google.com with ESMTPS id pe8sm2816231pbc.76.2012.08.01.08.56.56 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Aug 2012 08:57:05 -0700 (PDT) From: Jiang Liu To: Bjorn Helgaas , Don Dutile , Colin Cross , Olof Johansson , Stephen Warren Cc: Jiang Liu , Yinghai Lu , Taku Izumi , "Rafael J . Wysocki" , Kenji Kaneshige , Yijing Wang , Russell King , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jiang Liu Subject: [PATCH v3 12/32] PCI/ARM: use PCIe capabilities access functions to simplify implementation Date: Wed, 1 Aug 2012 23:54:17 +0800 Message-Id: <1343836477-7287-13-git-send-email-jiang.liu@huawei.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1343836477-7287-1-git-send-email-jiang.liu@huawei.com> References: <1343836477-7287-1-git-send-email-jiang.liu@huawei.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Jiang Liu Use PCIe capabilities access functions to simplify PCIe ARM implementation. Signed-off-by: Jiang Liu Acked-by: Stephen Warren --- arch/arm/mach-tegra/pcie.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-tegra/pcie.c b/arch/arm/mach-tegra/pcie.c index 0e09137..5f99d33 100644 --- a/arch/arm/mach-tegra/pcie.c +++ b/arch/arm/mach-tegra/pcie.c @@ -367,17 +367,8 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x0bf1, tegra_pcie_fixup_class); /* Tegra PCIE requires relaxed ordering */ static void __devinit tegra_pcie_relax_enable(struct pci_dev *dev) { - u16 val16; - int pos = pci_find_capability(dev, PCI_CAP_ID_EXP); - - if (pos <= 0) { - dev_err(&dev->dev, "skipping relaxed ordering fixup\n"); - return; - } - - pci_read_config_word(dev, pos + PCI_EXP_DEVCTL, &val16); - val16 |= PCI_EXP_DEVCTL_RELAX_EN; - pci_write_config_word(dev, pos + PCI_EXP_DEVCTL, val16); + pci_pcie_capability_change_word(dev, PCI_EXP_DEVCTL, + PCI_EXP_DEVCTL_RELAX_EN, 0); } DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, tegra_pcie_relax_enable);