| Message ID | 1349305214-3241-2-git-send-email-yinghai@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wed, Oct 3, 2012 at 7:00 PM, Yinghai Lu <yinghai@kernel.org> wrote: > To use to control the delay attach driver for acpi_device. <blinks> I am not sure what this says. Can you please explain how it controls the delaying of attaching drivers? > > Will use bus notifier to toggle this bits when needed. Will use ..? In a subsequent patch? Which patch? And when is this needed? Is there a patch that needs this? > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > --- > drivers/acpi/scan.c | 8 +++++++- > include/acpi/acpi_bus.h | 1 + > 2 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index d1ecca2..cbb3ed1 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -333,7 +333,12 @@ static void acpi_device_release(struct device *dev) > static int acpi_bus_match(struct device *dev, struct device_driver *drv) > { > struct acpi_device *acpi_dev = to_acpi_device(dev); > - struct acpi_driver *acpi_drv = to_acpi_driver(drv); > + struct acpi_driver *acpi_drv; > + > + if (!acpi_dev->drivers_autoprobe) > + return 0; > + > + acpi_drv = to_acpi_driver(drv); > > return !acpi_match_device_ids(acpi_dev, acpi_drv->ids); > } > @@ -1268,6 +1273,7 @@ static int acpi_add_single_object(struct acpi_device **child, > device->parent = acpi_bus_get_parent(handle); > device->bus_ops = *ops; /* workround for not call .start */ > STRUCT_TO_INT(device->status) = sta; > + device->drivers_autoprobe = true; > > acpi_device_get_busid(device); > > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h > index bde976e..969544e 100644 > --- a/include/acpi/acpi_bus.h > +++ b/include/acpi/acpi_bus.h > @@ -304,6 +304,7 @@ struct acpi_device { > struct device dev; > struct acpi_bus_ops bus_ops; /* workaround for different code path for hotplug */ > enum acpi_bus_removal_type removal_type; /* indicate for different removal type */ > + bool drivers_autoprobe; > }; > > static inline void *acpi_driver_data(struct acpi_device *d) > -- > 1.7.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 4, 2012 at 6:03 AM, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > On Wed, Oct 3, 2012 at 7:00 PM, Yinghai Lu <yinghai@kernel.org> wrote: >> To use to control the delay attach driver for acpi_device. > > <blinks> > I am not sure what this says. Can you please explain how it controls > the delaying of > attaching drivers? >> >> Will use bus notifier to toggle this bits when needed. > > Will use ..? In a subsequent patch? Which patch? And when is this > needed? Is there a patch that needs this? please check patch 0-4 as a whole. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 04, 2012 at 08:15:44AM -0700, Yinghai Lu wrote: > On Thu, Oct 4, 2012 at 6:03 AM, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > > On Wed, Oct 3, 2012 at 7:00 PM, Yinghai Lu <yinghai@kernel.org> wrote: > >> To use to control the delay attach driver for acpi_device. > > > > <blinks> > > I am not sure what this says. Can you please explain how it controls > > the delaying of > > attaching drivers? > >> > >> Will use bus notifier to toggle this bits when needed. > > > > Will use ..? In a subsequent patch? Which patch? And when is this > > needed? Is there a patch that needs this? > > please check patch 0-4 as a whole. But that is not how one is going to read the source code in a year or so. In a year I will look at at file, run 'git gui annotate <file>' and from the lines can find the corresponding patch. Then from there on continue on to get the other patches. The point is that in a year or so, the writeup you did will be forgotten. If it is part of the _patch_ then it will not be. If that means the git commit description has a couple of paragraphs - that is OK. > > Yinghai > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index d1ecca2..cbb3ed1 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -333,7 +333,12 @@ static void acpi_device_release(struct device *dev) static int acpi_bus_match(struct device *dev, struct device_driver *drv) { struct acpi_device *acpi_dev = to_acpi_device(dev); - struct acpi_driver *acpi_drv = to_acpi_driver(drv); + struct acpi_driver *acpi_drv; + + if (!acpi_dev->drivers_autoprobe) + return 0; + + acpi_drv = to_acpi_driver(drv); return !acpi_match_device_ids(acpi_dev, acpi_drv->ids); } @@ -1268,6 +1273,7 @@ static int acpi_add_single_object(struct acpi_device **child, device->parent = acpi_bus_get_parent(handle); device->bus_ops = *ops; /* workround for not call .start */ STRUCT_TO_INT(device->status) = sta; + device->drivers_autoprobe = true; acpi_device_get_busid(device); diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index bde976e..969544e 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -304,6 +304,7 @@ struct acpi_device { struct device dev; struct acpi_bus_ops bus_ops; /* workaround for different code path for hotplug */ enum acpi_bus_removal_type removal_type; /* indicate for different removal type */ + bool drivers_autoprobe; }; static inline void *acpi_driver_data(struct acpi_device *d)
To use to control the delay attach driver for acpi_device. Will use bus notifier to toggle this bits when needed. Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- drivers/acpi/scan.c | 8 +++++++- include/acpi/acpi_bus.h | 1 + 2 files changed, 8 insertions(+), 1 deletions(-)