From patchwork Sat Oct 6 15:27:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiang Liu X-Patchwork-Id: 1558651 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id EC3BADF238 for ; Sat, 6 Oct 2012 15:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753967Ab2JFPdG (ORCPT ); Sat, 6 Oct 2012 11:33:06 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:54663 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752781Ab2JFPdB (ORCPT ); Sat, 6 Oct 2012 11:33:01 -0400 Received: by mail-pb0-f46.google.com with SMTP id rr4so2816191pbb.19 for ; Sat, 06 Oct 2012 08:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=kOhGdx4khmJ3vbHmQN8EF7NQn2eVXo7whoVjPs6SCK4=; b=qQ/PPOZYe3Mts4z3LAMV2kyx1YtqlHE3/8jYaeXg/dMHFo89Srd1I6NQstXDE9izKP UpScvAgXutIEuO2Ych/zvBuN0+7k5ErqYTC6/6qNWgHKXilBIfAexOR1IjAxrNxR3Tq4 ESJLTbVgPtCNr1FSnVFgoaEpAbzCIc5MtA2XSLfcx1nxg1XcrX0NR0Kj6GhrmmrYVlZw tDPK0orgjZ7A429hXhkFNSUIoFQbAkkyRbZjNrTB5HT+bNJ+OWm/kfguT/WljpsvR2RV opcTZrB8WDuCb5ozUir/U8DlEuis212wTt+EFHJy0X3DCmGQwlH65ZC13RjqxqZc0QgQ CTKA== Received: by 10.66.74.40 with SMTP id q8mr29779009pav.29.1349537581181; Sat, 06 Oct 2012 08:33:01 -0700 (PDT) Received: from localhost.localdomain ([221.221.24.247]) by mx.google.com with ESMTPS id vz8sm7785292pbc.63.2012.10.06.08.32.47 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Oct 2012 08:33:00 -0700 (PDT) From: Jiang Liu To: Yinghai Lu , Yasuaki Ishimatsu , Kenji Kaneshige , Wen Congyang , Tang Chen , Taku Izumi Cc: Hanjun Guo , Yijing Wang , Gong Chen , Jiang Liu , Tony Luck , Huang Ying , Bob Moore , Len Brown , "Srivatsa S . Bhat" , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org Subject: [RFC PATCH v3 13/28] ACPIHP: provide interface to cancel inprogress hotplug operations Date: Sat, 6 Oct 2012 23:27:21 +0800 Message-Id: <1349537256-21670-14-git-send-email-jiang.liu@huawei.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1349537256-21670-1-git-send-email-jiang.liu@huawei.com> References: <1349537256-21670-1-git-send-email-jiang.liu@huawei.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Some hotplug operations, such as hot-removal of memory device, may take very long or even infinite time. One possible solution is to time out and retry, but it's sub-optimal. This patch implements interfaces to cancel inprogress ACPI system device hotplug operations, so user could cancel a long-standing hotplug request on demand. Signed-off-by: Jiang Liu Signed-off-by: Hanjun Guo --- drivers/acpi/hotplug/Makefile | 1 + drivers/acpi/hotplug/acpihp_drv.h | 16 ++++ drivers/acpi/hotplug/cancel.c | 174 +++++++++++++++++++++++++++++++++++++ 3 files changed, 191 insertions(+) create mode 100644 drivers/acpi/hotplug/cancel.c diff --git a/drivers/acpi/hotplug/Makefile b/drivers/acpi/hotplug/Makefile index bfb677f..f72f2c3 100644 --- a/drivers/acpi/hotplug/Makefile +++ b/drivers/acpi/hotplug/Makefile @@ -13,3 +13,4 @@ acpihp_slot-$(CONFIG_ACPI_HOTPLUG_SLOT_FAKE) += slot_fake.o obj-$(CONFIG_ACPI_HOTPLUG_DRIVER) += acpihp_drv.o acpihp_drv-y = drv_main.o acpihp_drv-y += dependency.o +acpihp_drv-y += cancel.o diff --git a/drivers/acpi/hotplug/acpihp_drv.h b/drivers/acpi/hotplug/acpihp_drv.h index 43a44ce..1661e52 100644 --- a/drivers/acpi/hotplug/acpihp_drv.h +++ b/drivers/acpi/hotplug/acpihp_drv.h @@ -44,6 +44,15 @@ enum acpihp_dev_event { ACPIHP_DRV_EVENT_FROM_OS }; +enum acpihp_drv_cancel_state { + ACPIHP_DRV_CANCEL_INIT = 0, + ACPIHP_DRV_CANCEL_STARTED, + ACPIHP_DRV_CANCEL_OK, + ACPIHP_DRV_CANCEL_FAILED, + ACPIHP_DRV_CANCEL_MISSED, + ACPIHP_DRV_CANCEL_FINISHED +}; + struct acpihp_slot_drv { enum acpihp_dev_event event_flag; struct mutex op_mutex; /* Prevent concurrent hotplugs. */ @@ -73,4 +82,11 @@ int acpihp_drv_filter_dependency_list(struct list_head *old_head, int acpihp_drv_generate_dependency_list(struct acpihp_slot *slot, struct list_head *slot_list, enum acpihp_drv_cmd cmd); +void acpihp_drv_cancel_init(struct list_head *list); +void acpihp_drv_cancel_notify(struct acpihp_slot *slot, + enum acpihp_drv_cancel_state state); +void acpihp_drv_cancel_fini(struct list_head *list); +int acpihp_drv_cancel_start(struct list_head *list); +int acpihp_drv_cancel_wait(struct list_head *list); + #endif /* __ACPIHP_DRV_H__ */ diff --git a/drivers/acpi/hotplug/cancel.c b/drivers/acpi/hotplug/cancel.c new file mode 100644 index 0000000..44e9b4a --- /dev/null +++ b/drivers/acpi/hotplug/cancel.c @@ -0,0 +1,174 @@ +/* + * Copyright (C) 2012 Huawei Tech. Co., Ltd. + * Copyright (C) 2012 Jiang Liu + * Copyright (C) 2012 Hanjun Guo + * + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + */ + +#include +#include +#include "acpihp_drv.h" + +/* + * Implements interfaces to cancel inprogress hotplug operations. + * Currently only CONFIGURE and RELEASE operation stages support cancellation. + * Caller must serialize calls to following functions by holding the + * state_machine_mutex lock: + * acpihp_drv_cancel_init() + * acpihp_drv_cancel_fini() + * acpihp_drv_cancel_start() + */ +static DECLARE_WAIT_QUEUE_HEAD(acpihp_drv_cancel_queue); + +static int acpihp_drv_check_cancel(struct acpihp_cancel_context *ctx) +{ + struct acpihp_slot_drv *drv_data; + + BUG_ON(ctx == NULL); + drv_data = container_of(ctx, struct acpihp_slot_drv, cancel_ctx); + + return atomic_read(&drv_data->cancel_state) != ACPIHP_DRV_CANCEL_INIT; +} + +void acpihp_drv_cancel_init(struct list_head *list) +{ + struct acpihp_slot_drv *drv_data; + struct acpihp_slot_dependency *dep; + + /* Wait for all cancellation threads to exit */ + list_for_each_entry(dep, list, node) { + acpihp_drv_get_data(dep->slot, &drv_data); + drv_data->cancel_ctx.check_cancel = acpihp_drv_check_cancel; + atomic_set(&drv_data->cancel_state, ACPIHP_DRV_CANCEL_INIT); + atomic_set(&drv_data->cancel_users, 0); + } +} + +void acpihp_drv_cancel_notify(struct acpihp_slot *slot, + enum acpihp_drv_cancel_state state) +{ + int old; + struct acpihp_slot_drv *drv_data; + + acpihp_drv_get_data(slot, &drv_data); + old = atomic_cmpxchg(&drv_data->cancel_state, ACPIHP_DRV_CANCEL_INIT, + ACPIHP_DRV_CANCEL_FINISHED); + if (old != ACPIHP_DRV_CANCEL_INIT) { + atomic_set(&drv_data->cancel_state, state); + wake_up_all(&acpihp_drv_cancel_queue); + } +} + +/* + * Wait for all cancellation threads to give up their reference count. + * + * Caller must provide mechanism to avoid currently running + * acpihp_drv_cancel_start() and acpihp_drv_cancel_fini() + * on the same list. + */ +void acpihp_drv_cancel_fini(struct list_head *list) +{ + int state; + struct acpihp_slot_drv *drv_data; + struct acpihp_slot_dependency *dep; + + list_for_each_entry(dep, list, node) { + acpihp_drv_get_data(dep->slot, &drv_data); + + /* + * Wake up all cancellation threads if they are still + * STARTED state. + */ + state = atomic_cmpxchg(&drv_data->cancel_state, + ACPIHP_DRV_CANCEL_STARTED, + ACPIHP_DRV_CANCEL_MISSED); + if (state == ACPIHP_DRV_CANCEL_STARTED) + wake_up_all(&acpihp_drv_cancel_queue); + + /* Wait for all cancellation threads to exit */ + wait_event(acpihp_drv_cancel_queue, + !atomic_read(&drv_data->cancel_users)); + } +} + +/* + * Start cancellation on a list of hotplug slots. + * + * Caller must provide mechanism to avoid currently running + * acpihp_drv_cancel_start() and acpihp_drv_cancel_fini() + * on the same list. + */ +int acpihp_drv_cancel_start(struct list_head *list) +{ + struct acpihp_slot_drv *drv_data; + struct acpihp_slot_dependency *dep; + + if (list_empty(list)) { + ACPIHP_DEBUG("dependency list is empty.\n"); + return -ENODEV; + } + + /* Start cancellation on all slots. */ + list_for_each_entry(dep, list, node) { + acpihp_drv_get_data(dep->slot, &drv_data); + atomic_inc(&drv_data->cancel_users); + atomic_cmpxchg(&drv_data->cancel_state, + ACPIHP_DRV_CANCEL_INIT, + ACPIHP_DRV_CANCEL_STARTED); + } + + return 0; +} + +/* + * Wait for all slots on the list to reach a stable state and then check + * cancellation result. + */ +int acpihp_drv_cancel_wait(struct list_head *list) +{ + int state, result = 0; + struct acpihp_slot_drv *drv_data; + struct acpihp_slot_dependency *dep; + + list_for_each_entry(dep, list, node) { + acpihp_drv_get_data(dep->slot, &drv_data); + wait_event(acpihp_drv_cancel_queue, + atomic_read(&drv_data->cancel_state) + != ACPIHP_DRV_CANCEL_STARTED); + + state = atomic_read(&drv_data->cancel_state); + if (state == ACPIHP_DRV_CANCEL_FAILED) { + ACPIHP_SLOT_DEBUG(dep->slot, + "fails to cancel operation.\n"); + result = result ? : -EBUSY; + } else if (state == ACPIHP_DRV_CANCEL_MISSED) { + ACPIHP_SLOT_DEBUG(dep->slot, + "misses to cancel operation.\n"); + result = result ? : -EBUSY; + } + + atomic_set(&drv_data->cancel_state, + ACPIHP_DRV_CANCEL_FINISHED); + atomic_dec(&drv_data->cancel_users); + wake_up_all(&acpihp_drv_cancel_queue); + } + + return result; +}