From patchwork Wed Nov 14 12:27:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yijing Wang X-Patchwork-Id: 1741141 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 62F1CDF264 for ; Wed, 14 Nov 2012 12:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161216Ab2KNM2X (ORCPT ); Wed, 14 Nov 2012 07:28:23 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:54742 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161191Ab2KNM2X (ORCPT ); Wed, 14 Nov 2012 07:28:23 -0500 Received: from 172.24.2.119 (EHLO szxeml205-edg.china.huawei.com) ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.3.4-GA FastPath queued) with ESMTP id ASU14357; Wed, 14 Nov 2012 20:28:17 +0800 (CST) Received: from SZXEML443-HUB.china.huawei.com (10.82.67.181) by szxeml205-edg.china.huawei.com (172.24.2.58) with Microsoft SMTP Server (TLS) id 14.1.323.3; Wed, 14 Nov 2012 20:28:13 +0800 Received: from localhost (10.135.76.84) by SZXEML443-HUB.china.huawei.com (10.82.67.181) with Microsoft SMTP Server id 14.1.323.3; Wed, 14 Nov 2012 20:28:03 +0800 From: Yijing Wang To: Bjorn Helgaas CC: Huang Ying , , Hanjun Guo , , Yijing Wang Subject: [PATCH v5 3/5][RESEND] PCI/AER: clean all untracked pci_ops_aer when rmmod aer_inject Date: Wed, 14 Nov 2012 20:27:20 +0800 Message-ID: <1352896042-11832-4-git-send-email-wangyijing@huawei.com> X-Mailer: git-send-email 1.7.11.msysgit.1 In-Reply-To: <1352896042-11832-1-git-send-email-wangyijing@huawei.com> References: <1352896042-11832-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.135.76.84] X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org When we do hot plug for pci devices that were injected aer errors, some newly created child buses' pci_ops will be assigned to pci_ops_aer. Aer_inject module will not track these pci_ops_aer(not list in pci_bus_ops_list),so we should clean all of these when rmmod aer_inject module. Reviewed-by: Huang Ying Signed-off-by: Yijing Wang --- drivers/pci/pcie/aer/aer_inject.c | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index f499f01..4777c44 100644 --- a/drivers/pci/pcie/aer/aer_inject.c +++ b/drivers/pci/pcie/aer/aer_inject.c @@ -285,6 +285,29 @@ static void pci_bus_ops_init(struct pci_bus_ops *bus_ops, bus_ops->ops = ops; } +static void pci_clean_child_aer_ops(struct pci_bus *bus) +{ + struct pci_bus *child; + + list_for_each_entry(child, &bus->children, node) { + if (child->ops == &pci_ops_aer) + pci_bus_set_ops(child, bus->ops); + pci_clean_child_aer_ops(child); + } +} + +/* find pci_ops_aer from root bus, and replace it by parent bus's pci_ops. + * pci_ops of root bus won't be pci_ops_aer here*/ +static void clean_untracked_pci_ops_aer(void) +{ + struct pci_bus_ops *bus_ops; + + list_for_each_entry(bus_ops, &pci_bus_ops_list, list) { + if (pci_is_root_bus(bus_ops->bus)) + pci_clean_child_aer_ops(bus_ops->bus); + } +} + static int pci_bus_set_aer_ops(struct pci_bus *bus) { struct pci_ops *ops; @@ -546,6 +569,7 @@ static void __exit aer_inject_exit(void) list_for_each_entry(bus_ops, &pci_bus_ops_list, list) pci_bus_set_ops(bus_ops->bus, bus_ops->ops); + clean_untracked_pci_ops_aer(); while ((bus_ops = pci_bus_ops_pop())) kfree(bus_ops);