From patchwork Mon Dec 3 16:37:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Betty Dall X-Patchwork-Id: 1834411 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 046F3DF2F9 for ; Mon, 3 Dec 2012 16:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753574Ab2LCQhe (ORCPT ); Mon, 3 Dec 2012 11:37:34 -0500 Received: from g1t0026.austin.hp.com ([15.216.28.33]:4941 "EHLO g1t0026.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169Ab2LCQhe (ORCPT ); Mon, 3 Dec 2012 11:37:34 -0500 Received: from g1t0038.austin.hp.com (g1t0038.austin.hp.com [16.236.32.44]) by g1t0026.austin.hp.com (Postfix) with ESMTP id D005EC4AF; Mon, 3 Dec 2012 16:37:33 +0000 (UTC) Received: from linux1.fc.hp.com (linux1.fc.hp.com [16.71.12.34]) by g1t0038.austin.hp.com (Postfix) with ESMTP id 548AA30288; Mon, 3 Dec 2012 16:37:33 +0000 (UTC) From: Betty Dall To: bhelgaas@google.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Cc: wangyijing@huawei.com, jiang.liu@huawei.com, Betty Dall Subject: [PATCH] PCI AER: pci_get_domain_bus_and_slot() call missing required pci_dev_put() Date: Mon, 3 Dec 2012 09:37:02 -0700 Message-Id: <1354552622-687-1-git-send-email-betty.dall@hp.com> X-Mailer: git-send-email 1.7.7.6 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The function aer_recover_queue() makes a call to pci_get_domain_bus_and_slot(). That function is documented to require that the caller decrement the reference count by calling pci_dev_put(). This patch adds the missing call to pci_dev_put(). Signed-off-by: Betty Dall Reviewed-by: Shuah Khan --- drivers/pci/pcie/aer/aerdrv_core.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index af4e31c..43caf53 100644 --- a/drivers/pci/pcie/aer/aerdrv_core.c +++ b/drivers/pci/pcie/aer/aerdrv_core.c @@ -616,6 +616,7 @@ static void aer_recover_work_func(struct work_struct *work) continue; } do_recovery(pdev, entry.severity); + pci_dev_put(pdev); } } #endif