| Message ID | 1359657310.6022.4.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Jan 31, 2013 at 11:35 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > In each suspend and resume cycle my laptop prints these messages at > KERN_INFO level: > pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY > pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY > > and > pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY > pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY > > Drop these messages, that were probably used to debug the suspend and > resume code, but now serve no purpose. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> I applied this to pci/misc for v3.9. Thanks! Bjorn > --- > 0) v1 was called "PCI: pciehp: hide ENTRY messages behind ctrl_dbg()". > But Bjorn and Rafael prefer to drop these messages completely. > > 1) Not even compile tested! > > drivers/pci/hotplug/pciehp_core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c > index 939bd1d..7d72c5e 100644 > --- a/drivers/pci/hotplug/pciehp_core.c > +++ b/drivers/pci/hotplug/pciehp_core.c > @@ -293,7 +293,6 @@ static void pciehp_remove(struct pcie_device *dev) > #ifdef CONFIG_PM > static int pciehp_suspend (struct pcie_device *dev) > { > - dev_info(&dev->device, "%s ENTRY\n", __func__); > return 0; > } > > @@ -303,7 +302,6 @@ static int pciehp_resume (struct pcie_device *dev) > struct slot *slot; > u8 status; > > - dev_info(&dev->device, "%s ENTRY\n", __func__); > ctrl = get_service_data(dev); > > /* reinitialize the chipset's event detection logic */ > -- > 1.7.11.7 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index 939bd1d..7d72c5e 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c @@ -293,7 +293,6 @@ static void pciehp_remove(struct pcie_device *dev) #ifdef CONFIG_PM static int pciehp_suspend (struct pcie_device *dev) { - dev_info(&dev->device, "%s ENTRY\n", __func__); return 0; } @@ -303,7 +302,6 @@ static int pciehp_resume (struct pcie_device *dev) struct slot *slot; u8 status; - dev_info(&dev->device, "%s ENTRY\n", __func__); ctrl = get_service_data(dev); /* reinitialize the chipset's event detection logic */
In each suspend and resume cycle my laptop prints these messages at KERN_INFO level: pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY and pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY Drop these messages, that were probably used to debug the suspend and resume code, but now serve no purpose. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) v1 was called "PCI: pciehp: hide ENTRY messages behind ctrl_dbg()". But Bjorn and Rafael prefer to drop these messages completely. 1) Not even compile tested! drivers/pci/hotplug/pciehp_core.c | 2 -- 1 file changed, 2 deletions(-)