From patchwork Thu Jan 31 18:35:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 2074931 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 12BBDDF2E5 for ; Thu, 31 Jan 2013 18:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755693Ab3AaSfR (ORCPT ); Thu, 31 Jan 2013 13:35:17 -0500 Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:59208 "EHLO cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309Ab3AaSfQ (ORCPT ); Thu, 31 Jan 2013 13:35:16 -0500 Received: from cpsps-ews07.kpnxchange.com ([10.94.84.174]) by cpsmtpb-ews04.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Thu, 31 Jan 2013 19:33:56 +0100 Received: from CPSMTPM-TLF104.kpnxchange.com ([195.121.3.7]) by cpsps-ews07.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Thu, 31 Jan 2013 19:33:57 +0100 Received: from [192.168.1.104] ([212.123.139.93]) by CPSMTPM-TLF104.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Thu, 31 Jan 2013 19:35:10 +0100 Message-ID: <1359657310.6022.4.camel@x61.thuisdomein> Subject: [PATCH v2] PCI: pciehp: drop ENTRY messages From: Paul Bolle To: Bjorn Helgaas Cc: "Rafael J. Wysocki" , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 31 Jan 2013 19:35:10 +0100 In-Reply-To: <1450113.teKM2dvJbO@vostro.rjw.lan> References: <1359367251.883.13.camel@x61.thuisdomein> <1450113.teKM2dvJbO@vostro.rjw.lan> X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 X-OriginalArrivalTime: 31 Jan 2013 18:35:10.0343 (UTC) FILETIME=[B33C9970:01CDFFE1] X-RcptDomain: vger.kernel.org Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org In each suspend and resume cycle my laptop prints these messages at KERN_INFO level: pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY and pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY Drop these messages, that were probably used to debug the suspend and resume code, but now serve no purpose. Signed-off-by: Paul Bolle --- 0) v1 was called "PCI: pciehp: hide ENTRY messages behind ctrl_dbg()". But Bjorn and Rafael prefer to drop these messages completely. 1) Not even compile tested! drivers/pci/hotplug/pciehp_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index 939bd1d..7d72c5e 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c @@ -293,7 +293,6 @@ static void pciehp_remove(struct pcie_device *dev) #ifdef CONFIG_PM static int pciehp_suspend (struct pcie_device *dev) { - dev_info(&dev->device, "%s ENTRY\n", __func__); return 0; } @@ -303,7 +302,6 @@ static int pciehp_resume (struct pcie_device *dev) struct slot *slot; u8 status; - dev_info(&dev->device, "%s ENTRY\n", __func__); ctrl = get_service_data(dev); /* reinitialize the chipset's event detection logic */