From patchwork Tue May 14 16:52:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiang Liu X-Patchwork-Id: 2567951 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 7938BE00E6 for ; Tue, 14 May 2013 16:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756472Ab3ENQxv (ORCPT ); Tue, 14 May 2013 12:53:51 -0400 Received: from mail-da0-f44.google.com ([209.85.210.44]:61649 "EHLO mail-da0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758283Ab3ENQxs (ORCPT ); Tue, 14 May 2013 12:53:48 -0400 Received: by mail-da0-f44.google.com with SMTP id z8so421803daj.3 for ; Tue, 14 May 2013 09:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=cuyxTupRFjGPPhJvbJ0E6RYz5JBDapTEgrzheWtPscI=; b=XFLGGlZRNXHreXJ1kQ+56UNvIlUwmld+rkObSgDmmmfAXLjCLSiJArXgU2uPJv45kS guuZGs7lE9t0PQgVPg6ENd4wMR1i5qeecXd44KcBHIvNtworFiFH387VQM9AwGupDmgZ yneAUPRwyXfiRUkAUkfgzicXaCryCihqapSSubpbWWaPdFXEr7H+GwEFfpCuwKFeEYx8 f3ClBmYGeewFJwZ7Kyg8ZcOgJeoK20slzy6EbYONe8ZD/tFIsGGPy2BIcP0VxQGWoiaa 5mVEvISzHpYy/aJAjNvDxO2/6FkVRMMDVciCh752Mw7IiiJxTcx3sIkFnyAILNfDheHG cj+A== X-Received: by 10.66.27.68 with SMTP id r4mr36216959pag.151.1368550427466; Tue, 14 May 2013 09:53:47 -0700 (PDT) Received: from localhost.localdomain ([120.196.98.100]) by mx.google.com with ESMTPSA id v5sm18919924pbz.4.2013.05.14.09.53.41 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 May 2013 09:53:46 -0700 (PDT) From: Jiang Liu To: Bjorn Helgaas , Yinghai Lu Cc: Jiang Liu , "Rafael J . Wysocki" , Greg Kroah-Hartman , Gu Zheng , Toshi Kani , Myron Stowe , Yijing Wang , Jiang Liu , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Ingo Molnar , Donald Dutile , Hannes Reinecke , "Li, Zhen-Hua" , iommu@lists.linux-foundation.org Subject: [RFC PATCH v2, part 2 16/18] PCI, iommu: use hotplug-safe iterators to walk PCI buses Date: Wed, 15 May 2013 00:52:00 +0800 Message-Id: <1368550322-1045-16-git-send-email-jiang.liu@huawei.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1368550322-1045-1-git-send-email-jiang.liu@huawei.com> References: <1368550322-1045-1-git-send-email-jiang.liu@huawei.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Enhance iommu drviers to use hotplug-safe iterators to walk PCI buses. Signed-off-by: Jiang Liu Cc: Joerg Roedel Cc: Ingo Molnar Cc: Donald Dutile Cc: Hannes Reinecke Cc: "Li, Zhen-Hua" Cc: iommu@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org --- drivers/iommu/amd_iommu.c | 4 +++- drivers/iommu/dmar.c | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index e046d7a..d6fdf94 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -357,6 +357,7 @@ static int init_iommu_group(struct device *dev) struct iommu_dev_data *dev_data; struct iommu_group *group; struct pci_dev *dma_pdev; + struct pci_bus *b = NULL; int ret; group = iommu_group_get(dev); @@ -393,7 +394,7 @@ static int init_iommu_group(struct device *dev) * the alias. Be careful to also test the parent device if * we think the alias is the root of the group. */ - bus = pci_find_bus(0, alias >> 8); + b = bus = pci_find_bus(0, alias >> 8); if (!bus) goto use_group; @@ -413,6 +414,7 @@ static int init_iommu_group(struct device *dev) dma_pdev = get_isolation_root(pci_dev_get(to_pci_dev(dev))); use_pdev: ret = use_pdev_iommu_group(dma_pdev, dev); + pci_bus_put(b); pci_dev_put(dma_pdev); return ret; use_group: diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index e5cdaf8..5bb3cdc 100644 --- a/drivers/iommu/dmar.c +++ b/drivers/iommu/dmar.c @@ -67,12 +67,12 @@ static void __init dmar_register_drhd_unit(struct dmar_drhd_unit *drhd) static int __init dmar_parse_one_dev_scope(struct acpi_dmar_device_scope *scope, struct pci_dev **dev, u16 segment) { - struct pci_bus *bus; + struct pci_bus *b, *bus; struct pci_dev *pdev = NULL; struct acpi_dmar_pci_path *path; int count; - bus = pci_find_bus(segment, scope->bus); + b = bus = pci_find_bus(segment, scope->bus); path = (struct acpi_dmar_pci_path *)(scope + 1); count = (scope->length - sizeof(struct acpi_dmar_device_scope)) / sizeof(struct acpi_dmar_pci_path); @@ -97,6 +97,8 @@ static int __init dmar_parse_one_dev_scope(struct acpi_dmar_device_scope *scope, count --; bus = pdev->subordinate; } + pci_bus_put(b); + if (!pdev) { pr_warn("Device scope device [%04x:%02x:%02x.%02x] not found\n", segment, scope->bus, path->dev, path->fn);