From patchwork Tue Jul 23 18:01:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 2832142 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 57D54C0319 for ; Tue, 23 Jul 2013 18:07:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 49CCE20304 for ; Tue, 23 Jul 2013 18:07:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 226BD20300 for ; Tue, 23 Jul 2013 18:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933979Ab3GWSDY (ORCPT ); Tue, 23 Jul 2013 14:03:24 -0400 Received: from sauhun.de ([89.238.76.85]:58737 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933982Ab3GWSDW (ORCPT ); Tue, 23 Jul 2013 14:03:22 -0400 Received: from p5b387ff2.dip0.t-ipconnect.de ([91.56.127.242]:32193 helo=localhost) by pokefinder.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1V1gvg-0001Rj-4D; Tue, 23 Jul 2013 20:03:22 +0200 From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , Bjorn Helgaas , linux-pci@vger.kernel.org Subject: [PATCH 13/27] drivers/pci/host: don't check resource with devm_ioremap_resource Date: Tue, 23 Jul 2013 20:01:46 +0200 Message-Id: <1374602524-3398-14-git-send-email-wsa@the-dreams.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1374602524-3398-1-git-send-email-wsa@the-dreams.de> References: <1374602524-3398-1-git-send-email-wsa@the-dreams.de> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang Acked-by: Bjorn Helgaas --- Please apply via the subsystem-tree. drivers/pci/host/pcie-designware.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 26bdbda..f0ba6ef 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -817,28 +817,16 @@ static int add_pcie_port(struct pcie_port *pp, struct platform_device *pdev) int ret; elbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!elbi_base) { - dev_err(&pdev->dev, "couldn't get elbi base resource\n"); - return -EINVAL; - } pp->elbi_base = devm_ioremap_resource(&pdev->dev, elbi_base); if (IS_ERR(pp->elbi_base)) return PTR_ERR(pp->elbi_base); phy_base = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!phy_base) { - dev_err(&pdev->dev, "couldn't get phy base resource\n"); - return -EINVAL; - } pp->phy_base = devm_ioremap_resource(&pdev->dev, phy_base); if (IS_ERR(pp->phy_base)) return PTR_ERR(pp->phy_base); purple_base = platform_get_resource(pdev, IORESOURCE_MEM, 2); - if (!purple_base) { - dev_err(&pdev->dev, "couldn't get purple base resource\n"); - return -EINVAL; - } pp->purple_base = devm_ioremap_resource(&pdev->dev, purple_base); if (IS_ERR(pp->purple_base)) return PTR_ERR(pp->purple_base);