| Message ID | 1385955575-25270-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Dear Fabio Estevam, > From: Fabio Estevam <fabio.estevam@freescale.com> > > When using devm_ioremap_resource(), we do not need to check the return > value of platform_get_resource(), so just remove it. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Acked-by: Marek Vasut <marex@denx.de> > --- > drivers/pci/host/pci-imx6.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > index bd70af8..5002e23 100644 > --- a/drivers/pci/host/pci-imx6.c > +++ b/drivers/pci/host/pci-imx6.c > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct > platform_device *pdev) "imprecise external abort"); > > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!dbi_base) { > - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); > - return -ENODEV; > - } > - > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); > if (IS_ERR(pp->dbi_base)) { > ret = PTR_ERR(pp->dbi_base); Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[+cc Shawn] On Mon, Dec 02, 2013 at 01:39:34AM -0200, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > When using devm_ioremap_resource(), we do not need to check the return value of > platform_get_resource(), so just remove it. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> I applied this with Marek's ack to pci/host-imx6 for v3.14. Shawn, let me know if you object. It looks correct to me because devm_ioremap_resource() checks for res being NULL. > --- > drivers/pci/host/pci-imx6.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > index bd70af8..5002e23 100644 > --- a/drivers/pci/host/pci-imx6.c > +++ b/drivers/pci/host/pci-imx6.c > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) > "imprecise external abort"); > > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!dbi_base) { > - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); > - return -ENODEV; > - } > - > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); > if (IS_ERR(pp->dbi_base)) { > ret = PTR_ERR(pp->dbi_base); > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index bd70af8..5002e23 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) "imprecise external abort"); dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!dbi_base) { - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); - return -ENODEV; - } - pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); if (IS_ERR(pp->dbi_base)) { ret = PTR_ERR(pp->dbi_base);