| Message ID | 1403272331-3790755-1-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Thanks for the series. Patch 2 is equivalent to patches 1 and 2 from Sachin Kamat's series. @Greg: This series together with Sachin's patches should fix all build errors. I'll send patches for the remaining warnings later. Andreas On Fri, Jun 20, 2014 at 3:52 PM, Arnd Bergmann <arnd@arndb.de> wrote: > The thunderbolt drivers cannot be built if CONFIG_PCI is disabled, > better add an explicit Kconfig dependency. > The "default no" line is redundant and can be removed at the same > time. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/thunderbolt/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig > index 3a25529..5aab79b 100644 > --- a/drivers/thunderbolt/Kconfig > +++ b/drivers/thunderbolt/Kconfig > @@ -1,6 +1,6 @@ > menuconfig THUNDERBOLT > tristate "Thunderbolt support for Apple devices" > - default no > + depends on PCI > help > Cactus Ridge Thunderbolt Controller driver > This driver is required if you want to hotplug Thunderbolt devices on > -- > 1.8.3.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 20, 2014 at 04:44:05PM +0200, Andreas Noever wrote: > Thanks for the series. > > Patch 2 is equivalent to patches 1 and 2 from Sachin Kamat's series. > > @Greg: This series together with Sachin's patches should fix all build > errors. I'll send patches for the remaining warnings later. Thanks, I'll apply patches 1 and 3 here. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig index 3a25529..5aab79b 100644 --- a/drivers/thunderbolt/Kconfig +++ b/drivers/thunderbolt/Kconfig @@ -1,6 +1,6 @@ menuconfig THUNDERBOLT tristate "Thunderbolt support for Apple devices" - default no + depends on PCI help Cactus Ridge Thunderbolt Controller driver This driver is required if you want to hotplug Thunderbolt devices on
The thunderbolt drivers cannot be built if CONFIG_PCI is disabled, better add an explicit Kconfig dependency. The "default no" line is redundant and can be removed at the same time. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/thunderbolt/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)