| Message ID | 1412069804-17162-11-git-send-email-r65037@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Hi Richard, On Tue, Sep 30, 2014 at 6:36 AM, Richard Zhu <r65037@freescale.com> wrote: > Signed-off-by: Richard Zhu <r65037@freescale.com> > --- > arch/arm/boot/dts/imx6sx-sdb.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts > index a3980d9..2976913 100644 > --- a/arch/arm/boot/dts/imx6sx-sdb.dts > +++ b/arch/arm/boot/dts/imx6sx-sdb.dts > @@ -251,6 +251,13 @@ > }; > }; > > +&pcie { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcie>; > + reset-gpio = <&gpio2 0 0>; > + status = "okay"; > +}; There is also GPIO2_1 which is the PCIE_PWR_EN signal and should be added as a GPIO controlled regulator. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WWVzLCAgUENJRV9QV1JfRU4gd291bGQgYmUgYWRkZWQgbGF0ZXIuDQpUaGFua3MsIEZhYmlvLg0K DQpCZXN0IHJlZ2FyZHMNClJpY2hhcmQNCg0KPiDU2iAyMDE0xOoxMNTCMcjVo6zJz87nMTI6MjGj rCJGYWJpbyBFc3RldmFtIiA8ZmVzdGV2YW1AZ21haWwuY29tPiDQtLXAo7oNCj4gDQo+IEhpIFJp Y2hhcmQsDQo+IA0KPj4gT24gVHVlLCBTZXAgMzAsIDIwMTQgYXQgNjozNiBBTSwgUmljaGFyZCBa aHUgPHI2NTAzN0BmcmVlc2NhbGUuY29tPiB3cm90ZToNCj4+IFNpZ25lZC1vZmYtYnk6IFJpY2hh cmQgWmh1IDxyNjUwMzdAZnJlZXNjYWxlLmNvbT4NCj4+IC0tLQ0KPj4gYXJjaC9hcm0vYm9vdC9k dHMvaW14NnN4LXNkYi5kdHMgfCAxMyArKysrKysrKysrKysrDQo+PiAxIGZpbGUgY2hhbmdlZCwg MTMgaW5zZXJ0aW9ucygrKQ0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMv aW14NnN4LXNkYi5kdHMgYi9hcmNoL2FybS9ib290L2R0cy9pbXg2c3gtc2RiLmR0cw0KPj4gaW5k ZXggYTM5ODBkOS4uMjk3NjkxMyAxMDA2NDQNCj4+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2lt eDZzeC1zZGIuZHRzDQo+PiArKysgYi9hcmNoL2FybS9ib290L2R0cy9pbXg2c3gtc2RiLmR0cw0K Pj4gQEAgLTI1MSw2ICsyNTEsMTMgQEANCj4+ICAgICAgICB9Ow0KPj4gfTsNCj4+IA0KPj4gKyZw Y2llIHsNCj4+ICsgICAgICAgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsNCj4+ICsgICAgICAg cGluY3RybC0wID0gPCZwaW5jdHJsX3BjaWU+Ow0KPj4gKyAgICAgICByZXNldC1ncGlvID0gPCZn cGlvMiAwIDA+Ow0KPj4gKyAgICAgICBzdGF0dXMgPSAib2theSI7DQo+PiArfTsNCj4gDQo+IFRo ZXJlIGlzIGFsc28gR1BJTzJfMSB3aGljaCBpcyB0aGUgUENJRV9QV1JfRU4gc2lnbmFsIGFuZCBz aG91bGQgYmUNCj4gYWRkZWQgYXMgYSBHUElPIGNvbnRyb2xsZWQgcmVndWxhdG9yLg0K -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Fabio: > -----Original Message----- > From: Zhu Richard-R65037 > Sent: Thursday, October 02, 2014 10:40 AM > To: Fabio Estevam > Cc: Zhu Richard-R65037; linux-pci-owner@vger.kernel.org; linux- > pci@vger.kernel.org; Guo Shawn-R65073; Lucas Stach; Tim Harvey > Subject: Re: [PATCH v4 10/10] ARM: imx6sx: enable pcie on imx6sx sdb board > > Yes, PCIE_PWR_EN would be added later. > Thanks, Fabio. > > Best regards > Richard > > > ? 2014?10?1????12:21?"Fabio Estevam" <festevam@gmail.com> ??? > > > > Hi Richard, > > > >> On Tue, Sep 30, 2014 at 6:36 AM, Richard Zhu <r65037@freescale.com> wrote: > >> Signed-off-by: Richard Zhu <r65037@freescale.com> > >> --- > >> arch/arm/boot/dts/imx6sx-sdb.dts | 13 +++++++++++++ > >> 1 file changed, 13 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts > >> b/arch/arm/boot/dts/imx6sx-sdb.dts > >> index a3980d9..2976913 100644 > >> --- a/arch/arm/boot/dts/imx6sx-sdb.dts > >> +++ b/arch/arm/boot/dts/imx6sx-sdb.dts > >> @@ -251,6 +251,13 @@ > >> }; > >> }; > >> > >> +&pcie { > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_pcie>; > >> + reset-gpio = <&gpio2 0 0>; > >> + status = "okay"; > >> +}; > > > > There is also GPIO2_1 which is the PCIE_PWR_EN signal and should be > > added as a GPIO controlled regulator. [Richard] The GIPO controlled regulator is discarded in the latest kernel, it is pointed out by Lucas in the previous review. " > @@ -502,6 +503,7 @@ > &pcie { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_pcie>; > + power-on-gpio = <&gpio3 19 0>; > reset-gpio = <&gpio7 12 0>; > status = "okay"; > }; This hunk is wrong. There is no "power-on-gpio" in the binding anymore. Also there is already a change in Shawns tree to model this as a always-on regulator. If we really want to control pci bus power this needs to be done through this regulator, not some arbitrary gpio hack. " Best Regards Richard Zhu
On Wed, Oct 8, 2014 at 3:41 AM, Hong-Xing.Zhu@freescale.com <Hong-Xing.Zhu@freescale.com> wrote: > This hunk is wrong. There is no "power-on-gpio" in the binding anymore. > Also there is already a change in Shawns tree to model this as a always-on regulator. If we really want to control pci bus power this needs to be done through this regulator, not some arbitrary gpio hack. Yes, I never asked you to include 'power-on-gpio'. What needs to be done is the same as in imx6qdl-sabresd, which passes the regulator that powers the PCI slot. You can refer to Shawn's tree or linux-next. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEZhYmlvIEVzdGV2YW0gW21h aWx0bzpmZXN0ZXZhbUBnbWFpbC5jb21dDQo+IFNlbnQ6IFRodXJzZGF5LCBPY3RvYmVyIDA5LCAy MDE0IDk6MTEgQU0NCj4gVG86IFpodSBSaWNoYXJkLVI2NTAzNw0KPiBDYzogbGludXgtcGNpLW93 bmVyQHZnZXIua2VybmVsLm9yZzsgbGludXgtcGNpQHZnZXIua2VybmVsLm9yZzsgR3VvIFNoYXdu LQ0KPiBSNjUwNzM7IEx1Y2FzIFN0YWNoOyBUaW0gSGFydmV5DQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjQgMTAvMTBdIEFSTTogaW14NnN4OiBlbmFibGUgcGNpZSBvbiBpbXg2c3ggc2RiIGJvYXJk DQo+IA0KPiBPbiBXZWQsIE9jdCA4LCAyMDE0IGF0IDM6NDEgQU0sIEhvbmctWGluZy5aaHVAZnJl ZXNjYWxlLmNvbSA8SG9uZy0NCj4gWGluZy5aaHVAZnJlZXNjYWxlLmNvbT4gd3JvdGU6DQo+IA0K PiA+IFRoaXMgaHVuayBpcyB3cm9uZy4gVGhlcmUgaXMgbm8gInBvd2VyLW9uLWdwaW8iIGluIHRo ZSBiaW5kaW5nIGFueW1vcmUuDQo+ID4gQWxzbyB0aGVyZSBpcyBhbHJlYWR5IGEgY2hhbmdlIGlu IFNoYXducyB0cmVlIHRvIG1vZGVsIHRoaXMgYXMgYSBhbHdheXMtb24NCj4gcmVndWxhdG9yLiBJ ZiB3ZSByZWFsbHkgd2FudCB0byBjb250cm9sIHBjaSBidXMgcG93ZXIgdGhpcyBuZWVkcyB0byBi ZSBkb25lDQo+IHRocm91Z2ggdGhpcyByZWd1bGF0b3IsIG5vdCBzb21lIGFyYml0cmFyeSBncGlv IGhhY2suDQo+IA0KPiBZZXMsIEkgbmV2ZXIgYXNrZWQgeW91IHRvIGluY2x1ZGUgJ3Bvd2VyLW9u LWdwaW8nLiBXaGF0IG5lZWRzIHRvIGJlIGRvbmUgaXMNCj4gdGhlIHNhbWUgYXMgaW4gaW14NnFk bC1zYWJyZXNkLCB3aGljaCBwYXNzZXMgdGhlIHJlZ3VsYXRvciB0aGF0IHBvd2VycyB0aGUgUENJ DQo+IHNsb3QuIFlvdSBjYW4gcmVmZXIgdG8gU2hhd24ncyB0cmVlIG9yIGxpbnV4LW5leHQuDQpb UmljaGFyZF0gVW5kZXJzdGFuZCwgdGhhbmtzIGEgbG90Lg0KDQpCVFcsIHRoZSBlbWFpbCBuYW1l IGNoYW5nZSBpcyBzdGlsbCBvbi1nb2luZywgd291bGQgYmUgZmluaXNoZWQgbGF0ZXIuDQoNCkJl c3QgUmVnYXJkcw0KUmljaGFyZCBaaHUNCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/imx6sx-sdb.dts b/arch/arm/boot/dts/imx6sx-sdb.dts index a3980d9..2976913 100644 --- a/arch/arm/boot/dts/imx6sx-sdb.dts +++ b/arch/arm/boot/dts/imx6sx-sdb.dts @@ -251,6 +251,13 @@ }; }; +&pcie { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pcie>; + reset-gpio = <&gpio2 0 0>; + status = "okay"; +}; + &ssi2 { status = "okay"; }; @@ -365,6 +372,12 @@ >; }; + pinctrl_pcie: pciegrp { + fsl,pins = < + MX6SX_PAD_ENET1_COL__GPIO2_IO_0 0x17059 + >; + }; + pinctrl_vcc_sd3: vccsd3grp { fsl,pins = < MX6SX_PAD_KEY_COL1__GPIO2_IO_11 0x17059
Signed-off-by: Richard Zhu <r65037@freescale.com> --- arch/arm/boot/dts/imx6sx-sdb.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)