| Message ID | 1414663725-2195-20-git-send-email-ray.huang@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Oct 30, 2014 at 06:08:44PM +0800, Huang Rui wrote: > This patch adds support for AMD Nolan (NL) FPGA and SoC platform. > > Cc: Jason Chang <jason.chang@amd.com> > Signed-off-by: Huang Rui <ray.huang@amd.com> > --- > drivers/usb/dwc3/dwc3-pci.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > index ada975f..257fb3f9e 100644 > --- a/drivers/usb/dwc3/dwc3-pci.c > +++ b/drivers/usb/dwc3/dwc3-pci.c > @@ -145,6 +145,28 @@ static int dwc3_pci_probe(struct pci_dev *pci, > res[1].name = "dwc_usb3"; > res[1].flags = IORESOURCE_IRQ; > > + if (pci->vendor == PCI_VENDOR_ID_AMD && > + pci->device == PCI_DEVICE_ID_AMD_NL_USB) { > + dwc3_pdata.has_lpm_erratum = true; > + dwc3_pdata.lpm_nyet_threshold = 0xf; > + > + dwc3_pdata.u2exit_lfps_quirk = true; > + dwc3_pdata.u2ss_inp3_quirk = true; > + dwc3_pdata.req_p1p2p3_quirk = true; > + dwc3_pdata.del_p1p2p3_quirk = true; > + dwc3_pdata.del_phy_power_chg_quirk = true; > + dwc3_pdata.lfps_filter_quirk = true; > + dwc3_pdata.rx_detect_poll_quirk = true; > + > + dwc3_pdata.tx_de_emphasis_quirk = true; > + dwc3_pdata.tx_de_emphasis = 1; > + > + /* FIXME these quirks should move when AMD NL taps out */ do you mean ? /* * FIXME these quirks should be removed when AMD NL * tapes out */
On Thu, Oct 30, 2014 at 11:38:40AM -0500, Felipe Balbi wrote: > On Thu, Oct 30, 2014 at 06:08:44PM +0800, Huang Rui wrote: > > This patch adds support for AMD Nolan (NL) FPGA and SoC platform. > > > > Cc: Jason Chang <jason.chang@amd.com> > > Signed-off-by: Huang Rui <ray.huang@amd.com> > > --- > > drivers/usb/dwc3/dwc3-pci.c | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > > index ada975f..257fb3f9e 100644 > > --- a/drivers/usb/dwc3/dwc3-pci.c > > +++ b/drivers/usb/dwc3/dwc3-pci.c > > @@ -145,6 +145,28 @@ static int dwc3_pci_probe(struct pci_dev *pci, > > res[1].name = "dwc_usb3"; > > res[1].flags = IORESOURCE_IRQ; > > > > + if (pci->vendor == PCI_VENDOR_ID_AMD && > > + pci->device == PCI_DEVICE_ID_AMD_NL_USB) { > > + dwc3_pdata.has_lpm_erratum = true; > > + dwc3_pdata.lpm_nyet_threshold = 0xf; > > + > > + dwc3_pdata.u2exit_lfps_quirk = true; > > + dwc3_pdata.u2ss_inp3_quirk = true; > > + dwc3_pdata.req_p1p2p3_quirk = true; > > + dwc3_pdata.del_p1p2p3_quirk = true; > > + dwc3_pdata.del_phy_power_chg_quirk = true; > > + dwc3_pdata.lfps_filter_quirk = true; > > + dwc3_pdata.rx_detect_poll_quirk = true; > > + > > + dwc3_pdata.tx_de_emphasis_quirk = true; > > + dwc3_pdata.tx_de_emphasis = 1; > > + > > + /* FIXME these quirks should move when AMD NL taps out */ > > do you mean ? > > /* > * FIXME these quirks should be removed when AMD NL > * tapes out > */ > That's right, will update. Thanks, Rui -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index ada975f..257fb3f9e 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -145,6 +145,28 @@ static int dwc3_pci_probe(struct pci_dev *pci, res[1].name = "dwc_usb3"; res[1].flags = IORESOURCE_IRQ; + if (pci->vendor == PCI_VENDOR_ID_AMD && + pci->device == PCI_DEVICE_ID_AMD_NL_USB) { + dwc3_pdata.has_lpm_erratum = true; + dwc3_pdata.lpm_nyet_threshold = 0xf; + + dwc3_pdata.u2exit_lfps_quirk = true; + dwc3_pdata.u2ss_inp3_quirk = true; + dwc3_pdata.req_p1p2p3_quirk = true; + dwc3_pdata.del_p1p2p3_quirk = true; + dwc3_pdata.del_phy_power_chg_quirk = true; + dwc3_pdata.lfps_filter_quirk = true; + dwc3_pdata.rx_detect_poll_quirk = true; + + dwc3_pdata.tx_de_emphasis_quirk = true; + dwc3_pdata.tx_de_emphasis = 1; + + /* FIXME these quirks should move when AMD NL taps out */ + dwc3_pdata.disable_scramble_quirk = true; + dwc3_pdata.dis_u3_susphy_quirk = true; + dwc3_pdata.dis_u2_susphy_quirk = true; + } + ret = platform_device_add_resources(dwc3, res, ARRAY_SIZE(res)); if (ret) { dev_err(dev, "couldn't add resources to dwc3 device\n"); @@ -194,6 +216,7 @@ static const struct pci_device_id dwc3_pci_id_table[] = { { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BSW), }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT), }, { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_MRFLD), }, + { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_NL_USB), }, { } /* Terminating Entry */ }; MODULE_DEVICE_TABLE(pci, dwc3_pci_id_table);
This patch adds support for AMD Nolan (NL) FPGA and SoC platform. Cc: Jason Chang <jason.chang@amd.com> Signed-off-by: Huang Rui <ray.huang@amd.com> --- drivers/usb/dwc3/dwc3-pci.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)