From patchwork Fri Apr 3 09:25:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yijing Wang X-Patchwork-Id: 6154791 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 08DB79F398 for ; Fri, 3 Apr 2015 09:30:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 187572010B for ; Fri, 3 Apr 2015 09:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24856203F1 for ; Fri, 3 Apr 2015 09:30:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbbDCJaB (ORCPT ); Fri, 3 Apr 2015 05:30:01 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:55273 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbbDCJ3N (ORCPT ); Fri, 3 Apr 2015 05:29:13 -0400 Received: from 172.24.2.119 (EHLO szxeml430-hub.china.huawei.com) ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CLR08843; Fri, 03 Apr 2015 17:28:59 +0800 (CST) Received: from localhost.localdomain (10.175.100.166) by szxeml430-hub.china.huawei.com (10.82.67.185) with Microsoft SMTP Server id 14.3.158.1; Fri, 3 Apr 2015 17:28:42 +0800 From: Yijing Wang To: Bjorn Helgaas CC: Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven , "Yijing Wang" Subject: [PATCH v9 10/30] PCI: Introduce pci_host_bridge_list to manage host bridges Date: Fri, 3 Apr 2015 17:25:44 +0800 Message-ID: <1428053164-28277-12-git-send-email-wangyijing@huawei.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1428053164-28277-1-git-send-email-wangyijing@huawei.com> References: <1428053164-28277-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.166] X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Introduce pci_host_bridge_list to manage pci host bridges in system, this make us have the ability to check whether the new host would conflict with existing one. Then we could remove bus alreay exist check in __pci_create_root_bus(). Signed-off-by: Yijing Wang --- drivers/pci/host-bridge.c | 41 ++++++++++++++++++++++++++++++++++++++++- drivers/pci/probe.c | 9 +-------- include/linux/pci.h | 1 + 3 files changed, 42 insertions(+), 9 deletions(-) diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c index 1a9834b..dffb345 100644 --- a/drivers/pci/host-bridge.c +++ b/drivers/pci/host-bridge.c @@ -8,6 +8,9 @@ #include "pci.h" +static LIST_HEAD(pci_host_bridge_list); +static DEFINE_MUTEX(pci_host_mutex); + static void pci_release_host_bridge_dev(struct device *dev) { struct pci_host_bridge *bridge = to_pci_host_bridge(dev); @@ -41,12 +44,29 @@ static void pci_host_update_busn_res( pci_add_resource(resources, &host->busn_res); } +static bool pci_host_busn_res_overlap( + struct pci_host_bridge *new, struct pci_host_bridge *old) +{ + struct resource_entry *entry; + struct resource *res1 = NULL, *res2 = NULL; + + resource_list_for_each_entry(entry, &old->windows) + if (entry->res->flags & IORESOURCE_BUS) + res1 = entry->res; + + resource_list_for_each_entry(entry, &new->windows) + if (entry->res->flags & IORESOURCE_BUS) + res2 = entry->res; + + return resource_overlaps(res1, res2); +} + struct pci_host_bridge *pci_create_host_bridge( struct device *parent, int domain, int bus, struct list_head *resources) { int error; - struct pci_host_bridge *host; + struct pci_host_bridge *host, *tmp; struct resource_entry *window, *n; host = kzalloc(sizeof(*host), GFP_KERNEL); @@ -65,6 +85,21 @@ struct pci_host_bridge *pci_create_host_bridge( */ host->domain = domain; pci_host_assign_domain_nr(host); + mutex_lock(&pci_host_mutex); + list_for_each_entry(tmp, &pci_host_bridge_list, list) { + if (tmp->domain == host->domain + && pci_host_busn_res_overlap(host, tmp)) { + pr_warn("pci host bridge pci%04x:%02x exist\n", + host->domain, bus); + mutex_unlock(&pci_host_mutex); + pci_free_resource_list(&host->windows); + kfree(host); + return NULL; + } + } + list_add_tail(&host->list, &pci_host_bridge_list); + mutex_unlock(&pci_host_mutex); + host->dev.release = pci_release_host_bridge_dev; dev_set_name(&host->dev, "pci%04x:%02x", host->domain, bus); @@ -80,6 +115,10 @@ struct pci_host_bridge *pci_create_host_bridge( void pci_free_host_bridge(struct pci_host_bridge *host) { + mutex_lock(&pci_host_mutex); + list_del(&host->list); + mutex_unlock(&pci_host_mutex); + device_unregister(&host->dev); } diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 25ac741..8517d1b 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1869,7 +1869,7 @@ static struct pci_bus *__pci_create_root_bus( void *sysdata) { int error; - struct pci_bus *b, *b2; + struct pci_bus *b; struct resource_entry *window; struct device *parent; struct resource *res; @@ -1887,12 +1887,6 @@ static struct pci_bus *__pci_create_root_bus( b->number = b->busn_res.start = pci_host_first_busnr(bridge); pci_bus_assign_domain_nr(b, parent); - b2 = pci_find_bus(pci_domain_nr(b), b->number); - if (b2) { - /* If we already got to this bus through a different bridge, ignore it */ - dev_dbg(&b2->dev, "bus already known\n"); - goto err_out; - } bridge->bus = b; b->bridge = get_device(&bridge->dev); @@ -1952,7 +1946,6 @@ static struct pci_bus *__pci_create_root_bus( put_dev: put_device(&bridge->dev); -err_out: kfree(b); return NULL; } diff --git a/include/linux/pci.h b/include/linux/pci.h index f189dfb..91cba01 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -407,6 +407,7 @@ struct pci_host_bridge { /* we use default bus resource if no bus resource provided */ struct resource busn_res; struct list_head windows; /* resource_entry */ + struct list_head list; void (*release_fn)(struct pci_host_bridge *); void *release_data; };