| Message ID | 1437515651-20883-1-git-send-email-m-karicheri2@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On 07/21/2015 05:54 PM, Murali Karicheri wrote: > Currently on Keystone SoCs, boot up log shows an unnecessary boot > noise as follows:- > > [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space > > Keystone uses older version of designware h/w that doesn't have ATU > support. So va_cfg0_base and va_cfg1_base are already set up in > ks_dw_pcie_host_init() before calling dw_pcie_host_init() and > they point to the remote config space address va (both same for Keystone). > So add a check to avoid this boot noise on Keystone. > > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> > --- > - Resend with "PCI: designware" prefix in subject > drivers/pci/host/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 69486be..b48b8a2 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > addrp = of_get_address(np, index, NULL, NULL); > pp->cfg0_mod_base = of_read_number(addrp, ns); > pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size; > - } else { > + } else if (!pp->va_cfg0_base) { > dev_err(pp->dev, "missing *config* reg space\n"); > } > > A gentle ping to review and apply this to pci next.
On 2015. 7. 22., at AM 6:54, Murali Karicheri <m-karicheri2@ti.com> wrote: > > Currently on Keystone SoCs, boot up log shows an unnecessary boot > noise as follows:- > > [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space > > Keystone uses older version of designware h/w that doesn't have ATU > support. So va_cfg0_base and va_cfg1_base are already set up in > ks_dw_pcie_host_init() before calling dw_pcie_host_init() and > they point to the remote config space address va (both same for Keystone). > So add a check to avoid this boot noise on Keystone. > > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> Acked-by: Jingoo Han <jingoohan1@gmail.com> Best regards, Jingoo Han > --- > - Resend with "PCI: designware" prefix in subject > drivers/pci/host/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 69486be..b48b8a2 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp) > addrp = of_get_address(np, index, NULL, NULL); > pp->cfg0_mod_base = of_read_number(addrp, ns); > pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size; > - } else { > + } else if (!pp->va_cfg0_base) { > dev_err(pp->dev, "missing *config* reg space\n"); > } > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/30/2015 11:50 AM, Murali Karicheri wrote: > On 07/21/2015 05:54 PM, Murali Karicheri wrote: >> Currently on Keystone SoCs, boot up log shows an unnecessary boot >> noise as follows:- >> >> [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space >> >> Keystone uses older version of designware h/w that doesn't have ATU >> support. So va_cfg0_base and va_cfg1_base are already set up in >> ks_dw_pcie_host_init() before calling dw_pcie_host_init() and >> they point to the remote config space address va (both same for >> Keystone). >> So add a check to avoid this boot noise on Keystone. >> >> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >> --- >> - Resend with "PCI: designware" prefix in subject >> drivers/pci/host/pcie-designware.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/host/pcie-designware.c >> b/drivers/pci/host/pcie-designware.c >> index 69486be..b48b8a2 100644 >> --- a/drivers/pci/host/pcie-designware.c >> +++ b/drivers/pci/host/pcie-designware.c >> @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp) >> addrp = of_get_address(np, index, NULL, NULL); >> pp->cfg0_mod_base = of_read_number(addrp, ns); >> pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size; >> - } else { >> + } else if (!pp->va_cfg0_base) { >> dev_err(pp->dev, "missing *config* reg space\n"); >> } >> >> > A gentle ping to review and apply this to pci next. > Bjorn, Not sure why this is not picked for merge. Can you pick this up please!
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 69486be..b48b8a2 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp) addrp = of_get_address(np, index, NULL, NULL); pp->cfg0_mod_base = of_read_number(addrp, ns); pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size; - } else { + } else if (!pp->va_cfg0_base) { dev_err(pp->dev, "missing *config* reg space\n"); }
Currently on Keystone SoCs, boot up log shows an unnecessary boot noise as follows:- [ 0.365823] keystone-pcie 21021000.pcie: missing *config* reg space Keystone uses older version of designware h/w that doesn't have ATU support. So va_cfg0_base and va_cfg1_base are already set up in ks_dw_pcie_host_init() before calling dw_pcie_host_init() and they point to the remote config space address va (both same for Keystone). So add a check to avoid this boot noise on Keystone. Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> --- - Resend with "PCI: designware" prefix in subject drivers/pci/host/pcie-designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)