From patchwork Fri Jul 31 10:15:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ley Foon Tan X-Patchwork-Id: 6909941 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 66F5B9F380 for ; Fri, 31 Jul 2015 10:16:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0F9C12061E for ; Fri, 31 Jul 2015 10:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8886520613 for ; Fri, 31 Jul 2015 10:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbbGaKQi (ORCPT ); Fri, 31 Jul 2015 06:16:38 -0400 Received: from mail-bn1on0080.outbound.protection.outlook.com ([157.56.110.80]:16168 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751483AbbGaKPb (ORCPT ); Fri, 31 Jul 2015 06:15:31 -0400 Received: from BLUPR0301CA0026.namprd03.prod.outlook.com (10.162.113.164) by BLUPR03MB033.namprd03.prod.outlook.com (10.255.209.145) with Microsoft SMTP Server (TLS) id 15.1.225.19; Fri, 31 Jul 2015 10:15:29 +0000 Received: from BN1AFFO11FD038.protection.gbl (2a01:111:f400:7c10::184) by BLUPR0301CA0026.outlook.office365.com (2a01:111:e400:5259::36) with Microsoft SMTP Server (TLS) id 15.1.225.19 via Frontend Transport; Fri, 31 Jul 2015 10:15:28 +0000 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning altera.com discourages use of 66.35.236.227 as permitted sender) Received: from sj-itexedge03.altera.priv.altera.com (66.35.236.227) by BN1AFFO11FD038.mail.protection.outlook.com (10.58.52.242) with Microsoft SMTP Server (TLS) id 15.1.231.11 via Frontend Transport; Fri, 31 Jul 2015 10:15:28 +0000 Received: from sj-mail01.altera.com (137.57.1.6) by webmail.altera.com (66.35.236.227) with Microsoft SMTP Server (TLS) id 14.3.174.1; Fri, 31 Jul 2015 03:14:04 -0700 Received: from leyfoon-vm (pg-lftan-l.altera.com [137.57.103.123]) by sj-mail01.altera.com (8.13.7+Sun/8.13.7) with SMTP id t6VAFLot004502; Fri, 31 Jul 2015 03:15:22 -0700 (PDT) Received: by leyfoon-vm (sSMTP sendmail emulation); Fri, 31 Jul 2015 18:15:32 +0800 From: Ley Foon Tan To: Bjorn Helgaas , Russell King , Arnd Bergmann , Dinh Nguyen CC: , , , , , Ley Foon Tan , , Rob Herring Subject: [PATCH v2 3/5] pci: altera: Add Altera PCIe MSI driver Date: Fri, 31 Jul 2015 18:15:13 +0800 Message-ID: <1438337715-22594-4-git-send-email-lftan@altera.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1438337715-22594-1-git-send-email-lftan@altera.com> References: <1438337715-22594-1-git-send-email-lftan@altera.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD038; 1:BK6Tno3Fa21yUV3yWHI7opZ2ypcH7CTIsPkMS0S6aKPIAn+gjjAfNN+FO4ZB6Wmp7mMpZIwovuuD4o6512fzzXcCzhvwX1oRke4HqXQvAqldNuQd7Wgp76UT89oxlUdX2vaIboBBhrJfL3qGJUizwiw5heXRm6LDoBgdfN8pikzFHet6aJv83HdZZgwNWduHqQVXdZF+52eNGgZQmvFakjLAedZsmVsixZW+FiprlsuDcjN+eam5wWEAGJoeFJ6kWg9fQLMxFu2wEfHcr4wgzIKx+Go2DX5mNXh13MBTeyQ//2xJ9mjd6d0EmOUWff1A X-Forefront-Antispam-Report: CIP:66.35.236.227; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(189002)(199003)(33646002)(106466001)(48376002)(92566002)(229853001)(6806004)(2950100001)(19580395003)(15975445007)(50986999)(19580405001)(50226001)(50466002)(87936001)(77156002)(62966003)(46102003)(76176999)(36756003)(5001770100001)(189998001)(5001920100001)(86362001)(4001450100002)(42186005)(47776003)(5001960100002)(105596002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB033; H:sj-itexedge03.altera.priv.altera.com; FPR:; SPF:SoftFail; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB033; 2:w/e/4EhahaQdSQo1XPfZ2V+5GufSOexcsDdlSyBJD30R17Of4tlanPlbToxIFET8u8IWBmamlaGL9Rhn2ISMI/jSyJjgfeI8dU8BYxozJ3BQoleD2FxgAUkikR5oGwQXmy8WbkUwwZwBmiuZMiUXqQToVt8rb8WrnaU51/c0RdY=; 3:rejqqdpPIDgxSaEcNz6w1PZNyIEF4ks4NuLVAJXu322Jjcr8G/KiKhsgby2F+AUXHLsVWlICmU85gjZYbLX03RMpp8qNQUqnAEqCmJ7v0ObocHhX/s2B2Gs8La4woCTQXKePy/YbRBPd+VLE5D6dQ5S+2gP5XmqRFl8j5RClGP8gzOIVgaOkM2Sbkvd/pgmj8HCDJqVQv+Ur6wQH6BqknitmtJGxxpC7alm99EVmXRg=; 25:gsAD9Dp5xTAtE9rwCuDNspK4H+W5JFyi8kGG3/mcm+O9YrsXuSWJNK80jkBHtTQIVTrUeFcyftPdEoUl7+Bp/T48Gvc9gNr3fNiLt0IJyeGVXtK9edpyXSll6g85rmJxW0Su9UW+SF8if391j8IK3hDBJ98Yw/TsDaWQyKWeXOQIQMlYMSHmcms7/4G5rAOjT3zlRgs650HY2zcKHbLpRMRcf3+aIFDui+yQbC3kydEHZjs86+klMyGZ1yfAGEb5+YVt6A9neD47rv96p9/tfg==; 20:IEmW2nZ3pww5igoyqs0IErVYJV5lLjBkqheYVrKZvKueIjk4tYRENwDwy+m26ugi1pYOlFdZ0W477RxkwKLbX/NEZPdFe9KPHZc0K+PTk6KXyOPRgmmis9pl9PPakjLS0LeUC/kqezucx8VxkdlPNuzAQvd4onhqOUziFiExV7E= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB033; BLUPR03MB033: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BLUPR03MB033; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB033; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB033; 4:eSvLnSIK2Ljetyyn3SBUrhxLgbI3E2HCKYTPJ8UxiKkV39IHPDmueCj8pF6MJJIYtaXQ9+qxy2RY/7bWhniXG4WHgLGFY98Wd7UeCsM3aNGVJNdKucSNnECGIm8b+FASSZA9eWeM0zya9hUtogxaxwNjbZD1y+34lmZt7Ek5yMGXXkbfVp/3eq8/9FTvoO+5AZGhtCCitnwscvs9jcB/YBO06B/siEMpp+f8hNh8EnKEFZojhMwVXEAeCB0bY3Ou4pCtBX+FS+UJJDmqeo8VjiH0tt4puPNxDLPaKmSP+OI= X-Forefront-PRVS: 0654257CF5 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB033; 23:jPDvxGFk3qHpvse4niAh8oS2iYSuHS3fRUxVHQcTE9Em89p5bL3NraioYD1oiu3tlQQYe3+E5qEq5qERL7HWUzCk5ATrHPKIH1EW3ULYyztYiGePi/P0RoWNYgqqDRNVxrNqeADokoL0ucCMG0Lli6pPpWnPaV8ywfCggY4lWIt4fBHIeBj6B/YgDa3cM+85VYNz4QV8EuOS/E3nkAY5Ce9mwz7HVokK5+6PVbtUel96W9OHu8cJQchtdtiHLfhmCiQkICANTv20FHB/i8h79kyt5rSstjko3+KtkVrfcCW4GkNFtnkfp/rjp6Gf4ffBsrzBp5ltUWVdWnioM3jTyRbJGW6Dhz+JaaYJyFHKLOExSoQPSzaN0RStZSjLxg2xb5wjA8eLwEHqOKIueJat9Eo0liCzDxHuN0p9svbYrrWYxxiMTyyLJqN1Izcy+5KdxdxqviYw2VfvJDMMFZCAnUp7NLO5lnbNa3GXlAkAv3Fm1btNE5Ti6vVBDmtevcMHoRUBOi5QWB9WPe4AlXgTE0hTAwTIk3CVyM9pfON0sP6sh7pxsLXsLB8O2yU1X1elyEGls5CCbaxbRatMeQTCjkHiZCtaVZKvYMBs4G/6s8isC0cOgP3wo31+M1vr+/5TI5Y4BV2Ese2UmkXpHRFZ3+e4QHJN60zMgSwa2edG0eTFGiso/8J/HD3e7fsb0TnMtKqz3YmJWHTRI2YlUtQNcWpkhrssSAHXjPAgugjNlhzj5vh6noDfdw3z14Y5+l8qEeeEv6nQRDuZohkjRpVRHwxZXAHOrf7sD6NkhOdj8lkXAn1ahpZEnpPOw0ZrDoYhxbP3Nd+Jr+g/OlChekdCGb7rpNfTgoP5D/fZ8wfULgQ+WFpkliElbKS6e3DZNJuTxDGW56m4XBK2HyevDDBt3Q== X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB033; 5:cE2fybQ/PMjui7n0HvV3C3pEk2QZy883hJM+omtX8mL81kczSoeclrG+CmaAk/ocz3U0C+u197jfUM2G0cphhsnYKSx68+27b9bZ+9Br/J1WFmsuuHt8w+9Dpo6fyqCjCdR9azeNcGrZ821CRnekTw==; 24:9oBG1bYt/PxYGyWAzS1qZ4WEFZROuvGAUO41jp8tlR0Z36BU1+eq1T7lvCwyGCvPnPRK7LUXAxqPKo6UQ03I0wxuRmodFQ1TvqylrZIV3wc=; 20:oxFKFA53enp5AZlnfw7sNgXjnp8MdTZXsVtL/O7h3+o3FO8gJr/61sGlS3LWXa3ceKhlcSVAz7OBN/A8/vxoa54cPeTQiAq8d142rsCRBE1OErAGf3+W3z/20LHHEUn7fgA9Hs7uuXwofKICYsTLs1JvIsqWXk1JuulayrkSpWU= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2015 10:15:28.3875 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a; Ip=[66.35.236.227]; Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB033 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan --- drivers/pci/host/Kconfig | 7 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c | 324 +++++++++++++++++++++++++++++++++++++ 3 files changed, 332 insertions(+) create mode 100644 drivers/pci/host/pcie-altera-msi.c diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 108500a..51d0468 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -153,4 +153,11 @@ config PCIE_ALTERA Say Y here if you want to enable PCIe controller support for Altera SoCFPGA family of SoCs. +config PCIE_ALTERA_MSI + bool "Altera PCIe MSI feature" + depends on PCI_MSI + help + Say Y here if you want PCIe MSI support for the Altera SocFPGA SoC. + This MSI driver supports Altera MSI to GIC controller IP. + endmenu diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile index 6954f76..6c4913d 100644 --- a/drivers/pci/host/Makefile +++ b/drivers/pci/host/Makefile @@ -18,3 +18,4 @@ obj-$(CONFIG_PCIE_IPROC) += pcie-iproc.o obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o +obj-$(CONFIG_PCIE_ALTERA_MSI) += pcie-altera-msi.o diff --git a/drivers/pci/host/pcie-altera-msi.c b/drivers/pci/host/pcie-altera-msi.c new file mode 100644 index 0000000..6014719 --- /dev/null +++ b/drivers/pci/host/pcie-altera-msi.c @@ -0,0 +1,324 @@ +/* + * Copyright Altera Corporation (C) 2013-2015. All rights reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see . + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MSI_STATUS 0x0 +#define MSI_ERROR 0x4 +#define MSI_INTMASK 0x8 + +#define MAX_MSI_VECTORS 32 +struct altera_msi { + DECLARE_BITMAP(used, MAX_MSI_VECTORS); + struct mutex lock; /* proctect used variable */ + struct platform_device *pdev; + struct irq_domain *msi_domain; + struct irq_domain *inner_domain; + void __iomem *csr_base; + void __iomem *vector_base; + phys_addr_t vector_phy; + u32 num_of_vectors; + int irq; +}; + +static inline void msi_writel(struct altera_msi *msi, u32 value, u32 reg) +{ + writel_relaxed(value, msi->csr_base + reg); +} + +static inline u32 msi_readl(struct altera_msi *msi, u32 reg) +{ + return readl_relaxed(msi->csr_base + reg); +} + +static void altera_msi_isr(unsigned int irq, struct irq_desc *desc) +{ + struct irq_chip *chip = irq_desc_get_chip(desc); + struct altera_msi *msi; + unsigned long status; + u32 num_of_vectors; + u32 bit; + + chained_irq_enter(chip, desc); + msi = irq_desc_get_handler_data(desc); + num_of_vectors = msi->num_of_vectors; + + do { + status = msi_readl(msi, MSI_STATUS); + if (!status) + break; + + do { + bit = find_first_bit(&status, num_of_vectors); + /* Dummy read from vector to clear the interrupt */ + readl_relaxed(msi->vector_base + (bit * sizeof(u32))); + + irq = irq_find_mapping(msi->inner_domain, bit); + if (irq) { + if (test_bit(bit, msi->used)) + generic_handle_irq(irq); + else + dev_info(&msi->pdev->dev, "unhandled MSI\n"); + } else + dev_info(&msi->pdev->dev, "unexpected MSI\n"); + + /* Clear the bit from status and repeat without reading + * again status register. */ + clear_bit(bit, &status); + } while (status); + } while (1); + + chained_irq_exit(chip, desc); +} + +static struct irq_chip altera_msi_irq_chip = { + .name = "Altera PCIe MSI", + .irq_enable = pci_msi_unmask_irq, + .irq_disable = pci_msi_mask_irq, + .irq_mask = pci_msi_mask_irq, + .irq_unmask = pci_msi_unmask_irq, +}; + +static struct msi_domain_info altera_msi_domain_info = { + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | + MSI_FLAG_PCI_MSIX), + .chip = &altera_msi_irq_chip, +}; + +static void altera_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) +{ + u32 mask; + struct altera_msi *msi = irq_data_get_irq_chip_data(data); + u64 addr = msi->vector_phy + (data->hwirq * sizeof(u32)); + + msg->address_lo = lower_32_bits(addr); + msg->address_hi = upper_32_bits(addr); + msg->data = data->hwirq; + + mask = msi_readl(msi, MSI_INTMASK); + mask |= 1 << data->hwirq; + msi_writel(msi, mask, MSI_INTMASK); + dev_dbg(&msi->pdev->dev, "msi#%d address_lo 0x%x\n", (int)data->hwirq, + msg->address_lo); +} + +static int altera_msi_set_affinity(struct irq_data *irq_data, + const struct cpumask *mask, bool force) +{ + return -EINVAL; +} + +static struct irq_chip altera_msi_bottom_irq_chip = { + .name = "Altera MSI", + .irq_compose_msi_msg = altera_compose_msi_msg, + .irq_set_affinity = altera_msi_set_affinity, +}; + +static int altera_irq_domain_alloc(struct irq_domain *domain, unsigned int virq, + unsigned int nr_irqs, void *args) +{ + struct altera_msi *msi = domain->host_data; + int bit; + + mutex_lock(&msi->lock); + + bit = find_first_zero_bit(msi->used, msi->num_of_vectors); + if (bit < msi->num_of_vectors) + set_bit(bit, msi->used); + + mutex_unlock(&msi->lock); + + if (bit < 0) + return bit; + else if (bit >= msi->num_of_vectors) + return -ENOSPC; + + irq_domain_set_info(domain, virq, bit, &altera_msi_bottom_irq_chip, + domain->host_data, handle_simple_irq, + NULL, NULL); + set_irq_flags(virq, IRQF_VALID); + + return 0; +} + +static void altera_irq_domain_free(struct irq_domain *domain, + unsigned int virq, unsigned int nr_irqs) +{ + struct irq_data *d = irq_domain_get_irq_data(domain, virq); + struct altera_msi *msi = irq_data_get_irq_chip_data(d); + u32 mask; + + mutex_lock(&msi->lock); + + if (!test_bit(d->hwirq, msi->used)) + dev_err(&msi->pdev->dev, "trying to free unused MSI#%lu\n", + d->hwirq); + else { + clear_bit(d->hwirq, msi->used); + mask = msi_readl(msi, MSI_INTMASK); + mask &= ~(1 << d->hwirq); + msi_writel(msi, mask, MSI_INTMASK); + } + + mutex_unlock(&msi->lock); +} + +static const struct irq_domain_ops msi_domain_ops = { + .alloc = altera_irq_domain_alloc, + .free = altera_irq_domain_free, +}; + +static int altera_allocate_domains(struct altera_msi *msi) +{ + msi->inner_domain = irq_domain_add_linear(NULL, msi->num_of_vectors, + &msi_domain_ops, msi); + if (!msi->inner_domain) { + dev_err(&msi->pdev->dev, "failed to create IRQ domain\n"); + return -ENOMEM; + } + + msi->msi_domain = pci_msi_create_irq_domain( + msi->pdev->dev.of_node, + &altera_msi_domain_info, msi->inner_domain); + if (!msi->msi_domain) { + dev_err(&msi->pdev->dev, "failed to create MSI domain\n"); + irq_domain_remove(msi->inner_domain); + return -ENOMEM; + } + + return 0; +} + +static void altera_free_domains(struct altera_msi *msi) +{ + irq_domain_remove(msi->msi_domain); + irq_domain_remove(msi->inner_domain); +} + + +static int altera_msi_remove(struct platform_device *pdev) +{ + struct altera_msi *msi = platform_get_drvdata(pdev); + + msi_writel(msi, 0, MSI_INTMASK); + irq_set_chained_handler(msi->irq, NULL); + irq_set_handler_data(msi->irq, NULL); + + altera_free_domains(msi); + + platform_set_drvdata(pdev, NULL); + return 0; +} + +int altera_msi_probe(struct platform_device *pdev) +{ + struct altera_msi *msi; + struct device_node *np = pdev->dev.of_node; + struct resource *res; + int ret; + + msi = devm_kzalloc(&pdev->dev, sizeof(struct altera_msi), + GFP_KERNEL); + if (!msi) + return -ENOMEM; + + mutex_init(&msi->lock); + msi->pdev = pdev; + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr"); + msi->csr_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->csr_base)) { + dev_err(&pdev->dev, "get csr resource failed\n"); + return PTR_ERR(msi->csr_base); + } + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, + "vector_slave"); + msi->vector_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->vector_base)) { + dev_err(&pdev->dev, "get vector slave resource failed\n"); + return PTR_ERR(msi->vector_base); + } + + msi->vector_phy = res->start; + + if (of_property_read_u32(np, "num-vectors", &msi->num_of_vectors)) { + dev_err(&pdev->dev, "failed to parse the number of vectors\n"); + return -EINVAL; + } + + ret = altera_allocate_domains(msi); + if (ret) + return ret; + + msi->irq = platform_get_irq(pdev, 0); + if (msi->irq <= 0) { + dev_err(&pdev->dev, "failed to map IRQ: %d\n", msi->irq); + ret = -ENODEV; + goto err; + } + + irq_set_chained_handler(msi->irq, altera_msi_isr); + ret = irq_set_handler_data(msi->irq, msi); + if (ret) { + dev_err(&pdev->dev, "failed to register IRQ handler: %d\n", + ret); + goto err; + } + + platform_set_drvdata(pdev, msi); + + return 0; + +err: + altera_msi_remove(pdev); + return ret; +} + +static const struct of_device_id altera_msi_of_match[] = { + { .compatible = "altr,msi-1.0", NULL }, + { }, +}; +MODULE_DEVICE_TABLE(of, altera_msi_of_match); + +static struct platform_driver altera_msi_driver = { + .driver = { + .name = "altera-msi", + .owner = THIS_MODULE, + .of_match_table = altera_msi_of_match, + }, + .probe = altera_msi_probe, + .remove = altera_msi_remove, +}; + +static int __init altera_msi_init(void) +{ + return platform_driver_register(&altera_msi_driver); +} + +subsys_initcall(altera_msi_init); + +MODULE_AUTHOR("Ley Foon Tan "); +MODULE_DESCRIPTION("Altera PCIe MSI support"); +MODULE_LICENSE("GPL v2");