From patchwork Fri Sep 11 12:08:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 7160381 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 03AC39F314 for ; Fri, 11 Sep 2015 12:09:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 189E1207E8 for ; Fri, 11 Sep 2015 12:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44D4A207C1 for ; Fri, 11 Sep 2015 12:09:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbbIKMJJ (ORCPT ); Fri, 11 Sep 2015 08:09:09 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:35699 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835AbbIKMJI (ORCPT ); Fri, 11 Sep 2015 08:09:08 -0400 Received: by ykdu9 with SMTP id u9so89215654ykd.2 for ; Fri, 11 Sep 2015 05:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=vGwpkRW/deRWlAeMOoDJnyHVywku81BpjtriGOvVuW4=; b=mRDpfk6pznSGosg3qT2niPEvcLaYyQq3WYiN3Vsj+vjU9GAW9aF/EOduJMhfY8S7j+ 52f1SsJpccupLpDeyBKiAeK/ajChVTa7OuvcuPm0o51G7XwTEgMyoBacUy//pq1RQlRh x5kSVsf/zBfSTTmqvqbc3SDuWoM3jcfOp1aL8SP1sUUCU/Z8+luei7tXvX9HqAmVhkhw eFvZgHrYa6ZXEiEvAnmXt362t5LbZlC8C2dLQAY0ncWZJFH6xIwDMFwKDE2GuO+pjyDW Cp8+ATwp3lQ5D3tvgMHx24ou6ESuOhJravUc3ZHZAacHufrK41y7uARrqtGAdQ6uZJMv A6xQ== X-Received: by 10.13.213.21 with SMTP id x21mr5522325ywd.51.1441973347803; Fri, 11 Sep 2015 05:09:07 -0700 (PDT) Received: from localhost.localdomain ([179.159.191.85]) by smtp.gmail.com with ESMTPSA id d204sm12818ywe.56.2015.09.11.05.09.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 11 Sep 2015 05:09:07 -0700 (PDT) From: Fabio Estevam To: bhelgaas@google.com Cc: l.stach@pengutronix.de, linux-pci@vger.kernel.org, Fabio Estevam Subject: [PATCH v2 1/2] PCI: imx6: Return the real error code Date: Fri, 11 Sep 2015 09:08:52 -0300 Message-Id: <1441973333-3346-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam When devm_request_irq() fails we should better return the real error code instead of returning a 'fake' one. Signed-off-by: Fabio Estevam Reviewed-by: Lucas Stach --- Changes since v1: - None drivers/pci/host/pci-imx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index 8f3a981..2d0d0fe 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -539,7 +539,7 @@ static int __init imx6_add_pcie_port(struct pcie_port *pp, IRQF_SHARED, "mx6-pcie-msi", pp); if (ret) { dev_err(&pdev->dev, "failed to request MSI irq\n"); - return -ENODEV; + return ret; } }