Message ID | 1444297394-3122-4-git-send-email-lftan@altera.com (mailing list archive) |
---|---|
State | New, archived |
Delegated to: | Bjorn Helgaas |
Headers | show |
On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > + int where, int size, u32 value) > +{ > + struct altera_pcie *pcie = bus->sysdata; > + u32 data32; > + u32 shift = 8 * (where & 3); > + int ret; > + > + if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) > + return PCIBIOS_DEVICE_NOT_FOUND; > + > + /* write partial */ > + if (size != sizeof(u32)) { > + ret = tlp_cfg_dword_read(pcie, bus->number, devfn, > + where & ~DWORD_MASK, &data32); > + if (ret) > + return ret; > + } > + > + switch (size) { > + case 1: > + data32 = (data32 & ~(0xff << shift)) | > + ((value & 0xff) << shift); > + break; > + case 2: > + data32 = (data32 & ~(0xffff << shift)) | > + ((value & 0xffff) << shift); > + break; > + default: > + data32 = value; Can you generate proper 1, 2 and 4 byte configuration accesses? That is much preferred over the above read-modify-write, as there are registers in PCI and PCIe that are read/write-1-to-clear. The above has the effect of inadvertently clearing those RW1C bits.
On Thu, Oct 8, 2015 at 5:47 PM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > > On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > > + int where, int size, u32 value) > > +{ > > + struct altera_pcie *pcie = bus->sysdata; > > + u32 data32; > > + u32 shift = 8 * (where & 3); > > + int ret; > > + > > + if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) > > + return PCIBIOS_DEVICE_NOT_FOUND; > > + > > + /* write partial */ > > + if (size != sizeof(u32)) { > > + ret = tlp_cfg_dword_read(pcie, bus->number, devfn, > > + where & ~DWORD_MASK, &data32); > > + if (ret) > > + return ret; > > + } > > + > > + switch (size) { > > + case 1: > > + data32 = (data32 & ~(0xff << shift)) | > > + ((value & 0xff) << shift); > > + break; > > + case 2: > > + data32 = (data32 & ~(0xffff << shift)) | > > + ((value & 0xffff) << shift); > > + break; > > + default: > > + data32 = value; > > Can you generate proper 1, 2 and 4 byte configuration accesses? That > is much preferred over the above read-modify-write, as there are > registers in PCI and PCIe that are read/write-1-to-clear. The above > has the effect of inadvertently clearing those RW1C bits. No, hardware can only access 4-byte aligned address. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ley, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-allmodconfig (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): drivers/pci/host/pcie-altera.c: In function 'tlp_cfg_dword_read': >> drivers/pci/host/pcie-altera.c:243:12: warning: large integer implicitly truncated to unsigned type [-Woverflow] *value = ~0UL; /* return 0xFFFFFFFF if error */ ^ drivers/pci/host/pcie-altera.c: In function 'altera_pcie_cfg_read': drivers/pci/host/pcie-altera.c:291:12: warning: large integer implicitly truncated to unsigned type [-Woverflow] *value = ~0UL; ^ vim +243 drivers/pci/host/pcie-altera.c 227 int ret; 228 u32 headers[TLP_HDR_SIZE]; 229 230 if (bus == pcie->root_bus_nr) 231 headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGRD0); 232 else 233 headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGRD1); 234 235 headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, devfn), 236 TLP_READ_TAG); 237 headers[2] = TLP_CFG_DW2(bus, devfn, where); 238 239 tlp_write_packet(pcie, headers, 0, false); 240 241 ret = tlp_read_packet(pcie, value); 242 if (ret != PCIBIOS_SUCCESSFUL) > 243 *value = ~0UL; /* return 0xFFFFFFFF if error */ 244 245 return ret; 246 } 247 248 static int tlp_cfg_dword_write(struct altera_pcie *pcie, u8 bus, u32 devfn, 249 int where, u32 value) 250 { 251 u32 headers[TLP_HDR_SIZE]; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Ley, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: sparc-allmodconfig (attached as .config) reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc All errors (new ones prefixed by >>): drivers/pci/host/pcie-altera.c: In function 'tlp_cfg_dword_read': drivers/pci/host/pcie-altera.c:243:12: warning: large integer implicitly truncated to unsigned type [-Woverflow] *value = ~0UL; /* return 0xFFFFFFFF if error */ ^ drivers/pci/host/pcie-altera.c: In function 'altera_pcie_cfg_read': drivers/pci/host/pcie-altera.c:291:12: warning: large integer implicitly truncated to unsigned type [-Woverflow] *value = ~0UL; ^ drivers/pci/host/pcie-altera.c: In function 'altera_pcie_parse_request_of_pci_ranges': >> drivers/pci/host/pcie-altera.c:410:2: error: implicit declaration of function 'of_pci_get_host_bridge_resources' [-Werror=implicit-function-declaration] err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources, ^ cc1: some warnings being treated as errors vim +/of_pci_get_host_bridge_resources +410 drivers/pci/host/pcie-altera.c 237 headers[2] = TLP_CFG_DW2(bus, devfn, where); 238 239 tlp_write_packet(pcie, headers, 0, false); 240 241 ret = tlp_read_packet(pcie, value); 242 if (ret != PCIBIOS_SUCCESSFUL) > 243 *value = ~0UL; /* return 0xFFFFFFFF if error */ 244 245 return ret; 246 } 247 248 static int tlp_cfg_dword_write(struct altera_pcie *pcie, u8 bus, u32 devfn, 249 int where, u32 value) 250 { 251 u32 headers[TLP_HDR_SIZE]; 252 int ret; 253 254 if (bus == pcie->root_bus_nr) 255 headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGWR0); 256 else 257 headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGWR1); 258 259 headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, devfn), 260 TLP_WRITE_TAG); 261 headers[2] = TLP_CFG_DW2(bus, devfn, where); 262 263 /* check alignment to Qword */ 264 if ((where & 0x7) == 0) 265 tlp_write_packet(pcie, headers, value, true); 266 else 267 tlp_write_packet(pcie, headers, value, false); 268 269 ret = tlp_read_packet(pcie, NULL); 270 if (ret != PCIBIOS_SUCCESSFUL) 271 return ret; 272 273 /* 274 * Monitoring changes to PCI_PRIMARY_BUS register on root port and update 275 * local copy of root bus number accordingly. 276 */ 277 if ((bus == pcie->root_bus_nr) && (where == PCI_PRIMARY_BUS)) 278 pcie->root_bus_nr = (u8)(value); 279 280 return PCIBIOS_SUCCESSFUL; 281 } 282 283 static int altera_pcie_cfg_read(struct pci_bus *bus, unsigned int devfn, 284 int where, int size, u32 *value) 285 { 286 struct altera_pcie *pcie = bus->sysdata; 287 int ret; 288 u32 data; 289 290 if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) { 291 *value = ~0UL; 292 return PCIBIOS_DEVICE_NOT_FOUND; 293 } 294 295 ret = tlp_cfg_dword_read(pcie, bus->number, devfn, 296 (where & ~DWORD_MASK), &data); 297 if (ret != PCIBIOS_SUCCESSFUL) 298 return ret; 299 300 switch (size) { 301 case 1: 302 *value = (data >> (8 * (where & 0x3))) & 0xff; 303 break; 304 case 2: 305 *value = (data >> (8 * (where & 0x2))) & 0xffff; 306 break; 307 default: 308 *value = data; 309 break; 310 } 311 312 return PCIBIOS_SUCCESSFUL; 313 } 314 315 static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, 316 int where, int size, u32 value) 317 { 318 struct altera_pcie *pcie = bus->sysdata; 319 u32 data32; 320 u32 shift = 8 * (where & 3); 321 int ret; 322 323 if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) 324 return PCIBIOS_DEVICE_NOT_FOUND; 325 326 /* write partial */ 327 if (size != sizeof(u32)) { 328 ret = tlp_cfg_dword_read(pcie, bus->number, devfn, 329 where & ~DWORD_MASK, &data32); 330 if (ret) 331 return ret; 332 } 333 334 switch (size) { 335 case 1: 336 data32 = (data32 & ~(0xff << shift)) | 337 ((value & 0xff) << shift); 338 break; 339 case 2: 340 data32 = (data32 & ~(0xffff << shift)) | 341 ((value & 0xffff) << shift); 342 break; 343 default: 344 data32 = value; 345 break; 346 } 347 348 return tlp_cfg_dword_write(pcie, bus->number, devfn, 349 (where & ~DWORD_MASK), data32); 350 } 351 352 static struct pci_ops altera_pcie_ops = { 353 .read = altera_pcie_cfg_read, 354 .write = altera_pcie_cfg_write, 355 }; 356 357 static int altera_pcie_intx_map(struct irq_domain *domain, unsigned int irq, 358 irq_hw_number_t hwirq) 359 { 360 irq_set_chip_and_handler(irq, &dummy_irq_chip, handle_simple_irq); 361 irq_set_chip_data(irq, domain->host_data); 362 363 return 0; 364 } 365 366 static const struct irq_domain_ops intx_domain_ops = { 367 .map = altera_pcie_intx_map, 368 }; 369 370 static void altera_pcie_isr(struct irq_desc *desc) 371 { 372 struct irq_chip *chip = irq_desc_get_chip(desc); 373 struct altera_pcie *pcie; 374 unsigned long status; 375 u32 bit; 376 u32 virq; 377 378 chained_irq_enter(chip, desc); 379 pcie = irq_desc_get_handler_data(desc); 380 381 while ((status = cra_readl(pcie, P2A_INT_STATUS) 382 & P2A_INT_STS_ALL) != 0) { 383 for_each_set_bit(bit, &status, INTX_NUM) { 384 /* clear interrupts */ 385 cra_writel(pcie, 1 << bit, P2A_INT_STATUS); 386 387 virq = irq_find_mapping(pcie->irq_domain, bit + 1); 388 if (virq) 389 generic_handle_irq(virq); 390 else 391 dev_err(&pcie->pdev->dev, "unexpected IRQ\n"); 392 } 393 } 394 395 chained_irq_exit(chip, desc); 396 } 397 398 static void altera_pcie_release_of_pci_ranges(struct altera_pcie *pcie) 399 { 400 pci_free_resource_list(&pcie->resources); 401 } 402 403 static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie) 404 { 405 int err, res_valid = 0; 406 struct device *dev = &pcie->pdev->dev; 407 struct device_node *np = dev->of_node; 408 struct resource_entry *win; 409 > 410 err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources, 411 NULL); 412 if (err) 413 return err; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Thu, Oct 08, 2015 at 06:03:24PM +0800, Ley Foon Tan wrote: > On Thu, Oct 8, 2015 at 5:47 PM, Russell King - ARM Linux > <linux@arm.linux.org.uk> wrote: > > > > On Thu, Oct 08, 2015 at 05:43:11PM +0800, Ley Foon Tan wrote: > > > +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, > > > + int where, int size, u32 value) > > > +{ > > > + struct altera_pcie *pcie = bus->sysdata; > > > + u32 data32; > > > + u32 shift = 8 * (where & 3); > > > + int ret; > > > + > > > + if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) > > > + return PCIBIOS_DEVICE_NOT_FOUND; > > > + > > > + /* write partial */ > > > + if (size != sizeof(u32)) { > > > + ret = tlp_cfg_dword_read(pcie, bus->number, devfn, > > > + where & ~DWORD_MASK, &data32); > > > + if (ret) > > > + return ret; > > > + } > > > + > > > + switch (size) { > > > + case 1: > > > + data32 = (data32 & ~(0xff << shift)) | > > > + ((value & 0xff) << shift); > > > + break; > > > + case 2: > > > + data32 = (data32 & ~(0xffff << shift)) | > > > + ((value & 0xffff) << shift); > > > + break; > > > + default: > > > + data32 = value; > > > > Can you generate proper 1, 2 and 4 byte configuration accesses? That > > is much preferred over the above read-modify-write, as there are > > registers in PCI and PCIe that are read/write-1-to-clear. The above > > has the effect of inadvertently clearing those RW1C bits. > No, hardware can only access 4-byte aligned address. This is non-spec compliant, and we really should have some way of flagging that because it may break things in ways that would be very difficult to debug, e.g., we can lose RW1C status bits when writing an adjacent register, so they would just silently disappear. I don't know if this should be a kernel taint, a simple warning in dmesg, or what. I guess the tainting mechanism is probably too general-purpose for this, and add_taint() doesn't give any dmesg indication. We wouldn't see the taint unless the problem actually caused an oops or panic. In this case, I think I want a clue in dmesg so we have a chance of seeing it even if there is no oops. So probably something like a dev_warn("non-compliant config accesses") would work. You really should double-check with the hardware guys, because it's pretty obvious that the PCI spec requires 1- and 2-byte config accesses to work correctly. For example, if you read/modify/write to update PCI_COMMAND, you will inadvertently clear the RW1C bits in PCI_STATUS. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 09 October 2015 18:15:40 Bjorn Helgaas wrote: > > I don't know if this should be a kernel taint, a simple warning in > dmesg, or what. I guess the tainting mechanism is probably too > general-purpose for this, and add_taint() doesn't give any dmesg > indication. We wouldn't see the taint unless the problem actually > caused an oops or panic. In this case, I think I want a clue in dmesg > so we have a chance of seeing it even if there is no oops. So > probably something like a dev_warn("non-compliant config accesses") > would work. > > You really should double-check with the hardware guys, because it's > pretty obvious that the PCI spec requires 1- and 2-byte config > accesses to work correctly. For example, if you read/modify/write to > update PCI_COMMAND, you will inadvertently clear the RW1C bits in > PCI_STATUS. Would it help to require a DT property here that flags the device as having a broken config space? Then we could implement both in the driver, and only use the RMW based implementation if the firmware describes the device as "altera,broken-pci-config-space". Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Oct 12, 2015 at 8:03 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > On Friday 09 October 2015 18:15:40 Bjorn Helgaas wrote: > > > > I don't know if this should be a kernel taint, a simple warning in > > dmesg, or what. I guess the tainting mechanism is probably too > > general-purpose for this, and add_taint() doesn't give any dmesg > > indication. We wouldn't see the taint unless the problem actually > > caused an oops or panic. In this case, I think I want a clue in dmesg > > so we have a chance of seeing it even if there is no oops. So > > probably something like a dev_warn("non-compliant config accesses") > > would work. > > > > You really should double-check with the hardware guys, because it's > > pretty obvious that the PCI spec requires 1- and 2-byte config > > accesses to work correctly. For example, if you read/modify/write to > > update PCI_COMMAND, you will inadvertently clear the RW1C bits in > > PCI_STATUS. > > Would it help to require a DT property here that flags the device > as having a broken config space? > > Then we could implement both in the driver, and only use the > RMW based implementation if the firmware describes the device > as "altera,broken-pci-config-space". > I have checked the PCI/TLP specification, the address needs to be 4-byte aligned. But, we can use "byte enable" field to update specific bytes. For example, if byte enable is 0x3 (0011b), that mean it only update lower 2 bytes. By doing this, we can resolve the RW1C issue here. I will update the driver with this in next revision. Thanks for reviewing. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index d5e58ba..08f2543 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -145,4 +145,11 @@ config PCIE_IPROC_BCMA Say Y here if you want to use the Broadcom iProc PCIe controller through the BCMA bus interface +config PCIE_ALTERA + bool "Altera PCIe controller" + select PCI_DOMAINS + help + Say Y here if you want to enable PCIe controller support for Altera + SoCFPGA family of SoCs. + endmenu diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile index 140d66f..6954f76 100644 --- a/drivers/pci/host/Makefile +++ b/drivers/pci/host/Makefile @@ -17,3 +17,4 @@ obj-$(CONFIG_PCI_VERSATILE) += pci-versatile.o obj-$(CONFIG_PCIE_IPROC) += pcie-iproc.o obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o +obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c new file mode 100644 index 0000000..8554ff9 --- /dev/null +++ b/drivers/pci/host/pcie-altera.c @@ -0,0 +1,588 @@ +/* + * Copyright Altera Corporation (C) 2013-2015. All rights reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see <http://www.gnu.org/licenses/>. + */ +#include <linux/delay.h> +#include <linux/interrupt.h> +#include <linux/irqchip/chained_irq.h> +#include <linux/module.h> +#include <linux/of_address.h> +#include <linux/of_irq.h> +#include <linux/of_pci.h> +#include <linux/pci.h> +#include <linux/platform_device.h> +#include <linux/slab.h> + +#define A2P_ADDR_MAP_LO0 0x1000 +#define A2P_ADDR_MAP_HI0 0x1004 +#define RP_TX_REG0 0x2000 +#define RP_TX_REG1 0x2004 +#define RP_TX_CNTRL 0x2008 +#define RP_TX_EOP 0x2 +#define RP_TX_SOP 0x1 +#define RP_RXCPL_STATUS 0x2010 +#define RP_RXCPL_EOP 0x2 +#define RP_RXCPL_SOP 0x1 +#define RP_RXCPL_REG0 0x2014 +#define RP_RXCPL_REG1 0x2018 +#define P2A_INT_STATUS 0x3060 +#define P2A_INT_STS_ALL 0xF +#define P2A_INT_ENABLE 0x3070 +#define P2A_INT_ENA_ALL 0xF +#define RP_LTSSM 0x3C64 +#define LTSSM_L0 0xF + +/* TLP configuration type 0 and 1 */ +#define TLP_FMTTYPE_CFGRD0 0x04 /* Configuration Read Type 0 */ +#define TLP_FMTTYPE_CFGWR0 0x44 /* Configuration Write Type 0 */ +#define TLP_FMTTYPE_CFGRD1 0x05 /* Configuration Read Type 1 */ +#define TLP_FMTTYPE_CFGWR1 0x45 /* Configuration Write Type 1 */ +#define TLP_PAYLOAD_SIZE 0x01 +#define TLP_READ_TAG 0x1D +#define TLP_WRITE_TAG 0x10 +#define TLP_CFG_DW0(fmttype) (((fmttype) << 24) | TLP_PAYLOAD_SIZE) +#define TLP_CFG_DW1(reqid, tag) (((reqid) << 16) | (tag << 8) | 0xF) +#define TLP_CFG_DW2(bus, devfn, offset) \ + (((bus) << 24) | ((devfn) << 16) | (offset)) +#define TLP_REQ_ID(bus, devfn) (((bus) << 8) | (devfn)) +#define TLP_COMPL_STATUS(hdr) (((hdr) & 0xE0) >> 13) +#define TLP_HDR_SIZE 3 +#define TLP_LOOP 500 + +#define INTX_NUM 4 + +#define DWORD_MASK 3 + +struct altera_pcie { + struct platform_device *pdev; + void __iomem *cra_base; + int irq; + u8 root_bus_nr; + struct irq_domain *irq_domain; + struct resource bus_range; + struct list_head resources; +}; + +struct tlp_rp_regpair_t { + u32 ctrl; + u32 reg0; + u32 reg1; +}; + +static void altera_pcie_retrain(struct pci_dev *dev) +{ + u16 linkcap, linkstat; + + /* + * Set the retrain bit if the PCIe rootport support > 2.5GB/s, but + * current speed is 2.5 GB/s. + */ + pcie_capability_read_word(dev, PCI_EXP_LNKCAP, &linkcap); + + if ((linkcap & PCI_EXP_LNKCAP_SLS) <= PCI_EXP_LNKCAP_SLS_2_5GB) + return; + + pcie_capability_read_word(dev, PCI_EXP_LNKSTA, &linkstat); + if ((linkstat & PCI_EXP_LNKSTA_CLS) == PCI_EXP_LNKSTA_CLS_2_5GB) + pcie_capability_set_word(dev, PCI_EXP_LNKCTL, + PCI_EXP_LNKCTL_RL); +} +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_ALTERA, PCI_ANY_ID, altera_pcie_retrain); + +static void altera_pcie_fixup_res(struct pci_dev *dev) +{ + /* + * Prevent enumeration of root port. + */ + if (!dev->bus->parent && dev->devfn == 0) { + int i; + + for (i = 0; i < PCI_NUM_RESOURCES; i++) { + dev->resource[i].start = 0; + dev->resource[i].end = 0; + dev->resource[i].flags = 0; + } + } +} +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ALTERA, PCI_ANY_ID, + altera_pcie_fixup_res); + +static inline void cra_writel(struct altera_pcie *pcie, u32 value, u32 reg) +{ + writel_relaxed(value, pcie->cra_base + reg); +} + +static inline u32 cra_readl(struct altera_pcie *pcie, u32 reg) +{ + return readl_relaxed(pcie->cra_base + reg); +} + +static void tlp_read_rx(struct altera_pcie *pcie, + struct tlp_rp_regpair_t *tlp_rp_regdata) +{ + tlp_rp_regdata->ctrl = cra_readl(pcie, RP_RXCPL_STATUS); + tlp_rp_regdata->reg0 = cra_readl(pcie, RP_RXCPL_REG0); + tlp_rp_regdata->reg1 = cra_readl(pcie, RP_RXCPL_REG1); +} + +static void tlp_write_tx(struct altera_pcie *pcie, + struct tlp_rp_regpair_t *tlp_rp_regdata) +{ + cra_writel(pcie, tlp_rp_regdata->reg0, RP_TX_REG0); + cra_writel(pcie, tlp_rp_regdata->reg1, RP_TX_REG1); + cra_writel(pcie, tlp_rp_regdata->ctrl, RP_TX_CNTRL); +} + +static bool altera_pcie_link_is_up(struct altera_pcie *pcie) +{ + return !!(cra_readl(pcie, RP_LTSSM) & LTSSM_L0); +} + +static bool altera_pcie_valid_config(struct altera_pcie *pcie, + struct pci_bus *bus, int dev) +{ + /* If there is no link, then there is no device */ + if (bus->number != pcie->root_bus_nr) { + if (!altera_pcie_link_is_up(pcie)) + return false; + } + + /* access only one slot on each root port */ + if (bus->number == pcie->root_bus_nr && dev > 0) + return false; + + /* + * Do not read more than one device on the bus directly attached + * to root port, root port can only attach to one downstream port. + */ + if (bus->primary == pcie->root_bus_nr && dev > 0) + return false; + + return true; +} + +static int tlp_read_packet(struct altera_pcie *pcie, u32 *value) +{ + u8 loop; + struct tlp_rp_regpair_t tlp_rp_regdata; + + /* + * Minimum 2 loops to read TLP headers and 1 loop to read data + * payload. + */ + for (loop = 0; loop < TLP_LOOP; loop++) { + tlp_read_rx(pcie, &tlp_rp_regdata); + if (tlp_rp_regdata.ctrl & RP_RXCPL_EOP) { + if (value) + *value = tlp_rp_regdata.reg0; + return PCIBIOS_SUCCESSFUL; + } + udelay(5); + } + + return -ENOENT; +} + +static void tlp_write_packet(struct altera_pcie *pcie, u32 *headers, + u32 data, bool align) +{ + struct tlp_rp_regpair_t tlp_rp_regdata; + + tlp_rp_regdata.reg0 = headers[0]; + tlp_rp_regdata.reg1 = headers[1]; + tlp_rp_regdata.ctrl = RP_TX_SOP; + tlp_write_tx(pcie, &tlp_rp_regdata); + + if (align) { + tlp_rp_regdata.reg0 = headers[2]; + tlp_rp_regdata.reg1 = 0; + tlp_rp_regdata.ctrl = 0; + tlp_write_tx(pcie, &tlp_rp_regdata); + + tlp_rp_regdata.reg0 = data; + tlp_rp_regdata.reg1 = 0; + } else { + tlp_rp_regdata.reg0 = headers[2]; + tlp_rp_regdata.reg1 = data; + } + + tlp_rp_regdata.ctrl = RP_TX_EOP; + tlp_write_tx(pcie, &tlp_rp_regdata); +} + +static int tlp_cfg_dword_read(struct altera_pcie *pcie, u8 bus, u32 devfn, + int where, u32 *value) +{ + int ret; + u32 headers[TLP_HDR_SIZE]; + + if (bus == pcie->root_bus_nr) + headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGRD0); + else + headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGRD1); + + headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, devfn), + TLP_READ_TAG); + headers[2] = TLP_CFG_DW2(bus, devfn, where); + + tlp_write_packet(pcie, headers, 0, false); + + ret = tlp_read_packet(pcie, value); + if (ret != PCIBIOS_SUCCESSFUL) + *value = ~0UL; /* return 0xFFFFFFFF if error */ + + return ret; +} + +static int tlp_cfg_dword_write(struct altera_pcie *pcie, u8 bus, u32 devfn, + int where, u32 value) +{ + u32 headers[TLP_HDR_SIZE]; + int ret; + + if (bus == pcie->root_bus_nr) + headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGWR0); + else + headers[0] = TLP_CFG_DW0(TLP_FMTTYPE_CFGWR1); + + headers[1] = TLP_CFG_DW1(TLP_REQ_ID(pcie->root_bus_nr, devfn), + TLP_WRITE_TAG); + headers[2] = TLP_CFG_DW2(bus, devfn, where); + + /* check alignment to Qword */ + if ((where & 0x7) == 0) + tlp_write_packet(pcie, headers, value, true); + else + tlp_write_packet(pcie, headers, value, false); + + ret = tlp_read_packet(pcie, NULL); + if (ret != PCIBIOS_SUCCESSFUL) + return ret; + + /* + * Monitoring changes to PCI_PRIMARY_BUS register on root port and update + * local copy of root bus number accordingly. + */ + if ((bus == pcie->root_bus_nr) && (where == PCI_PRIMARY_BUS)) + pcie->root_bus_nr = (u8)(value); + + return PCIBIOS_SUCCESSFUL; +} + +static int altera_pcie_cfg_read(struct pci_bus *bus, unsigned int devfn, + int where, int size, u32 *value) +{ + struct altera_pcie *pcie = bus->sysdata; + int ret; + u32 data; + + if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) { + *value = ~0UL; + return PCIBIOS_DEVICE_NOT_FOUND; + } + + ret = tlp_cfg_dword_read(pcie, bus->number, devfn, + (where & ~DWORD_MASK), &data); + if (ret != PCIBIOS_SUCCESSFUL) + return ret; + + switch (size) { + case 1: + *value = (data >> (8 * (where & 0x3))) & 0xff; + break; + case 2: + *value = (data >> (8 * (where & 0x2))) & 0xffff; + break; + default: + *value = data; + break; + } + + return PCIBIOS_SUCCESSFUL; +} + +static int altera_pcie_cfg_write(struct pci_bus *bus, unsigned int devfn, + int where, int size, u32 value) +{ + struct altera_pcie *pcie = bus->sysdata; + u32 data32; + u32 shift = 8 * (where & 3); + int ret; + + if (!altera_pcie_valid_config(pcie, bus, PCI_SLOT(devfn))) + return PCIBIOS_DEVICE_NOT_FOUND; + + /* write partial */ + if (size != sizeof(u32)) { + ret = tlp_cfg_dword_read(pcie, bus->number, devfn, + where & ~DWORD_MASK, &data32); + if (ret) + return ret; + } + + switch (size) { + case 1: + data32 = (data32 & ~(0xff << shift)) | + ((value & 0xff) << shift); + break; + case 2: + data32 = (data32 & ~(0xffff << shift)) | + ((value & 0xffff) << shift); + break; + default: + data32 = value; + break; + } + + return tlp_cfg_dword_write(pcie, bus->number, devfn, + (where & ~DWORD_MASK), data32); +} + +static struct pci_ops altera_pcie_ops = { + .read = altera_pcie_cfg_read, + .write = altera_pcie_cfg_write, +}; + +static int altera_pcie_intx_map(struct irq_domain *domain, unsigned int irq, + irq_hw_number_t hwirq) +{ + irq_set_chip_and_handler(irq, &dummy_irq_chip, handle_simple_irq); + irq_set_chip_data(irq, domain->host_data); + + return 0; +} + +static const struct irq_domain_ops intx_domain_ops = { + .map = altera_pcie_intx_map, +}; + +static void altera_pcie_isr(struct irq_desc *desc) +{ + struct irq_chip *chip = irq_desc_get_chip(desc); + struct altera_pcie *pcie; + unsigned long status; + u32 bit; + u32 virq; + + chained_irq_enter(chip, desc); + pcie = irq_desc_get_handler_data(desc); + + while ((status = cra_readl(pcie, P2A_INT_STATUS) + & P2A_INT_STS_ALL) != 0) { + for_each_set_bit(bit, &status, INTX_NUM) { + /* clear interrupts */ + cra_writel(pcie, 1 << bit, P2A_INT_STATUS); + + virq = irq_find_mapping(pcie->irq_domain, bit + 1); + if (virq) + generic_handle_irq(virq); + else + dev_err(&pcie->pdev->dev, "unexpected IRQ\n"); + } + } + + chained_irq_exit(chip, desc); +} + +static void altera_pcie_release_of_pci_ranges(struct altera_pcie *pcie) +{ + pci_free_resource_list(&pcie->resources); +} + +static int altera_pcie_parse_request_of_pci_ranges(struct altera_pcie *pcie) +{ + int err, res_valid = 0; + struct device *dev = &pcie->pdev->dev; + struct device_node *np = dev->of_node; + struct resource_entry *win; + + err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pcie->resources, + NULL); + if (err) + return err; + + resource_list_for_each_entry(win, &pcie->resources) { + struct resource *parent, *res = win->res; + + switch (resource_type(res)) { + case IORESOURCE_MEM: + parent = &iomem_resource; + res_valid |= !(res->flags & IORESOURCE_PREFETCH); + break; + default: + continue; + } + + err = devm_request_resource(dev, parent, res); + if (err) + goto out_release_res; + } + + if (!res_valid) { + dev_err(dev, "non-prefetchable memory resource required\n"); + err = -EINVAL; + goto out_release_res; + } + + return 0; + +out_release_res: + altera_pcie_release_of_pci_ranges(pcie); + return err; +} + +static void altera_pcie_free_irq_domain(struct altera_pcie *pcie) +{ + int i; + u32 irq; + + for (i = 0; i < INTX_NUM; i++) { + irq = irq_find_mapping(pcie->irq_domain, i + 1); + if (irq > 0) + irq_dispose_mapping(irq); + } + + irq_domain_remove(pcie->irq_domain); +} + +static int altera_pcie_init_irq_domain(struct altera_pcie *pcie) +{ + struct device *dev = &pcie->pdev->dev; + struct device_node *node = dev->of_node; + + /* Setup INTx */ + pcie->irq_domain = irq_domain_add_linear(node, INTX_NUM, + &intx_domain_ops, pcie); + if (!pcie->irq_domain) { + dev_err(dev, "Failed to get a INTx IRQ domain\n"); + return -ENOMEM; + } + + return 0; +} + +static int altera_pcie_parse_dt(struct altera_pcie *pcie) +{ + struct resource *cra; + struct platform_device *pdev = pcie->pdev; + + cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra"); + if (!cra) { + dev_err(&pdev->dev, + "no Cra memory resource defined\n"); + return -ENODEV; + } + + pcie->cra_base = devm_ioremap_resource(&pdev->dev, cra); + if (IS_ERR(pcie->cra_base)) { + dev_err(&pdev->dev, "failed to map cra memory\n"); + return PTR_ERR(pcie->cra_base); + } + + /* setup IRQ */ + pcie->irq = platform_get_irq(pdev, 0); + if (pcie->irq <= 0) { + dev_err(&pdev->dev, "failed to get IRQ: %d\n", pcie->irq); + return -EINVAL; + } + + irq_set_chained_handler_and_data(pcie->irq, altera_pcie_isr, pcie); + + return 0; +} + +static int altera_pcie_probe(struct platform_device *pdev) +{ + struct altera_pcie *pcie; + struct pci_bus *bus; + struct pci_bus *child; + int ret; + + pcie = devm_kzalloc(&pdev->dev, sizeof(*pcie), GFP_KERNEL); + if (!pcie) + return -ENOMEM; + + pcie->pdev = pdev; + + ret = altera_pcie_parse_dt(pcie); + if (ret) { + dev_err(&pdev->dev, "Parsing DT failed\n"); + return ret; + } + + INIT_LIST_HEAD(&pcie->resources); + + ret = altera_pcie_parse_request_of_pci_ranges(pcie); + if (ret) { + dev_err(&pdev->dev, "Failed add resources\n"); + return ret; + } + + ret = altera_pcie_init_irq_domain(pcie); + if (ret) { + dev_err(&pdev->dev, "Failed creating IRQ Domain\n"); + return ret; + } + + /* clear all interrupts */ + cra_writel(pcie, P2A_INT_STS_ALL, P2A_INT_STATUS); + /* enable all interrupts */ + cra_writel(pcie, P2A_INT_ENA_ALL, P2A_INT_ENABLE); + + bus = pci_scan_root_bus(&pdev->dev, pcie->root_bus_nr, &altera_pcie_ops, + pcie, &pcie->resources); + if (!bus) + return -ENOMEM; + + pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); + pci_assign_unassigned_bus_resources(bus); + pci_bus_add_devices(bus); + + /* Configure PCI Express setting. */ + list_for_each_entry(child, &bus->children, node) + pcie_bus_configure_settings(child); + + platform_set_drvdata(pdev, pcie); + return ret; +} + +static int altera_pcie_remove(struct platform_device *pdev) +{ + struct altera_pcie *pcie = platform_get_drvdata(pdev); + + altera_pcie_free_irq_domain(pcie); + platform_set_drvdata(pdev, NULL); + return 0; +} + +static const struct of_device_id altera_pcie_of_match[] = { + { .compatible = "altr,pcie-root-port-1.0", }, + {}, +}; +MODULE_DEVICE_TABLE(of, altera_pcie_of_match); + +static struct platform_driver altera_pcie_driver = { + .probe = altera_pcie_probe, + .remove = altera_pcie_remove, + .driver = { + .name = "altera-pcie", + .of_match_table = altera_pcie_of_match, + }, +}; + +module_platform_driver(altera_pcie_driver); + +MODULE_AUTHOR("Ley Foon Tan <lftan@altera.com>"); +MODULE_DESCRIPTION("Altera PCIe host controller driver"); +MODULE_LICENSE("GPL v2");