| Message ID | 1445829362-2738-5-git-send-email-weiyang@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On 10/26/2015 02:15 PM, Wei Yang wrote: > As commit ac205b7bb72f ("PCI: make sriov work with hotplug remove") indicates, > VFs, which might be hooked to same PCI bus as their PF should be removed A comma is missing before "should be" (or you did not need a comma after "VFs" may be :) ). > before the PF. Otherwise, the PCI hot unplugging on the PCI bus would s/on/of/? "Unplugging on" does not make much sense to me in this context at least. > cause kernel crash. > > The patch applies the above pattern to PowerPC PCI hotplug path. > > [gwshan: changelog] > Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com> > Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> > --- > arch/powerpc/kernel/pci-hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/pci-hotplug.c b/arch/powerpc/kernel/pci-hotplug.c > index 7f9ed0c..59c4361 100644 > --- a/arch/powerpc/kernel/pci-hotplug.c > +++ b/arch/powerpc/kernel/pci-hotplug.c > @@ -55,7 +55,7 @@ void pcibios_remove_pci_devices(struct pci_bus *bus) > > pr_debug("PCI: Removing devices on bus %04x:%02x\n", > pci_domain_nr(bus), bus->number); > - list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) { > + list_for_each_entry_safe_reverse(dev, tmp, &bus->devices, bus_list) { > pr_debug(" Removing %s...\n", pci_name(dev)); > pci_stop_and_remove_bus_device(dev); > } >
On Fri, Oct 30, 2015 at 02:04:12PM +1100, Alexey Kardashevskiy wrote: >On 10/26/2015 02:15 PM, Wei Yang wrote: >>As commit ac205b7bb72f ("PCI: make sriov work with hotplug remove") indicates, >>VFs, which might be hooked to same PCI bus as their PF should be removed > >A comma is missing before "should be" (or you did not need a comma after >"VFs" may be :) ). > I think you are right. > >>before the PF. Otherwise, the PCI hot unplugging on the PCI bus would > >s/on/of/? "Unplugging on" does not make much sense to me in this context at >least. > Sounds I need to improve my English :-) "on" here means those PCI devices are attached to the PCI bus. So "of" is the correct word? Change "unplugging" to "removing" would be better? > >>cause kernel crash. >> >>The patch applies the above pattern to PowerPC PCI hotplug path. >> >>[gwshan: changelog] >>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com> >>Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> >>--- >> arch/powerpc/kernel/pci-hotplug.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/arch/powerpc/kernel/pci-hotplug.c b/arch/powerpc/kernel/pci-hotplug.c >>index 7f9ed0c..59c4361 100644 >>--- a/arch/powerpc/kernel/pci-hotplug.c >>+++ b/arch/powerpc/kernel/pci-hotplug.c >>@@ -55,7 +55,7 @@ void pcibios_remove_pci_devices(struct pci_bus *bus) >> >> pr_debug("PCI: Removing devices on bus %04x:%02x\n", >> pci_domain_nr(bus), bus->number); >>- list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) { >>+ list_for_each_entry_safe_reverse(dev, tmp, &bus->devices, bus_list) { >> pr_debug(" Removing %s...\n", pci_name(dev)); >> pci_stop_and_remove_bus_device(dev); >> } >> > > >-- >Alexey
diff --git a/arch/powerpc/kernel/pci-hotplug.c b/arch/powerpc/kernel/pci-hotplug.c index 7f9ed0c..59c4361 100644 --- a/arch/powerpc/kernel/pci-hotplug.c +++ b/arch/powerpc/kernel/pci-hotplug.c @@ -55,7 +55,7 @@ void pcibios_remove_pci_devices(struct pci_bus *bus) pr_debug("PCI: Removing devices on bus %04x:%02x\n", pci_domain_nr(bus), bus->number); - list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) { + list_for_each_entry_safe_reverse(dev, tmp, &bus->devices, bus_list) { pr_debug(" Removing %s...\n", pci_name(dev)); pci_stop_and_remove_bus_device(dev); }
As commit ac205b7bb72f ("PCI: make sriov work with hotplug remove") indicates, VFs, which might be hooked to same PCI bus as their PF should be removed before the PF. Otherwise, the PCI hot unplugging on the PCI bus would cause kernel crash. The patch applies the above pattern to PowerPC PCI hotplug path. [gwshan: changelog] Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> --- arch/powerpc/kernel/pci-hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)