From patchwork Tue Oct 27 17:34:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Busch X-Patchwork-Id: 7499711 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E5DB5BEEA4 for ; Tue, 27 Oct 2015 17:35:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 359CB206CD for ; Tue, 27 Oct 2015 17:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 504BA2064E for ; Tue, 27 Oct 2015 17:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965353AbbJ0RfH (ORCPT ); Tue, 27 Oct 2015 13:35:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:46147 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965725AbbJ0ReR (ORCPT ); Tue, 27 Oct 2015 13:34:17 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 27 Oct 2015 10:34:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,206,1444719600"; d="scan'208";a="836328516" Received: from dcgshare.lm.intel.com ([10.232.118.254]) by orsmga002.jf.intel.com with ESMTP; 27 Oct 2015 10:34:09 -0700 Received: by dcgshare.lm.intel.com (Postfix, from userid 1017) id 64F33E00EB; Tue, 27 Oct 2015 11:34:09 -0600 (MDT) From: Keith Busch To: LKML , x86@kernel.org, linux-pci@vger.kernel.org Cc: Jiang Liu , Thomas Gleixner , Dan Williams , Bjorn Helgaas , Bryan Veal , Ingo Molnar , "H. Peter Anvin" , Martin Mares , Jon Derrick , Keith Busch Subject: [RFC PATCHv3 1/4] pci: skip child bus with conflicting resources Date: Tue, 27 Oct 2015 11:34:04 -0600 Message-Id: <1445967247-24310-2-git-send-email-keith.busch@intel.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1445967247-24310-1-git-send-email-keith.busch@intel.com> References: <1445967247-24310-1-git-send-email-keith.busch@intel.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP And use the max bus resource from the parent rather than assume 255. Signed-off-by: Keith Busch --- drivers/pci/probe.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 8361d27..1cb3be7 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -856,7 +856,10 @@ int pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max, int pass) if (!child) goto out; child->primary = primary; - pci_bus_insert_busn_res(child, secondary, subordinate); + if (!pci_bus_insert_busn_res(child, secondary, subordinate)) { + pci_remove_bus(child); + goto out; + } child->bridge_ctl = bctl; } @@ -896,7 +899,10 @@ int pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max, int pass) child = pci_add_new_bus(bus, dev, max+1); if (!child) goto out; - pci_bus_insert_busn_res(child, max+1, 0xff); + if (!pci_bus_insert_busn_res(child, max+1, bus->busn_res.end)) { + pci_remove_bus(child); + goto out; + } } max++; buses = (buses & 0xff000000)