From patchwork Thu Dec 3 09:54:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ley Foon Tan X-Patchwork-Id: 7757991 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EAD8CBEEE1 for ; Thu, 3 Dec 2015 10:10:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 48DA320571 for ; Thu, 3 Dec 2015 10:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A21F2051C for ; Thu, 3 Dec 2015 10:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759432AbbLCKKK (ORCPT ); Thu, 3 Dec 2015 05:10:10 -0500 Received: from mail-by2on0065.outbound.protection.outlook.com ([207.46.100.65]:23584 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751616AbbLCKKF (ORCPT ); Thu, 3 Dec 2015 05:10:05 -0500 X-Greylist: delayed 894 seconds by postgrey-1.27 at vger.kernel.org; Thu, 03 Dec 2015 05:10:04 EST Received: from BY2PR03CA044.namprd03.prod.outlook.com (10.141.249.17) by CY1PR0301MB2075.namprd03.prod.outlook.com (10.164.2.145) with Microsoft SMTP Server (TLS) id 15.1.337.19; Thu, 3 Dec 2015 09:55:08 +0000 Received: from BY2FFO11FD019.protection.gbl (2a01:111:f400:7c0c::196) by BY2PR03CA044.outlook.office365.com (2a01:111:e400:2c5d::17) with Microsoft SMTP Server (TLS) id 15.1.331.20 via Frontend Transport; Thu, 3 Dec 2015 09:55:08 +0000 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=altera.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning altera.com discourages use of 66.35.236.227 as permitted sender) Received: from sj-itexedge03.altera.priv.altera.com (66.35.236.227) by BY2FFO11FD019.mail.protection.outlook.com (10.1.14.107) with Microsoft SMTP Server (TLS) id 15.1.337.8 via Frontend Transport; Thu, 3 Dec 2015 09:55:08 +0000 Received: from sj-mail01.altera.com (137.57.1.6) by webmail.altera.com (66.35.236.227) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 3 Dec 2015 01:54:21 -0800 Received: from leyfoon-vm (pg-lftan-l.altera.com [137.57.103.123]) by sj-mail01.altera.com (8.13.7+Sun/8.13.7) with SMTP id tB39t4gE022255; Thu, 3 Dec 2015 01:55:05 -0800 (PST) Received: by leyfoon-vm (sSMTP sendmail emulation); Thu, 03 Dec 2015 17:55:03 +0800 From: Ley Foon Tan To: Bjorn Helgaas CC: , , Ley Foon Tan , Subject: [PATCH 3/3] PCI: altera: fix error when INTX is 4 Date: Thu, 3 Dec 2015 17:54:49 +0800 Message-ID: <1449136489-2559-4-git-send-email-lftan@altera.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1449136489-2559-1-git-send-email-lftan@altera.com> References: <1449136489-2559-1-git-send-email-lftan@altera.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD019; 1:hXLwmHlE4f/Zmwp4YG82NMOzW1hVN0GtbOgCNk4fCfv1J0sgLXMTU1G43szNSwKDhQAB7HJEHRHjz+LIm1R8WELpTD0dv19MtgTt7lScLa8VbaiHd2XHZDF0WCdl1DH4OBpxnUtFROiHlh1vC0/5NuvpSSe0gjKVnO+9jGtkuFq2h9gJpCJSgBbTAxLy67RXtHO4BPkK4GbWvsFVBJ/neU6wq+8erCHgMUj9j+Pwi9lluwzPZiRdGgkETTcvTo4+rtQhE7RI9SxV23AHpnQ8hDOGYXQXTjWIcbCtwjHwB+UQu3mIx8KbnLvJBKFAgyeMUIYjXGskYzaSYo096c8uio20WqvhwZxh3RqzF3sLgG9KTYcFtaUpudq5N0nj/Ng7Ll3odcBmxgHTGQjKv2DcDQ== X-Forefront-Antispam-Report: CIP:66.35.236.227; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(199003)(189002)(36756003)(19580405001)(19580395003)(6806005)(92566002)(229853001)(76176999)(50226001)(50466002)(50986999)(11100500001)(47776003)(5003940100001)(48376002)(5001960100002)(42186005)(87936001)(1096002)(189998001)(105596002)(106466001)(86362001)(97736004)(2950100001)(586003)(81156007)(110136002)(33646002)(5008740100001)(1220700001)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB2075; H:sj-itexedge03.altera.priv.altera.com; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2075; 2:1/G5eHpKF8b/ZNpn5d52C6U5oXHiuAC9+WpcTUsfxx1jYRvFVSjSmOxgd7JcFHlDWuuXrdmTLR5kvKVPv18fCe7YWxuCjLV6LsZRxMJSQs/rjnZa6JW/4ryuxdLFoy75pG7LKnwIt3KO8aGYcGcHoA==; 3:+Tb/QGyGDL4J65PTASkgL62ARMuJ0lRsM187/5aXxWfwjR50B1lSIT3Ys/eGacpe8Af+ers8HEQi6UQI5fJ5DvjzJ0cuniG0RX7dbAFH91y6u7Nhx0MpEqDSLZxsBIpbvGl4YhZPWL9U1D79+dSzCjpKOcxAezvljIQaruFnsfAMsOiYjMSnsxV1L0Z9LfHJZJKeHgPd9MdZVR1EAdTni6H4/4aS56ycudl5+diIOVY=; 25:2d0ZEwQc6Mf7QpFcDhcrJICGKMTEqRIUY4cbLlPk4Il1mfu3z8ODL3cJUuQC4yzh3cdJI8ekrSLDAbo2lTSCckSAQq8v6B+GGCt1cwtbH9OQ/4jXLzunIjHLb9uLzMYy6q4Zcu0P4z9e3MvQe86kfNV7JfyWvQJaMSraFVtpzJreO/wN3G8rYd8TdSaL+0Nchsul3l+lUwUkj01yV61EEYEKlF6RMXo5SJTLNOsmueivPUFlC7n+u1p8EUOoeZDE; 20:NYU27rjy6hgUHz6+q54B6342IQXTX6qLQSBkqZtakb4LqU6ewwrc4OIvQQZ4l52zKbwezBew4k9evAY4HIyuT9OsqCZKnjaXU5YeGTCRos0Ji5JQOEnU75SuKR0txOwlQlmD5c+aDKCncEmwPw+DthLlFy1BWgTIuNntKWenBaE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2075; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001); SRVR:CY1PR0301MB2075; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB2075; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2075; 4:PlQ466Z3KJl5ViZnW/tcHYmILxozZYj48wyFisk0OhzDwHYkikqiUCDEZbROVZU7IK4wwecdq/CokJyUFgQjmNK8aMAwLkb9UIY98yEpX4wMmbj1y34kWFnbaRk1C3THGDw27+tplOOVXBBVTXW5Gjan3pDRJq5hfcKAoatB5O8he9hjPq3udqqrZgIDCMxjyUUNQcBviOuH7uBwdH9OHj56FdLrjKXioAB1SUT+aujkOuToQMyZIacdvDeNfjscTA8wEEsHvV70+Qoove6EaBSoKVaGvlAk1zw2UnOqMTS/Ek6KqBTNi5qVGDv7n3UYInkAcw6sRIAJ94Dy4RAWME5ffSCUQty/3ySkm0rjvuRN3jiLepMtE3NzSuWGYwyAoSnrBL9ZKGqr1lrzifdoscAUJ6Bs6+BqtVhyaLtPNbM= X-Forefront-PRVS: 077929D941 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2075; 23:g94631/+qwrongaWOSIamA1huH2nDGn6m0xlkcnw275I1Un109KGyENq37yXfJPOsuVJbYbm/MNLamAoNDbiohmp2t1lloKl57tSlgwG+Zu14hDKolT/TrzOLLWZCxfxAYdJ1nT7HDKQCckY/H8LfHqb0cOyV+YK0W2LhrLncbG+E3ThTDWp8LRYZ5h6tVBmDVnLRgaiq/u9ZR43ckGfbaTnNPwjmoNuEWENmrVlLBzFqRyjXX8ClGm+qwd1Ddqlk6+hkKFAm2ZrCmzuptfNw5Q/Wkk4BG46CG/LzoKvw37qmKQaJr4xT5X80H0srt11EuQqXj1UPIivWeS2VjAxQLnF0XM27ogwmzDnx9jUbJtpGWayCYrrQ01O2VfEz2DdFdJj+907Knw8Yz6GmgsstHqfPNSVdrVdb/RS97McQXhq0H+tzHyFIi9fs5jCsIYbyioT8SzvG0xEjEal/OJD+e6ZMwcBiqHR/au2N+Tt/HjcUEDtUxyeSpOg4wRWMZOXpL8xTg9iZml1a7V3aBiU0itQYm8VvDsFEULVmgNprPoM/d5qLCwlPh58TwTmLO8/XlWTE2AenSu6NnmDVbjbW1r8YGU7SiLMmza+NzlTbgqGP1S7D9+MmHYN9fMGDJn/80na3fKknby0sIwlPfV8MB1oLMqDNCB5/OQxdJm59+/JFD9bnaO4BneBGDNrEUCEoZaaT5uEHOYmFVMRqAcNn4SpK/AkmejKXg0mgU/LQKPiYAecMa9MEEGFwvHC+y8Z/BtQTSkN3aVOinGW51OrWaGbqlSXFHe300U50K3kUZY3VYOY47hd4zLHVF7W7fRGwZg55JUSu0dlNwNka5k7+yFT99koHag8OwkCMCcPG/vCzSLrjfhxQ7ghpeOlxhT/NOXgn++yeFvbeAtiyfzBpshvNarp74kJwg0ylH3 rx9Z0Pu+PUfcsXFKQgUHptgzR X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2075; 5:zZ4a8uziholuJRCj8FymRutxwykQjFquijZok6kS2tBp2Oz24IFKNw+Vyt4Wykr5rf2QKoHg3gqfXWrC+bUBdEctfFEes7jS9EaRfDsd2faSs2JMyXTVuxr4TVZYyqiU85EoyHFrJes2HktMNGfHeQ==; 24:MupZmp8J5ylxLcFsiFkSWazS3K/7B6zoV5vS8ga/26bFYYgxj10DVWq/9aBAOj7szNggDWg7Ycny7QsKRfmUVpRCxjTvRhYDZpchCd7ff1w=; 20:v+Udiz1bOHn0WJX0ihJ0an7a4m6SI++GVJQqbrzFyckQRDp6SaPw1L382aChwgEEL/W4G2QWIkeI0WUh8IQPEDSgiNuweB93u+vc37t2qDMIqLgvBsTgrIv+oCt+5FcPO7RPCx71XseDenMj4EaXxckuBzH6LvwNTC57GBZouIg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2015 09:55:08.1114 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a; Ip=[66.35.236.227]; Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2075 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PCI interrupt lines start at 1, not at 0. So, change INTX_NUM to 5. Error when PCIe devices have 4 INTX: WARNING: CPU: 1 PID: 1 at kernel/irq/irqdomain.c:280 irq_domain_associate+0x17c/0x1cc() error: hwirq 0x4 is too large for dummy Tested on Ethernet adapter card with multi-functions. Signed-off-by: Ley Foon Tan --- drivers/pci/host/pcie-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index e4176b3..8b30d4a 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -60,7 +60,7 @@ #define TLP_LOOP 500 #define RP_DEVFN 0 -#define INTX_NUM 4 +#define INTX_NUM 5 #define DWORD_MASK 3