From patchwork Wed Dec 16 15:16:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 7862691 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6F6489F1C2 for ; Wed, 16 Dec 2015 15:22:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 78E1020382 for ; Wed, 16 Dec 2015 15:22:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DB96202FE for ; Wed, 16 Dec 2015 15:22:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933885AbbLPPWC (ORCPT ); Wed, 16 Dec 2015 10:22:02 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:33380 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965764AbbLPPSF (ORCPT ); Wed, 16 Dec 2015 10:18:05 -0500 Received: by mail-wm0-f43.google.com with SMTP id p187so5707735wmp.0 for ; Wed, 16 Dec 2015 07:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+412m+6ydg9iTY9A9jDXddqhjHbIoakpLEj68IT6FSQ=; b=E2Z/Ay8+cz3y+JAawhnzR7zzZKwUtJh+oPtkbbkQnya6htUGsyAmVsTiRIv7n1v6/+ 8/+dEICquyGUYzTWF/0oz7vl45NKQjwr8bM5GnFrQBKYyutzbeqhjzYV7JJLp3h2amnF IcY5d5OqZcyKUSGYid+sdNRRQJrl3fKnqyKHApmx1mrgFN84D3HiTK4otMbK23cTiPHH r/ZAWMl02vjQ/1H69BV1Oif+H5m8Jv6GBZMtpExHCfyxy+KeyhAbgijgY8mFmD/3Z6hS 5FPj97czr7eKyjgm9/tt2hYPDdmqHER6TDm7GRx5q0XlnVfbUz8+LMLIwMBM3H7qQDdf cR4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+412m+6ydg9iTY9A9jDXddqhjHbIoakpLEj68IT6FSQ=; b=ggjKFx9gAhcoWTptY+BTd9xGPjww4prJl1juLodbAPMda1PQiQk7TyDXzVQaZXgLoQ xpZrvFxzoMq+80ULAbZs3pRmag05Tq/1brr+MI+K3mCzhfCEZdComtJYBHYMs0mpUmxY wMSMWoEbnkKrZtv8Q3UWHj91Do5XqDlJ1Nh7+Oz0jBXvPgXzkOisMgaOLg4EKWrbRwjx cZS8KgZmFrV2QmJyX/wMxq37kqmsJuaDHNkk2KYS85NkydTEiliYDIjMd6m4U8XQ0otH LFEkvmQ5TXvxZLcfxc+Q/fEMZ0KA2QNeHxdD+sLgnNlCov6dvv4eBLsoxGuNU+t7s+md pGlA== X-Gm-Message-State: ALoCoQnQKZOXqxx+Kd6MXBPo7DYQ1rS2mOU5KygXQ5FeTIWCz+kYzCRAmMfNewB63c7Hv0f1CJ0wXX6i60nZM9Ex86Yfw1kcJw== X-Received: by 10.28.125.201 with SMTP id y192mr12611084wmc.23.1450279084610; Wed, 16 Dec 2015 07:18:04 -0800 (PST) Received: from tn-HP-4.semihalf.local ([80.82.22.190]) by smtp.gmail.com with ESMTPSA id z17sm6438761wjq.1.2015.12.16.07.18.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Dec 2015 07:18:04 -0800 (PST) From: Tomasz Nowicki To: bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, tglx@linutronix.de, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jchandra@broadcom.com, jcm@redhat.com, Tomasz Nowicki Subject: [PATCH V2 14/23] pci, acpi: Provide generic way to assign bus domain number. Date: Wed, 16 Dec 2015 16:16:24 +0100 Message-Id: <1450278993-12664-15-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1450278993-12664-1-git-send-email-tn@semihalf.com> References: <1450278993-12664-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As we now have valid PCI host bridge device reference we can introduce code that is going to find its bus domain number using ACPI _SEG method. Note that _SEG method is optional, therefore _SEG absence means that all PCI buses belong to domain 0. Signed-off-by: Tomasz Nowicki Reviewed-by: Liviu Dudau Tested-by: Suravee Suthikulpanit --- drivers/pci/pci.c | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 7274006..39a985b 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -4796,14 +4797,34 @@ void pci_bus_assign_domain_nr(struct pci_bus *bus, struct device *parent) * API and update the use_dt_domains value to keep track of method we * are using to assign domain numbers (use_dt_domains = 0). * + * IF ACPI, we expect non-DT method (use_dt_domains == -1) + * and call _SEG method for corresponding host bridge device. + * If _SEG method does not exist, following ACPI spec (6.5.6) + * all PCI buses belong to domain 0. + * * All other combinations imply we have a platform that is trying - * to mix domain numbers obtained from DT and pci_get_new_domain_nr(), - * which is a recipe for domain mishandling and it is prevented by - * invalidating the domain value (domain = -1) and printing a - * corresponding error. + * to mix domain numbers obtained from DT, ACPI and + * pci_get_new_domain_nr(), which is a recipe for domain mishandling and + * it is prevented by invalidating the domain value (domain = -1) and + * printing a corresponding error. */ + if (domain >= 0 && use_dt_domains) { use_dt_domains = 1; +#ifdef CONFIG_ACPI + } else if (!acpi_disabled && use_dt_domains == -1) { + struct acpi_device *acpi_dev = to_acpi_device(parent); + unsigned long long segment = 0; + acpi_status status; + + status = acpi_evaluate_integer(acpi_dev->handle, + METHOD_NAME__SEG, NULL, + &segment); + if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) + dev_err(&acpi_dev->dev, "can't evaluate _SEG\n"); + + domain = segment; +#endif } else if (domain < 0 && use_dt_domains != 1) { use_dt_domains = 0; domain = pci_get_new_domain_nr();