| Message ID | 1454602213-967-7-git-send-email-paul.burton@imgtec.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Feb 4, 2016 at 10:10 AM, Paul Burton <paul.burton@imgtec.com> wrote: > Allow the xilinx-pcie driver to be built on MIPS platforms. This will be > used on the MIPS Boston board. > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > > --- > > Changes in v3: > - Split out from Boston patchset. > > Changes in v2: None > > drivers/pci/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > index 75a6054..0aee193 100644 > --- a/drivers/pci/host/Kconfig > +++ b/drivers/pci/host/Kconfig > @@ -81,7 +81,7 @@ config PCI_KEYSTONE > > config PCIE_XILINX > bool "Xilinx AXI PCIe host bridge support" > - depends on ARCH_ZYNQ > + depends on ARCH_ZYNQ || MIPS Why don't you just remove the dependency? Then it gets better build coverage. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 04, 2016 at 11:46:28AM -0600, Rob Herring wrote: > On Thu, Feb 4, 2016 at 10:10 AM, Paul Burton <paul.burton@imgtec.com> wrote: > > Allow the xilinx-pcie driver to be built on MIPS platforms. This will be > > used on the MIPS Boston board. > > > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > > > > --- > > > > Changes in v3: > > - Split out from Boston patchset. > > > > Changes in v2: None > > > > drivers/pci/host/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > > index 75a6054..0aee193 100644 > > --- a/drivers/pci/host/Kconfig > > +++ b/drivers/pci/host/Kconfig > > @@ -81,7 +81,7 @@ config PCI_KEYSTONE > > > > config PCIE_XILINX > > bool "Xilinx AXI PCIe host bridge support" > > - depends on ARCH_ZYNQ > > + depends on ARCH_ZYNQ || MIPS > > Why don't you just remove the dependency? Then it gets better build coverage. > > Rob That seems like a call best made by whomever has to maintain this - if that's the preferred way to go I'm fine with it. Thanks, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 04, 2016 at 05:53:25PM +0000, Paul Burton wrote: > On Thu, Feb 04, 2016 at 11:46:28AM -0600, Rob Herring wrote: > > On Thu, Feb 4, 2016 at 10:10 AM, Paul Burton <paul.burton@imgtec.com> wrote: > > > Allow the xilinx-pcie driver to be built on MIPS platforms. This will be > > > used on the MIPS Boston board. > > > > > > Signed-off-by: Paul Burton <paul.burton@imgtec.com> > > > > > > --- > > > > > > Changes in v3: > > > - Split out from Boston patchset. > > > > > > Changes in v2: None > > > > > > drivers/pci/host/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > > > index 75a6054..0aee193 100644 > > > --- a/drivers/pci/host/Kconfig > > > +++ b/drivers/pci/host/Kconfig > > > @@ -81,7 +81,7 @@ config PCI_KEYSTONE > > > > > > config PCIE_XILINX > > > bool "Xilinx AXI PCIe host bridge support" > > > - depends on ARCH_ZYNQ > > > + depends on ARCH_ZYNQ || MIPS > > > > Why don't you just remove the dependency? Then it gets better build coverage. > > > > Rob > > That seems like a call best made by whomever has to maintain this - if > that's the preferred way to go I'm fine with it. I'm in favor of removing the dependency if possible. I guess Michal would be the person to ack that. Right now (in my current "next" branch), drivers/pci/host/pcie-xilinx.c uses struct hw_pci, which is only defined by arm. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25.2.2016 16:43, Bjorn Helgaas wrote: > On Thu, Feb 04, 2016 at 05:53:25PM +0000, Paul Burton wrote: >> On Thu, Feb 04, 2016 at 11:46:28AM -0600, Rob Herring wrote: >>> On Thu, Feb 4, 2016 at 10:10 AM, Paul Burton <paul.burton@imgtec.com> wrote: >>>> Allow the xilinx-pcie driver to be built on MIPS platforms. This will be >>>> used on the MIPS Boston board. >>>> >>>> Signed-off-by: Paul Burton <paul.burton@imgtec.com> >>>> >>>> --- >>>> >>>> Changes in v3: >>>> - Split out from Boston patchset. >>>> >>>> Changes in v2: None >>>> >>>> drivers/pci/host/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig >>>> index 75a6054..0aee193 100644 >>>> --- a/drivers/pci/host/Kconfig >>>> +++ b/drivers/pci/host/Kconfig >>>> @@ -81,7 +81,7 @@ config PCI_KEYSTONE >>>> >>>> config PCIE_XILINX >>>> bool "Xilinx AXI PCIe host bridge support" >>>> - depends on ARCH_ZYNQ >>>> + depends on ARCH_ZYNQ || MIPS >>> >>> Why don't you just remove the dependency? Then it gets better build coverage. >>> >>> Rob >> >> That seems like a call best made by whomever has to maintain this - if >> that's the preferred way to go I'm fine with it. > > I'm in favor of removing the dependency if possible. I guess Michal > would be the person to ack that. Not a problem to remove dependency on archs. There is pending support for Microblaze anyway. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 75a6054..0aee193 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -81,7 +81,7 @@ config PCI_KEYSTONE config PCIE_XILINX bool "Xilinx AXI PCIe host bridge support" - depends on ARCH_ZYNQ + depends on ARCH_ZYNQ || MIPS help Say 'Y' here if you want kernel to support the Xilinx AXI PCIe Host Bridge driver.
Allow the xilinx-pcie driver to be built on MIPS platforms. This will be used on the MIPS Boston board. Signed-off-by: Paul Burton <paul.burton@imgtec.com> --- Changes in v3: - Split out from Boston patchset. Changes in v2: None drivers/pci/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)