From patchwork Tue Feb 9 18:08:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kelly Zytaruk X-Patchwork-Id: 8264621 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 460B9BEEE5 for ; Tue, 9 Feb 2016 18:09:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B007020260 for ; Tue, 9 Feb 2016 18:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90B7D201F2 for ; Tue, 9 Feb 2016 18:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754127AbcBISJQ (ORCPT ); Tue, 9 Feb 2016 13:09:16 -0500 Received: from [165.204.55.251] ([165.204.55.251]:47214 "EHLO KellyTonga.amd.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753084AbcBISJP (ORCPT ); Tue, 9 Feb 2016 13:09:15 -0500 Received: from KellyTonga.amd.com (localhost [127.0.0.1]) by KellyTonga.amd.com (8.14.4/8.14.4/Debian-4) with ESMTP id u19I9CuY003753; Tue, 9 Feb 2016 13:09:12 -0500 Received: (from root@localhost) by KellyTonga.amd.com (8.14.4/8.14.4/Submit) id u19I9BtY003752; Tue, 9 Feb 2016 13:09:11 -0500 From: kelly.zytaruk@amd.com To: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kelly Zytaruk Subject: [PATCH] PCI: Support SRIOV on Legacy EndPoint device Date: Tue, 9 Feb 2016 13:08:58 -0500 Message-Id: <1455041338-3644-1-git-send-email-kelly.zytaruk@amd.com> X-Mailer: git-send-email 1.7.10.4 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kelly Zytaruk It is not neccessary to check for PCI_EXP_TYPE in sriov_init(). There appears to be no reason for the check. Some AMD GPUs have hardware support for grapics SRIOV. If the GPU has a display output then the GPU needs to support Legacy VGA operation. If CLASS_CODE = VGA then the device should have a Port Type = Legacy EndPoint. Therefore in order to enable SRIOV on a GPU with a display output, LEGACY_END_POINT is supported as a valid Port Type by removing the check for Port Type. Patch is also logged in Bugzilla #112221 Signed-off-by: Kelly Zytaruk --- drivers/pci/iov.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 31f31d4..fe4bd0a 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c @@ -387,10 +387,6 @@ static int sriov_init(struct pci_dev *dev, int pos) struct resource *res; struct pci_dev *pdev; - if (pci_pcie_type(dev) != PCI_EXP_TYPE_RC_END && - pci_pcie_type(dev) != PCI_EXP_TYPE_ENDPOINT) - return -ENODEV; - pci_read_config_word(dev, pos + PCI_SRIOV_CTRL, &ctrl); if (ctrl & PCI_SRIOV_CTRL_VFE) { pci_write_config_word(dev, pos + PCI_SRIOV_CTRL, 0);