| Message ID | 1466200821-29159-2-git-send-email-keith.busch@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Fri, Jun 17, 2016 at 04:00:21PM -0600, Keith Busch wrote: > There is no way to know which device in a VMD tiggered an interrupt s/tiggered/triggered/ > without invoking every registered driver's actions. This uses the > untracked irq handler so that a less used device does not trigger > spurious interrupt. > > We have been previously recommending users enable "noirqdebug", but do > not want to force a system setting just to keep this domain functional. I applaud that goal. > Signed-off-by: Keith Busch <keith.busch@intel.com> Since this depends on the previous patch and I'm not qualified to review that one, I'll ack this and somebody else can merge both or none: Acked-by: Bjorn Helgaas <bhelgaas@google.com> > --- > arch/x86/pci/vmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c > index 7792aba..613cac7 100644 > --- a/arch/x86/pci/vmd.c > +++ b/arch/x86/pci/vmd.c > @@ -195,7 +195,7 @@ static int vmd_msi_init(struct irq_domain *domain, struct msi_domain_info *info, > vmdirq->virq = virq; > > irq_domain_set_info(domain, virq, vmdirq->irq->vmd_vector, info->chip, > - vmdirq, handle_simple_irq, vmd, NULL); > + vmdirq, handle_untracked_irq, vmd, NULL); > return 0; > } > > -- > 2.7.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/pci/vmd.c b/arch/x86/pci/vmd.c index 7792aba..613cac7 100644 --- a/arch/x86/pci/vmd.c +++ b/arch/x86/pci/vmd.c @@ -195,7 +195,7 @@ static int vmd_msi_init(struct irq_domain *domain, struct msi_domain_info *info, vmdirq->virq = virq; irq_domain_set_info(domain, virq, vmdirq->irq->vmd_vector, info->chip, - vmdirq, handle_simple_irq, vmd, NULL); + vmdirq, handle_untracked_irq, vmd, NULL); return 0; }
There is no way to know which device in a VMD tiggered an interrupt without invoking every registered driver's actions. This uses the untracked irq handler so that a less used device does not trigger spurious interrupt. We have been previously recommending users enable "noirqdebug", but do not want to force a system setting just to keep this domain functional. Signed-off-by: Keith Busch <keith.busch@intel.com> --- arch/x86/pci/vmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)