| Message ID | 1477932510-28594-9-git-send-email-jgross@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Mon, Oct 31, 2016 at 05:48:26PM +0100, Juergen Gross wrote: > Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. > This requires to change the type of the read from int to unsigned, > but this case has been wrong before: negative values are not allowed > for the modified case. > > Cc: bhelgaas@google.com > Cc: linux-pci@vger.kernel.org > > Signed-off-by: Juergen Gross <jgross@suse.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com> I assume this will be merged with the rest of the series via some tree other than mine. > --- > drivers/pci/xen-pcifront.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c > index d6ff5e8..8fc2e95 100644 > --- a/drivers/pci/xen-pcifront.c > +++ b/drivers/pci/xen-pcifront.c > @@ -1038,10 +1038,8 @@ static int pcifront_detach_devices(struct pcifront_device *pdev) > err = -ENOMEM; > goto out; > } > - err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str, "%d", > - &state); > - if (err != 1) > - state = XenbusStateUnknown; > + state = xenbus_read_unsigned(pdev->xdev->otherend, str, > + XenbusStateUnknown); > > if (state != XenbusStateClosing) > continue; > -- > 2.6.6 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c index d6ff5e8..8fc2e95 100644 --- a/drivers/pci/xen-pcifront.c +++ b/drivers/pci/xen-pcifront.c @@ -1038,10 +1038,8 @@ static int pcifront_detach_devices(struct pcifront_device *pdev) err = -ENOMEM; goto out; } - err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str, "%d", - &state); - if (err != 1) - state = XenbusStateUnknown; + state = xenbus_read_unsigned(pdev->xdev->otherend, str, + XenbusStateUnknown); if (state != XenbusStateClosing) continue;
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of the read from int to unsigned, but this case has been wrong before: negative values are not allowed for the modified case. Cc: bhelgaas@google.com Cc: linux-pci@vger.kernel.org Signed-off-by: Juergen Gross <jgross@suse.com> --- drivers/pci/xen-pcifront.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)