From patchwork Tue Dec 6 14:28:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9462699 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 65EB160236 for ; Tue, 6 Dec 2016 14:28:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54B0F283F6 for ; Tue, 6 Dec 2016 14:28:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 47DDC28409; Tue, 6 Dec 2016 14:28:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFB90283F6 for ; Tue, 6 Dec 2016 14:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbcLFO2h (ORCPT ); Tue, 6 Dec 2016 09:28:37 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:33363 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbcLFO2g (ORCPT ); Tue, 6 Dec 2016 09:28:36 -0500 Received: by mail-qk0-f193.google.com with SMTP id x190so43965324qkb.0; Tue, 06 Dec 2016 06:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=1XhXXKeJ/ENEtdZjEjx0wm2qGmdak05zTh8tQ6cGRtc=; b=Qv21k0iUYAiBTTd0btElv6GDvRjRHC7pycqjRfd6dUjjq9zQTV8excpsX7rz2VGz0d nmae41HIBoVgbxNZ6M5fKpNE1L1776HTTtE1A0BGxb5AV1mYS0alDmwl72FxO6pJZy7j cfmkjwCcqjpkyWBtQpK9NSVvQH72lK1Y5pAIN1Yoy/d2abf/MPQJPj7/FJhhANPt/R10 F8LIDJDCYjzZuOAn8/at6c9qp48lu7ssCXa3yW5zQVGY8YaUXxD0f0icKR89dXOzY5ND 4p5ERFr2RdvpoqxzfUUok8E4aj6qsmbNcFvTEd0Puw5duTL2RWDLT7wI349KFLBxmNqr XHTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=1XhXXKeJ/ENEtdZjEjx0wm2qGmdak05zTh8tQ6cGRtc=; b=AbYJDY0cWYR5khcOqKyMlFaYyRZhLeNLGZBGO4A/SzFCvOpk1RNMuDFfZYcfJpfvTV uOBJYX6r+mNzReubMOx/Ie5EgyU8SFts6g38I8tRX6MOzYpXrfZBF5XOQg6YzybH9+FU iAdPo1MorM4gzw0rh7wq2OunJfRes06qbc67xkYytpNOw55jZ057H7IdQ24JF2fIe1WW DC7g+9BO7VPwWzog7DR2/ZOrXd02h73SuQN3UJLWV/AVxyMFpDYz1RcVFgWF9c00/RXK SRYEZcpcpOt0098YjzCdT9Bpld9JRh51uFbHb5V3ErkucreSxs/VbHDndiM8XGs7/XHd mtKQ== X-Gm-Message-State: AKaTC03zx34bpKB0GB59YM6VuLz4vBsNbi4Gtl6WteYfEHxMmgHrxM4UkBDO1w3TxkGTpQ== X-Received: by 10.55.92.199 with SMTP id q190mr54213231qkb.303.1481034515599; Tue, 06 Dec 2016 06:28:35 -0800 (PST) Received: from build-external.dumpdata.com (209-6-196-81.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com. [209.6.196.81]) by smtp.gmail.com with ESMTPSA id s41sm12087829qtc.39.2016.12.06.06.28.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 06:28:35 -0800 (PST) From: Konrad Rzeszutek Wilk X-Google-Original-From: Konrad Rzeszutek Wilk To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, bhelgaas@google.com, jgross@suse.com, x86@kernel.org, linux-pci@vger.kernel.org Cc: Konrad Rzeszutek Wilk Subject: [PATCH] xen/pci: Bubble up error and fix description. Date: Tue, 6 Dec 2016 09:28:21 -0500 Message-Id: <1481034501-716-1-git-send-email-konrad.wilk@oracle.com> X-Mailer: git-send-email 2.7.4 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The function is never called under PV guests, and only shows up when MSI (or MSI-X) cannot be allocated. Convert the message to include the error value. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Juergen Gross --- arch/x86/pci/xen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index bedfab9..e1fb269 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -264,8 +264,8 @@ static int xen_hvm_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) return 0; error: - dev_err(&dev->dev, - "Xen PCI frontend has not registered MSI/MSI-X support!\n"); + dev_err(&dev->dev, "Failed to create MSI%s! ret=%d!\n", + type == PCI_CAP_ID_MSI ? "" : "-X", irq); return irq; }