| Message ID | 1484216786-17292-29-git-send-email-kishon@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thu, Jan 12, 2017 at 03:56:17PM +0530, Kishon Vijay Abraham I wrote: > Add device tree binding documentation for pci dra7xx EP mode. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > Documentation/devicetree/bindings/pci/ti-pci.txt | 37 ++++++++++++++++++---- > 1 file changed, 30 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt > index 60e2516..62f5f59 100644 > --- a/Documentation/devicetree/bindings/pci/ti-pci.txt > +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt > @@ -1,17 +1,22 @@ > TI PCI Controllers > > PCIe Designware Controller > - - compatible: Should be "ti,dra7-pcie"" > - - reg : Two register ranges as listed in the reg-names property > - - reg-names : The first entry must be "ti-conf" for the TI specific registers > - The second entry must be "rc-dbics" for the designware pcie > - registers > - The third entry must be "config" for the PCIe configuration space > + - compatible: Should be "ti,dra7-pcie" for RC > + Should be "ti,dra7-pcie-ep" for EP > - phys : list of PHY specifiers (used by generic PHY framework) > - phy-names : must be "pcie-phy0", "pcie-phy1", "pcie-phyN".. based on the > number of PHYs as specified in *phys* property. > - ti,hwmods : Name of the hwmod associated to the pcie, "pcie<X>", > where <X> is the instance number of the pcie from the HW spec. > + - num-lanes as specified in ../designware-pcie.txt > + > +HOST MODE > +========= > + - reg : Two register ranges as listed in the reg-names property > + - reg-names : The first entry must be "ti-conf" for the TI specific registers > + The second entry must be "rc-dbics" for the designware pcie > + registers > + The third entry must be "config" for the PCIe configuration space > - interrupts : Two interrupt entries must be specified. The first one is for > main interrupt line and the second for MSI interrupt line. > - #address-cells, > @@ -19,13 +24,31 @@ PCIe Designware Controller > #interrupt-cells, > device_type, > ranges, > - num-lanes, > interrupt-map-mask, > interrupt-map : as specified in ../designware-pcie.txt > > +DEVICE MODE > +=========== > + - reg : Four register ranges as listed in the reg-names property > + - reg-names : "ti-conf" for the TI specific registers > + "ep_dbics" for the standard configuration registers as > + they are locally accessed within the DIF CS space > + "ep_dbics2" for the standard configuration registers as > + they are locally accessed within the DIF CS2 space > + "addr_space" used to map remote RC address space > + - interrupts : one interrupt entries must be specified for main interrupt. > + - num-ib-windows : number of inbound address translation windows > + - num-ob-windows : number of outbound address translation windows > + > Optional Property: > - gpios : Should be added if a gpio line is required to drive PERST# line > > +NOTE: Two dt nodes should be added for each PCI controller; one for host s/should/may/ Don't define dts source structure here. You could also have 2 files with each config and just include the right one for each board. We don't want overlapping memory regions defined in DT and this kind of violates that, but I guess status is sufficient. With that, Acked-by: Rob Herring <robh@kernel.org> > +mode and another for device mode. So in order for PCI to > +work in host mode, EP mode dt node should be disabled and in order to PCI to > +work in EP mode, host mode dt node should be disabled. And host mode and EP > +mode are mutually exclusive. > + > Example: > axi { > compatible = "simple-bus"; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pci/ti-pci.txt b/Documentation/devicetree/bindings/pci/ti-pci.txt index 60e2516..62f5f59 100644 --- a/Documentation/devicetree/bindings/pci/ti-pci.txt +++ b/Documentation/devicetree/bindings/pci/ti-pci.txt @@ -1,17 +1,22 @@ TI PCI Controllers PCIe Designware Controller - - compatible: Should be "ti,dra7-pcie"" - - reg : Two register ranges as listed in the reg-names property - - reg-names : The first entry must be "ti-conf" for the TI specific registers - The second entry must be "rc-dbics" for the designware pcie - registers - The third entry must be "config" for the PCIe configuration space + - compatible: Should be "ti,dra7-pcie" for RC + Should be "ti,dra7-pcie-ep" for EP - phys : list of PHY specifiers (used by generic PHY framework) - phy-names : must be "pcie-phy0", "pcie-phy1", "pcie-phyN".. based on the number of PHYs as specified in *phys* property. - ti,hwmods : Name of the hwmod associated to the pcie, "pcie<X>", where <X> is the instance number of the pcie from the HW spec. + - num-lanes as specified in ../designware-pcie.txt + +HOST MODE +========= + - reg : Two register ranges as listed in the reg-names property + - reg-names : The first entry must be "ti-conf" for the TI specific registers + The second entry must be "rc-dbics" for the designware pcie + registers + The third entry must be "config" for the PCIe configuration space - interrupts : Two interrupt entries must be specified. The first one is for main interrupt line and the second for MSI interrupt line. - #address-cells, @@ -19,13 +24,31 @@ PCIe Designware Controller #interrupt-cells, device_type, ranges, - num-lanes, interrupt-map-mask, interrupt-map : as specified in ../designware-pcie.txt +DEVICE MODE +=========== + - reg : Four register ranges as listed in the reg-names property + - reg-names : "ti-conf" for the TI specific registers + "ep_dbics" for the standard configuration registers as + they are locally accessed within the DIF CS space + "ep_dbics2" for the standard configuration registers as + they are locally accessed within the DIF CS2 space + "addr_space" used to map remote RC address space + - interrupts : one interrupt entries must be specified for main interrupt. + - num-ib-windows : number of inbound address translation windows + - num-ob-windows : number of outbound address translation windows + Optional Property: - gpios : Should be added if a gpio line is required to drive PERST# line +NOTE: Two dt nodes should be added for each PCI controller; one for host +mode and another for device mode. So in order for PCI to +work in host mode, EP mode dt node should be disabled and in order to PCI to +work in EP mode, host mode dt node should be disabled. And host mode and EP +mode are mutually exclusive. + Example: axi { compatible = "simple-bus";
Add device tree binding documentation for pci dra7xx EP mode. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- Documentation/devicetree/bindings/pci/ti-pci.txt | 37 ++++++++++++++++++---- 1 file changed, 30 insertions(+), 7 deletions(-)