| Message ID | 1511538800-8275-5-git-send-email-mmaddireddy@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Fri, Nov 24, 2017 at 09:23:14PM +0530, Manikanta Maddireddy wrote: > EXPORT tegra_cpuidle_pcie_irqs_in_use() to allow Tegra PCIe driver to be > compiled as loadable kernel module. > > Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> > --- > arch/arm/mach-tegra/cpuidle.c | 1 + > 1 file changed, 1 insertion(+) You should find a way to remove this call and the corresponding drivers->arch dependency, not to export it by spreading it even further. Lorenzo > diff --git a/arch/arm/mach-tegra/cpuidle.c b/arch/arm/mach-tegra/cpuidle.c > index 316563141add..7d7e6d3ce32d 100644 > --- a/arch/arm/mach-tegra/cpuidle.c > +++ b/arch/arm/mach-tegra/cpuidle.c > @@ -57,3 +57,4 @@ void tegra_cpuidle_pcie_irqs_in_use(void) > break; > } > } > +EXPORT_SYMBOL(tegra_cpuidle_pcie_irqs_in_use); > -- > 2.1.4 >
On 30-Nov-17 6:11 PM, Lorenzo Pieralisi wrote: > On Fri, Nov 24, 2017 at 09:23:14PM +0530, Manikanta Maddireddy wrote: >> EXPORT tegra_cpuidle_pcie_irqs_in_use() to allow Tegra PCIe driver to be >> compiled as loadable kernel module. >> >> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> >> --- >> arch/arm/mach-tegra/cpuidle.c | 1 + >> 1 file changed, 1 insertion(+) > > You should find a way to remove this call and the corresponding > drivers->arch dependency, not to export it by spreading it even > further. > > Lorenzo > I will drop this patch from the series and will explore the possibilities of removing the arch dependency. I will address it in next series of patches >> diff --git a/arch/arm/mach-tegra/cpuidle.c b/arch/arm/mach-tegra/cpuidle.c >> index 316563141add..7d7e6d3ce32d 100644 >> --- a/arch/arm/mach-tegra/cpuidle.c >> +++ b/arch/arm/mach-tegra/cpuidle.c >> @@ -57,3 +57,4 @@ void tegra_cpuidle_pcie_irqs_in_use(void) >> break; >> } >> } >> +EXPORT_SYMBOL(tegra_cpuidle_pcie_irqs_in_use); >> -- >> 2.1.4 >>
diff --git a/arch/arm/mach-tegra/cpuidle.c b/arch/arm/mach-tegra/cpuidle.c index 316563141add..7d7e6d3ce32d 100644 --- a/arch/arm/mach-tegra/cpuidle.c +++ b/arch/arm/mach-tegra/cpuidle.c @@ -57,3 +57,4 @@ void tegra_cpuidle_pcie_irqs_in_use(void) break; } } +EXPORT_SYMBOL(tegra_cpuidle_pcie_irqs_in_use);
EXPORT tegra_cpuidle_pcie_irqs_in_use() to allow Tegra PCIe driver to be compiled as loadable kernel module. Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> --- arch/arm/mach-tegra/cpuidle.c | 1 + 1 file changed, 1 insertion(+)