From patchwork Wed Apr 18 15:18:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 10348391 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B7CBA60216 for ; Wed, 18 Apr 2018 15:18:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6D93285ED for ; Wed, 18 Apr 2018 15:18:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 98B4F28600; Wed, 18 Apr 2018 15:18:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1791D285ED for ; Wed, 18 Apr 2018 15:18:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751232AbeDRPSI (ORCPT ); Wed, 18 Apr 2018 11:18:08 -0400 Received: from mail-ot0-f193.google.com ([74.125.82.193]:43529 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbeDRPSH (ORCPT ); Wed, 18 Apr 2018 11:18:07 -0400 Received: by mail-ot0-f193.google.com with SMTP id d9-v6so2312471oth.10 for ; Wed, 18 Apr 2018 08:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=SVOGMybHQ08ufPvxRMxPYAWvgf3Dk9QYLzdvXV8/S6M=; b=NTgw49SodQbq7hpeJbUdA4IlFQj/bdeZq3xQkPjwXBokcpLMvWRjL1DDtgWIGafm+F YxH4nPslI+rSULlzOsvYNoCL/rNWca4nwRLFx+4GK48g9ljyEP9992U1dPvFlyeiMnbK lX/KtGcY0atsoaQzPf9PZ1eXzMTEcn9c+Ib4z69GQGKL/qtbhDGrz8oMRRmAEhD375xm +7jl8i7zBj6G0hPSLecSJJwszd8igAaf4reDUClw1P0L0i2HWAia1for8A4nmSGajMnt 7KOX32nyOwVhpPkTwiYjh8MUoovabdCW4Bbp845Lrv+scnMSfKdiHDT5ROjH+TAUHcUV RsEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=SVOGMybHQ08ufPvxRMxPYAWvgf3Dk9QYLzdvXV8/S6M=; b=kS1w/lNb45lYvgr8c8bcf/8Jqu2lMWfqQfDjujSS5TAZ8uCfI+0WsTg2ihLVNOHPub JiTQvUqzW9sbGbba+99Jse+1YPa9wbPU9evXswRhFc2Xv2n/nRttZCL3GtTyK7mLxhcR yV+H3/OwLW+GvrGFsmqTIGk4gTKegk0nbjSlTix6wC5clQRRQETotQAQTsAPRvw9U5Dn YZIANPYyj00WBbMJ38mmih9nTK0+v5BiIowClZj1PLqk59J0s+fpNgTf9ZXEa8/18Iny xQTdvw5k/2p4J2ubdZyh5D75MRWtIELXWdE9MvHQS2HVySC3Wy6m2uG9Y2ALsEIu7NXw TzVg== X-Gm-Message-State: ALQs6tAJwlXWQfAWkbMftx1+qqwufrWS4nhTjr4lqOG1khkr/DKlnDgv uFHGPzE+m3RbzNjexFMS+A== X-Google-Smtp-Source: AIpwx4+hv+p82CLMireS6xxaGAjo1oW7kZwIm3edEFV7TWMug6CGBoByQKvTgoo5TzWJwmi6Ver8mw== X-Received: by 2002:a9d:5a14:: with SMTP id v20-v6mr1637041oth.349.1524064686503; Wed, 18 Apr 2018 08:18:06 -0700 (PDT) Received: from serve.minyard.net ([47.184.168.85]) by smtp.gmail.com with ESMTPSA id a69-v6sm755133oih.31.2018.04.18.08.18.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Apr 2018 08:18:05 -0700 (PDT) Received: from t430.minyard.net (t430m.minyard.net [192.168.27.3]) by serve.minyard.net (Postfix) with ESMTPA id B1D5A377; Wed, 18 Apr 2018 10:18:04 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 7D2423000E7; Wed, 18 Apr 2018 10:18:04 -0500 (CDT) From: minyard@acm.org To: Bjorn Helgaas Cc: openipmi-developer@lists.sourceforge.net, linux-pci@vger.kernel.org, Corey Minyard Subject: [PATCH] pci:ipmi: Move IPMI PCI device defines to pci_ids.h Date: Wed, 18 Apr 2018 10:18:00 -0500 Message-Id: <1524064680-22333-1-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Corey Minyard Signed-off-by: Corey Minyard --- drivers/char/ipmi/ipmi_si_pci.c | 7 ------- include/linux/pci_ids.h | 5 +++++ 2 files changed, 5 insertions(+), 7 deletions(-) It seems better to have these definitions in pci_ids.h and not in the IPMI driver. diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c index f54ca68..e0bc101 100644 --- a/drivers/char/ipmi/ipmi_si_pci.c +++ b/drivers/char/ipmi/ipmi_si_pci.c @@ -18,13 +18,6 @@ module_param_named(trypci, si_trypci, bool, 0); MODULE_PARM_DESC(trypci, "Setting this to zero will disable the" " default scan of the interfaces identified via pci"); -#define PCI_CLASS_SERIAL_IPMI 0x0c07 -#define PCI_CLASS_SERIAL_IPMI_SMIC 0x0c0700 -#define PCI_CLASS_SERIAL_IPMI_KCS 0x0c0701 -#define PCI_CLASS_SERIAL_IPMI_BT 0x0c0702 - -#define PCI_DEVICE_ID_HP_MMC 0x121A - static void ipmi_pci_cleanup(struct si_sm_io *io) { struct pci_dev *pdev = io->addr_source_data; diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 2d61d9b..bedbae9 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -117,6 +117,10 @@ #define PCI_CLASS_SERIAL_USB_DEVICE 0x0c03fe #define PCI_CLASS_SERIAL_FIBER 0x0c04 #define PCI_CLASS_SERIAL_SMBUS 0x0c05 +#define PCI_CLASS_SERIAL_IPMI 0x0c07 +#define PCI_CLASS_SERIAL_IPMI_SMIC 0x0c0700 +#define PCI_CLASS_SERIAL_IPMI_KCS 0x0c0701 +#define PCI_CLASS_SERIAL_IPMI_BT 0x0c0702 #define PCI_BASE_CLASS_WIRELESS 0x0d #define PCI_CLASS_WIRELESS_RF_CONTROLLER 0x0d10 @@ -759,6 +763,7 @@ #define PCI_DEVICE_ID_HP_DIVA_MAESTRO 0x104B #define PCI_DEVICE_ID_HP_REO_IOC 0x10f1 #define PCI_DEVICE_ID_HP_VISUALIZE_FXE 0x108b +#define PCI_DEVICE_ID_HP_MMC 0x121a #define PCI_DEVICE_ID_HP_DIVA_HALFDOME 0x1223 #define PCI_DEVICE_ID_HP_DIVA_KEYSTONE 0x1226 #define PCI_DEVICE_ID_HP_DIVA_POWERBAR 0x1227