| Message ID | 1526995952-22031-1-git-send-email-adouglas@cadence.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Tue, May 22, 2018 at 02:32:32PM +0100, Alan Douglas wrote: > Update DT documentation to include optional PHYs for cadence PCIe > host and endpoint controllers. > > Signed-off-by: Alan Douglas <adouglas@cadence.com> > --- > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++ > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt > index 9a305237..e40c635 100644 > --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt > +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt > @@ -9,6 +9,8 @@ Required properties: > > Optional properties: > - max-functions: Maximum number of functions that can be configured (default 1). > +- phys: From PHY bindings: List of Generic PHY phandles. > +- phy-names: List of names to identify the PHY. You need to define how many. I'd assume one, but I guess your example is 1 per lane. > > Example: > > @@ -19,4 +21,6 @@ pcie@fc000000 { > reg-names = "reg", "mem"; > cdns,max-outbound-regions = <16>; > max-functions = /bits/ 8 <8>; > + phys = <&ep_phy0 &ep_phy1>; > + phy-names = "pcie-lane0","pcie-lane1"; > }; > diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > index 20a33f3..c0ca4c1 100644 > --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt > @@ -24,6 +24,8 @@ Optional properties: > translations (default 32) > - vendor-id: The PCI vendor ID (16 bits, default is design dependent) > - device-id: The PCI device ID (16 bits, default is design dependent) > +- phys: From PHY bindings: List of Generic PHY phandles. > +- phy-names: List of names to identify the PHY. > > Example: > > -- > 2.2.2 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On 23 May 2018 19:52, Rob Herring wrote: > On Tue, May 22, 2018 at 02:32:32PM +0100, Alan Douglas wrote: > > Update DT documentation to include optional PHYs for cadence PCIe > > host and endpoint controllers. > > > > Signed-off-by: Alan Douglas <adouglas@cadence.com> > > --- > > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++ > > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie- > ep.txt > > index 9a305237..e40c635 100644 > > --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt > > +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt > > @@ -9,6 +9,8 @@ Required properties: > > > > Optional properties: > > - max-functions: Maximum number of functions that can be configured (default 1). > > +- phys: From PHY bindings: List of Generic PHY phandles. > > +- phy-names: List of names to identify the PHY. > > You need to define how many. I'd assume one, but I guess your example is > 1 per lane. > I can update the description in v3 as follows: - phys: From PHY bindings: List of Generic PHY phandles. One per lane if more than one in the list. If only one PHY listed it must manage all lanes. - phy-names: List of names to identify the PHY, one for each in the list. > > > > Example: > > > > @@ -19,4 +21,6 @@ pcie@fc000000 { > > reg-names = "reg", "mem"; > > cdns,max-outbound-regions = <16>; > > max-functions = /bits/ 8 <8>; > > + phys = <&ep_phy0 &ep_phy1>; > > + phy-names = "pcie-lane0","pcie-lane1"; > > };
diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt index 9a305237..e40c635 100644 --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt @@ -9,6 +9,8 @@ Required properties: Optional properties: - max-functions: Maximum number of functions that can be configured (default 1). +- phys: From PHY bindings: List of Generic PHY phandles. +- phy-names: List of names to identify the PHY. Example: @@ -19,4 +21,6 @@ pcie@fc000000 { reg-names = "reg", "mem"; cdns,max-outbound-regions = <16>; max-functions = /bits/ 8 <8>; + phys = <&ep_phy0 &ep_phy1>; + phy-names = "pcie-lane0","pcie-lane1"; }; diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt index 20a33f3..c0ca4c1 100644 --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt @@ -24,6 +24,8 @@ Optional properties: translations (default 32) - vendor-id: The PCI vendor ID (16 bits, default is design dependent) - device-id: The PCI device ID (16 bits, default is design dependent) +- phys: From PHY bindings: List of Generic PHY phandles. +- phy-names: List of names to identify the PHY. Example:
Update DT documentation to include optional PHYs for cadence PCIe host and endpoint controllers. Signed-off-by: Alan Douglas <adouglas@cadence.com> --- Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++ Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++ 2 files changed, 6 insertions(+)