From patchwork Mon May 28 21:21:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10434029 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7749660249 for ; Mon, 28 May 2018 21:25:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 219372852B for ; Mon, 28 May 2018 21:25:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 121092852E; Mon, 28 May 2018 21:25:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 984702852B for ; Mon, 28 May 2018 21:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934153AbeE1VZi (ORCPT ); Mon, 28 May 2018 17:25:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:32922 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934139AbeE1VVV (ORCPT ); Mon, 28 May 2018 17:21:21 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B6AAC60711; Mon, 28 May 2018 21:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527542480; bh=AHMrd6ZywvJGIrz1vwluQH/8SHmyN4Ki+UbaYl9UiG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bX3DaKKswbn92IqzNQts/4y7aETI7/IcStJBbA6sX05JdGsIP2fdN7CZQyjfbBa6X L2vtv3XKt4DOU4VAu0bPCsGyYiLhiXjkqc9N6klkWE4iklsSTNCeY5yy8HHQNEvY0L LTaihOjWDoXSwtZjv2G7gs77K3ygwV0L/CBnPZu8= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 70FC16044B; Mon, 28 May 2018 21:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527542479; bh=AHMrd6ZywvJGIrz1vwluQH/8SHmyN4Ki+UbaYl9UiG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lk8JalKB0Gmy+sUC5v+gu7CKavAK0s2ruU2C83Nvtlm6PAb+shg+fzN0VXE+x3D0U xMKMisd9Y+GSoWG64ap5xh7uiXeCrFceJEzPZQEezQ7e9vl8J1aDa4/U0RsMyQ5S86 s3kp42kxY1l1zk1UogEVCpeM9zBf85XKKk+slWU8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 70FC16044B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, ryan@finnie.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya , stable@vger.kernel.org, Don Brace , "James E.J. Bottomley" , "Martin K. Petersen" , esc.storagedev@microsemi.com (open list:HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)), linux-scsi@vger.kernel.org (open list:HEWLETT-PACKARD SMART ARRAY RAID DRIVER (hpsa)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH V3 2/2] scsi: hpsa: drop shutdown callback Date: Mon, 28 May 2018 17:21:11 -0400 Message-Id: <1527542471-10316-2-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1527542471-10316-1-git-send-email-okaya@codeaurora.org> References: <1527542471-10316-1-git-send-email-okaya@codeaurora.org> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown")' has been added to kernel to shutdown pending PCIe port service interrupts during reboot so that a newly started kexec kernel wouldn't observe pending interrupts. pcie_port_device_remove() is disabling the root port and switches by calling pci_disable_device() after all PCIe service drivers are shutdown. This has been found to cause crashes on HP DL360 Gen9 machines during reboot due to hpsa driver not clearing the bus master bit during the shutdown procedure by calling pci_disable_device(). Drop the shutdown API and do an orderly clean up by using the remove. Signed-off-by: Sinan Kaya Link: https://bugzilla.kernel.org/show_bug.cgi?id=199779 Fixes: cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown") Cc: stable@vger.kernel.org Reported-by: Ryan Finnie Tested-by: Ryan Finnie --- drivers/scsi/hpsa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3a9eca1..3dbef28 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -8970,7 +8970,6 @@ static struct pci_driver hpsa_pci_driver = { .probe = hpsa_init_one, .remove = hpsa_remove_one, .id_table = hpsa_pci_device_id, /* id_table */ - .shutdown = hpsa_shutdown, .suspend = hpsa_suspend, .resume = hpsa_resume, };