| Message ID | 1530417291-30495-4-git-send-email-shawn.guo@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Sun, Jul 01, 2018 at 11:54:45AM +0800, Shawn Guo wrote: > Function dw_pcie_host_init() already initializes the root_bus_nr field > of 'struct pcie_port', so the -1 assignment prior to calling > dw_pcie_host_init() in platform specific driver is not really needed. > Drop it. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > Cc: Murali Karicheri <m-karicheri2@ti.com> > --- > drivers/pci/controller/dwc/pci-keystone.c | 1 - > 1 file changed, 1 deletion(-) Hi Murali, we would need your ACK to send this series upstream, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c > index 3722a5f31e5e..e88bd221fffe 100644 > --- a/drivers/pci/controller/dwc/pci-keystone.c > +++ b/drivers/pci/controller/dwc/pci-keystone.c > @@ -347,7 +347,6 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie, > } > } > > - pp->root_bus_nr = -1; > pp->ops = &keystone_pcie_host_ops; > ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np); > if (ret) { > -- > 1.9.1 >
diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 3722a5f31e5e..e88bd221fffe 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -347,7 +347,6 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie, } } - pp->root_bus_nr = -1; pp->ops = &keystone_pcie_host_ops; ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np); if (ret) {
Function dw_pcie_host_init() already initializes the root_bus_nr field of 'struct pcie_port', so the -1 assignment prior to calling dw_pcie_host_init() in platform specific driver is not really needed. Drop it. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Cc: Murali Karicheri <m-karicheri2@ti.com> --- drivers/pci/controller/dwc/pci-keystone.c | 1 - 1 file changed, 1 deletion(-)