Message ID | 1534340851-21091-1-git-send-email-adouglas@cadence.com (mailing list archive) |
---|---|
State | New, archived |
Delegated to: | Bjorn Helgaas |
Headers | show
Return-Path: <linux-pci-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 788211390 for <patchwork-linux-pci@patchwork.kernel.org>; Wed, 15 Aug 2018 13:47:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 679A528E45 for <patchwork-linux-pci@patchwork.kernel.org>; Wed, 15 Aug 2018 13:47:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5BDD729D7B; Wed, 15 Aug 2018 13:47:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F218028E45 for <patchwork-linux-pci@patchwork.kernel.org>; Wed, 15 Aug 2018 13:47:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729381AbeHOQj5 (ORCPT <rfc822;patchwork-linux-pci@patchwork.kernel.org>); Wed, 15 Aug 2018 12:39:57 -0400 Received: from mail-bn3nam01on0060.outbound.protection.outlook.com ([104.47.33.60]:14400 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729363AbeHOQj5 (ORCPT <rfc822;linux-pci@vger.kernel.org>); Wed, 15 Aug 2018 12:39:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcWCffm62qcV9t78gr7YinoBmsqYOWmSzIJTeCfC1Ms=; b=jt6E8w/9nUUoeHGRx9e79J2marbS9Ke1j/vsa88h1loyf/SO13qFPMwGJo4Of+X+3/eKg4KVainflV1Z+E+Zj2WEO9QzE6zMTkmIHgP0wc3Sqp4fHYBbR6UfCkuFJh43xgvvMoZ3DD3vBXh+eNn56nNDonfHUcn0bw/4BAV3dmA= Received: from DM5PR07CA0072.namprd07.prod.outlook.com (2603:10b6:4:ad::37) by BN3PR0701MB1330.namprd07.prod.outlook.com (2a01:111:e400:4019::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Wed, 15 Aug 2018 13:47:39 +0000 Received: from CO1NAM05FT057.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::206) by DM5PR07CA0072.outlook.office365.com (2603:10b6:4:ad::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1059.19 via Frontend Transport; Wed, 15 Aug 2018 13:47:39 +0000 Authentication-Results: spf=softfail (sender IP is 158.140.1.28) smtp.mailfrom=cadence.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=fail action=none header.from=cadence.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning cadence.com discourages use of 158.140.1.28 as permitted sender) Received: from sjmaillnx2.cadence.com (158.140.1.28) by CO1NAM05FT057.mail.protection.outlook.com (10.152.96.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.1080.6 via Frontend Transport; Wed, 15 Aug 2018 13:47:39 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by sjmaillnx2.cadence.com (8.14.4/8.14.4) with ESMTP id w7FDlYVT021118 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 15 Aug 2018 06:47:36 -0700 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 15 Aug 2018 15:47:46 +0200 Received: from lvloginb.cadence.com (10.165.177.11) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Wed, 15 Aug 2018 15:47:46 +0200 Received: from lvloginb.cadence.com (localhost [127.0.0.1]) by lvloginb.cadence.com (8.14.4/8.14.4) with ESMTP id w7FDlXDK021186; Wed, 15 Aug 2018 14:47:33 +0100 Received: (from adouglas@localhost) by lvloginb.cadence.com (8.14.4/8.14.4/Submit) id w7FDlWpq021182; Wed, 15 Aug 2018 14:47:32 +0100 From: Alan Douglas <adouglas@cadence.com> To: <bhelgaas@google.com> CC: <kishon@ti.com>, <lorenzo.pieralisi@arm.com>, <linux-pci@vger.kernel.org>, <gustavo.pimentel@synopsys.com>, <cyrille.pitchen@bootlin.com>, <stelford@cadence.com>, Alan Douglas <adouglas@cadence.com> Subject: [PATCH v2 2/5] PCI: cadence: Write MSI data with 32bits Date: Wed, 15 Aug 2018 14:47:31 +0100 Message-ID: <1534340851-21091-1-git-send-email-adouglas@cadence.com> X-Mailer: git-send-email 2.2.2 MIME-Version: 1.0 Content-Type: text/plain X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:158.140.1.28;IPV:CAL;SCL:-1;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(136003)(346002)(376002)(39860400002)(396003)(2980300002)(3190300001)(189003)(199004)(36092001)(356003)(186003)(336012)(4326008)(6916009)(5660300001)(2906002)(486006)(26005)(476003)(2616005)(426003)(126002)(50466002)(246002)(305945005)(107886003)(7636002)(48376002)(8676002)(47776003)(105596002)(2351001)(106466001)(51416003)(86362001)(87636003)(26826003)(50226002)(42186006)(8936002)(316002)(54906003)(478600001)(14444005)(16586007)(36756003)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1330;H:sjmaillnx2.cadence.com;FPR:;SPF:SoftFail;LANG:en;PTR:corp.cadence.com;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;CO1NAM05FT057;1:1Zs2EFJ0851+kbISQzxe5HnGguW1dApk2HSOvIUl3TAadDiOryY6TalIP7Q9cK41z9uhO1kFP77VMsC1y0/5TO6D84CDy+cd3QltADnurxVIGRepC1Uv4BX+yLO8M8GS X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0237cb99-6b59-4484-4b1b-08d602b5aa96 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060);SRVR:BN3PR0701MB1330; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1330;3:6R5g6nh0g5NxVuugqhWBtHzRN0pjd0zKqeIsKfhAoJoZAMCWETVIFdcg2Ed+KdQatCS3H2rqCLnEZwcmH5L78DwPsF/25qEE96U5UL4B6zJ6m9DIUpc0udJ63ySPdI3urPrZzzEK1fXGWSFsH7j+wDdfc4vGu10Geb4MkAItWhNOSA6teFu90YGOv+GckPnpcYbbplK8MV6y2qkcftiIG5xkwMi2RErY5ntyeck9SkbxS48fu035dPwlsWH2aIHV8HmCiFOZBTDE6irSTL03htDIDJ/AJiJS0o49wGSPsLG19+AJXFbZPnIUOBP+h7bkGD3TTRu4UCxlqSdDcO4cVnpjPkyxP/cjD9QCjVp6Sdc=;25:jw8m46TssTWQ5vkYeCH9LPoneYCQukG+WPVPWKK1+R/jtovTQpuP0DCyP/mo5ncD/pI7vRPoXYqo/Qfj1nmbqlIG8cxqCOTQM/8fXILMTgmFYaTtISHGp5zlc1NaRRRuZekXMlYbs4awNcTQfIOTFrRoGKYLkRvu3m5/z8mv5y1GvjLIeBH8AEwjEOgIb6DbWXJIb86a4w3NO2j8frTrak6zN6i8d0Pssjg6NxObssPSWKpAwiyNEweYVJba1NZMkKSB0Nq6YRuGFyx43ncScE61Yi8/sXUzou1F9sLjE6BfKnh0qJRHNUaE1wl+jxqIqTsyA6ptOIR3jVks0y3lEQ== X-MS-TrafficTypeDiagnostic: BN3PR0701MB1330: X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1330;31:FxMFsRwNZLgeueEGGy/XM19lSVRYyo5O8syf+nqHWTV1aleSkKY/YAHBctivjHEpYeMin4CZutEhn714wibUOdqwd5H4agbxQcT/0VH6LGm38/Xr8V5WAUAzwt5dM8DKuAXx+nnI87Dy+bncE0dWM41L5LvO/uw951fpBU+sXDeXjNqz0Xk0asVMVWFhNqx4mkPlQEx5pAgLUfZk28nDOTg/3v6Y7VRR/etOAu9hxgU=;20:xyPOJZwVTnvocozxcNRmRM9EXL/Ge3ixjuo5zHwXRzYYrJ3jUdx70b+aQJDVJt3E/c5KkpyTQMtsjRgeGDeygwidB+YInVi3hN3Kis05/7D6sIdvq5qNVx0VEnIOjx8W4W/f4Znn2mg7plIBI2d5vY0/a0Jjl85KCc2KcpAYFsSMKtfWfU1KnXPyd4Y8sWpfc/fSWss7ChwmO4ibz1Ttal4/ji+X+SmakF9rwk2pNZZkK8ebfyWtP8GBRYM9/yee8nLPe99LWHPN8ujLKnc1n9qfHWA3lgGwSWOXcWiYHMhXUN7I7iyyUwLNDY4rpYhVW4s6Ehc+eUzfGQMNCLmOYYYlpjU5LPiIYAEVREEZFffOeO3X/knBtT1g1zXW3Wlk4AEgBRW6cpvRva7ns6cIQv9vlH/9Y6HWs8y8jB5l///cAWP8oK7x5xvDCjMmMgcshgdvZfpuoDas+1hI7sN873q9C7kD+JDvtPDoRenYAQZl4XLcV2szV5yVnsU2QgwR X-Microsoft-Antispam-PRVS: <BN3PR0701MB13309F2D851781E81A445F42D83F0@BN3PR0701MB1330.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(72806322054110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93003095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:BN3PR0701MB1330;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1330; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1330;4:eCIb7lCBjE+ShVGyzfUIB9bUnLDRqYtWeLipXYckLyRgZJzBDhPQAzJfNGKb/UTvlf6gZBdc51FwMt8+lNVEd1NwxUXL/USZW+rCN7+GW5Lh4Lwokgc5cR17XvZwCeMnFs27SXKWRDWa6F9/J2yWeVy+/5AdEk5ZqY5h0VxUn9k/1SbwnKJ6DExdz4sCibL7A7qVbpBd3D4mA6xAYYmbANV8t0ffEfJPfPvAEsZWI1Ff8SWaxXyu07WtzfsdGrc76k1H7Ptc6WmDUPRAoUuwWydi7JAh34uh8penmmCfKtFYcQ6fkSpl0RgxwSpxz1Be X-Forefront-PRVS: 07658B8EA3 X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1330;23:9ssZClZx0hY4x6cUHmr2Yn1CEzf/GylFrB/Pct2xPSXaaI91ZW5ymXTeAwX7e7vSQh+iY42RAyXCfwqiheIzSpRWuUd8sMGGPI93L/fUkCFMXSfu1dL/Ha2aWtJPOHwueivdzx67JR8Lq4ZvXArc51kLFYcDldaKEhAmGPfMuSbLV4wfFH+tanBMpiCbj1NuQL92TkfLvGhO5D26Q20vjctgE0VBQaVkLLWPq7O7wNMErwnLrdwtkWsg7T1wxlfsOcwUCL6YU5n3hZ51A2pxbJw4oxPP4XnhAP9glqDUHpaqfVUA2UZZ2QnBJJrlA2Ift2hTTgZMlJbAeNNmhasn4rShQPt9Wgrt8VCABfEpcBb7Xj5hzu0qChTnh4Y157RZekR9ZTAiH4weKUWKxy0ylG1iv1ZqVP+EXaebXQU3SEyJzggD7vY2lCT5ucrlxCPjshDJecxWL37WE1U/84bnfNzhMMg+WJorGaP0lUcJBJ0LroUmcsqy7OwdmX+oescFLk5AIQS+cgGiZtqJnAj/sBEnqtF6B47XX89e840eSPJJyh1g4TACzznyCCz+4+8UG9bAOcjkUcCg3ApC35u6nmYpcjNekkDagxUzLXvIceS3EQMqjKtEAXa0vk65zVHRzGWzUDO1QPF3RNhQ1UNzO33OaifT1Jqab8pGvmp7J/uyFaqZSORsSBCJHhlkKLbLx187InrOJKmwxky34jxXlyx4wLU3DWn0vKL4+Hi1MT17I7LBmWroAqxI/N363J/MMydtcX1Uds5rf88WRTkBehEWJMunHoogH0pUsshLZkoNmtOFnZMkVnrZxGmZKUkvJKqET8ACwUNXMRjdLSiAHAYcFv2j6Mg9YBqdsO/JrPHv3PrWMcqYPYpvQGujEKV0HMwDeIsJmkbUAq+BUpUWYYR+EPokzZssvU2gcGNhfylyWpjK0Uio7Iw2lcErsFvRjOtqbAPRUG1GN/j5UCbYNGV7YIGwIHorBGj9iO4OGM7XQwj3tIJQUFuAaZiSvMvYQnLvishHRqTJ/HeEmroYc8IUNDZbFhjBO2eWNE16yanmhiy2cg3Z82CP1BZCkPPGzCpkSmZ7sJX5NzJjI6f8D23yGyTQqdOJbTuQBF6r+EgvLVpX/DMG6kmdEnzydMDYfE+GTjCEBl+CUGqL0TejFA== X-Microsoft-Antispam-Message-Info: XAiQH2kEtLhQliBtXnYJeg2+kw1MWo9SMtngxmLBW8XHbgIqpN3KdWYosNhkdWWg6A5xifpx/dVzDK8b/B0u9tqg6PCdAGrGjQVaRNQW2CwuUKtFL7wmZhYQWGA3s21cnNOk0MF+YheNjl6tjPLnmuAb2WyhoIW0+nJ9C2Qj1BaIqIvAgFBTw3WAYatKZPaA7gnHTK2v043jVFYdznu/HEFSDUB+T8qq2Iy24GcJ0OEqHc1lQN4OnM6LNP4Y/vYyb4B565iNkumhOn4OCFD3AROWZ8DD3+lP8cxiCW/x7WkWzeLvWKCpWTx6cSMQpMA2ueJp34eqAfdkn1zwLht3B7LqCDO7Oc3TioPkxujW/agcOqvyxDeLb/1IDnMnB3s6KEG3COk9Boa1FKZ2Mj9CeQ== X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1330;6:vGP4zAtPZARse2Il37HYqke67G2kzoD5cphn/OWYGk/h9yjVZ9TP9bl11vG2SaJNnuZ0B0ZRhw1DUbxf6SmSlblYO4EjlEuzMRWNHEa7GMWujYIAfmFf3ZUW6Xo5oDWVU9uVWRSH3jBgTwf3ZYCncgdhhydWf2jcEqiDSO7yWC8pVqgCo7nxAFqVHZcAaXrSCvjFi0ufFAB30t+Ed2BBmcS9uwq18lkV55VxgtWpnkbDSEwOI5DWxWoaHRVbhjR9cXcZF/bkO5iAVSo9Jqzxidpr5/kmArG/bsjFq4fhpYrYwZC0us3fBBBzhJ9DnE52Qt2JOZ5u1UiomYSeHnLO0NR6Swa0tInV9B3sXS92BlehQqte55MshF7an+fmzzjqIHlIyiwF9vJX4ScAAECYiAs4EVrVTEEdjeK9CqeHCzQ4jJ0qbt6NRGDIFXh0vp32QNWNDjG5aVJi05zJyTAInQ==;5:vtiBFhIwBt5rRKAgtV2ETQipXZu9K/uzecDjx9wzj7aKNW3NcqDseRgSmp01Pvmqb1iffldo1zMZBX+dGQlUM+Uuo6WIleeUurpXOqMwM2S4ovRhtPKFhghVol0cxJK4STqCT755CRop+n/O0WfG85KgrM4xpSs6lKy38GpMAoI=;7:NtRT3JjSZppbJOwZPdN0c+E4x1oQjcswIpNXVCSbSwPDVv+jF84UHyz00PcqzaxMUr0MkINdDeViXi6+o2QRGZpLjoAV+fZ8x2qwRhqzziHTmz17r/70sXkWqCpjRQl0UWAYUVUQruV/4UFVgDW2VfrXFNt94I6OM3R88zb/MraUtwDuQ3DjsGIRfuM/NIHUjaZTV/dXrc7JZiW9A7B+sFel8bxm0nxwAWgMTw7A3Eyug6MbJoqYzu+LNwM5qMlA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR0701MB1330;20:0FvZOajxf+VOGe3luodhVbgODWZBfkxIXZhF4d/yemlAt+ItDL53OesTBHeJZLWzLIKxNABjR5jpEQwhNldDzhJRjRX0AHb8nvpJI86/XNkm4+im6Tib4bwhle6deJbRoWK6X7qb9thVzRv6af7M5lJgUAexFlobG8lf5Em+b95/nN68gCJqckeLKoA67EW3Hw73VVoxH9+orSZrbubUKtZhFuQkazSK+uu8A8VF1hrSMzX3BW2SgZ/YR+cHhH1R X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2018 13:47:39.1785 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0237cb99-6b59-4484-4b1b-08d602b5aa96 X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9;Ip=[158.140.1.28];Helo=[sjmaillnx2.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1330 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: <linux-pci.vger.kernel.org> X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
Add MSI-X support for cadence EP driver
|
expand
|
diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index a67dc91..970d934 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -356,7 +356,7 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, ep->irq_pci_addr = (pci_addr & ~pci_addr_mask); ep->irq_pci_fn = fn; } - writew(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); + writel(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); return 0; }
According to the PCIe specification, although the MSI data is only 16bits, the upper 16bits should be written as 0. Use writel instead of writew when writing the MSI data to the host. Fixes: 37dddf14f1ae ("PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller") Signed-off-by: Alan Douglas <adouglas@cadence.com> --- drivers/pci/controller/pcie-cadence-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)