| Message ID | 1617015721-51701-1-git-send-email-yangyicong@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [v2] PCI/AER: Use consistent format when printing PCI device | expand |
On Mon, Mar 29, 2021 at 07:02:01PM +0800, Yicong Yang wrote: > We use format domain:bus:slot.function when printing > PCI device. Use consistent format in AER messages. > > Reviewed-by: Krzysztof Wilczyński <kw@linux.com> > Signed-off-by: Yicong Yang <yangyicong@hisilicon.com> Applied to pci/error for v5.14, thanks! I also dropped the "AER recover:" prefixes, since pr_fmt() already gives us an "AER:" prefix. > --- > Change since v1: > - address comments from Krzysztof > Link: https://lore.kernel.org/linux-pci/1616752057-9720-1-git-send-email-yangyicong@hisilicon.com/ > > drivers/pci/pcie/aer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index ba22388..f7f0ca5 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -983,7 +983,7 @@ static void aer_recover_work_func(struct work_struct *work) > pdev = pci_get_domain_bus_and_slot(entry.domain, entry.bus, > entry.devfn); > if (!pdev) { > - pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x:%x\n", > + pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x.%x\n", > entry.domain, entry.bus, > PCI_SLOT(entry.devfn), PCI_FUNC(entry.devfn)); > continue; > @@ -1022,7 +1022,7 @@ void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, > &aer_recover_ring_lock)) > schedule_work(&aer_recover_work); > else > - pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x:%x\n", > + pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x.%x\n", > domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn)); > } > EXPORT_SYMBOL_GPL(aer_recover_queue); > -- > 2.8.1 >
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index ba22388..f7f0ca5 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -983,7 +983,7 @@ static void aer_recover_work_func(struct work_struct *work) pdev = pci_get_domain_bus_and_slot(entry.domain, entry.bus, entry.devfn); if (!pdev) { - pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x:%x\n", + pr_err("AER recover: Can not find pci_dev for %04x:%02x:%02x.%x\n", entry.domain, entry.bus, PCI_SLOT(entry.devfn), PCI_FUNC(entry.devfn)); continue; @@ -1022,7 +1022,7 @@ void aer_recover_queue(int domain, unsigned int bus, unsigned int devfn, &aer_recover_ring_lock)) schedule_work(&aer_recover_work); else - pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x:%x\n", + pr_err("AER recover: Buffer overflow when recovering AER for %04x:%02x:%02x.%x\n", domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn)); } EXPORT_SYMBOL_GPL(aer_recover_queue);