| Message ID | 1618241456-27200-4-git-send-email-bpeled@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Asynchronous linkdown recovery | expand |
On Mon, Apr 12, 2021 at 06:30:54PM +0300, bpeled@marvell.com wrote: > From: Ben Peled <bpeled@marvell.com> > > Adding optional system-controller and mac-reset-bit-mask > needed for linkdown procedure. > > Signed-off-by: Ben Peled <bpeled@marvell.com> > --- > Documentation/devicetree/bindings/pci/pci-armada8k.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/pci-armada8k.txt b/Documentation/devicetree/bindings/pci/pci-armada8k.txt > index 7a813d0..2696e79 100644 > --- a/Documentation/devicetree/bindings/pci/pci-armada8k.txt > +++ b/Documentation/devicetree/bindings/pci/pci-armada8k.txt > @@ -24,6 +24,10 @@ Optional properties: > - phy-names: names of the PHYs corresponding to the number of lanes. > Must be "cp0-pcie0-x4-lane0-phy", "cp0-pcie0-x4-lane1-phy" for > 2 PHYs. > +- marvell,system-controller: address of system controller needed > + in order to reset MAC used by link-down handle > +- marvell,mac-reset-bit-mask: MAC reset bit of system controller > + needed in order to reset MAC used by link-down handle Seems like this should use the reset controller binding instead. If not, this can be a single property with a phandle plus arg. Rob
Hi Rob, Sorry I missed it. > > diff --git a/Documentation/devicetree/bindings/pci/pci-armada8k.txt > > b/Documentation/devicetree/bindings/pci/pci-armada8k.txt > > index 7a813d0..2696e79 100644 > > --- a/Documentation/devicetree/bindings/pci/pci-armada8k.txt > > +++ b/Documentation/devicetree/bindings/pci/pci-armada8k.txt > > @@ -24,6 +24,10 @@ Optional properties: > > - phy-names: names of the PHYs corresponding to the number of lanes. > > Must be "cp0-pcie0-x4-lane0-phy", "cp0-pcie0-x4-lane1-phy" for > > 2 PHYs. > > +- marvell,system-controller: address of system controller needed > > + in order to reset MAC used by link-down handle > > +- marvell,mac-reset-bit-mask: MAC reset bit of system controller > > + needed in order to reset MAC used by link-down handle > > Seems like this should use the reset controller binding instead. > > If not, this can be a single property with a phandle plus arg. > > Rob I will fix it v3. Thanks
diff --git a/Documentation/devicetree/bindings/pci/pci-armada8k.txt b/Documentation/devicetree/bindings/pci/pci-armada8k.txt index 7a813d0..2696e79 100644 --- a/Documentation/devicetree/bindings/pci/pci-armada8k.txt +++ b/Documentation/devicetree/bindings/pci/pci-armada8k.txt @@ -24,6 +24,10 @@ Optional properties: - phy-names: names of the PHYs corresponding to the number of lanes. Must be "cp0-pcie0-x4-lane0-phy", "cp0-pcie0-x4-lane1-phy" for 2 PHYs. +- marvell,system-controller: address of system controller needed + in order to reset MAC used by link-down handle +- marvell,mac-reset-bit-mask: MAC reset bit of system controller + needed in order to reset MAC used by link-down handle Example: @@ -45,4 +49,6 @@ Example: interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; num-lanes = <1>; clocks = <&cpm_syscon0 1 13>; + marvell,system-controller = <&CP11X_LABEL(syscon0)>; + marvell,mac-reset-bit-mask = <CP11X_PCIEx_MAC_RESET_BIT_MASK(1)>; };