| Message ID | 1646634556-23779-5-git-send-email-hongxing.zhu@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add the iMX8MP PCIe support | expand |
Hi Richard, thanks for providing a patch supporting PCie on iMX8MP. Am Montag, 7. März 2022, 07:29:13 CET schrieb Richard Zhu: > Add i.MX8MP PCIe compatible string. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index > 36c8a06d17a0..252e5b72aee0 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -26,6 +26,7 @@ properties: > - fsl,imx7d-pcie > - fsl,imx8mq-pcie > - fsl,imx8mm-pcie > + - fsl,imx8mp-pcie > > reg: > items: Which branch is this based on? I don't have 'fsl,imx8mm-pcie' entry in my tree. Another patch 7 also doesn't apply cleanly. Regards Alexander
> -----Original Message----- > From: Alexander Stein <alexander.stein@ew.tq-group.com> > Sent: 2022年3月7日 16:03 > To: Hongxing Zhu <hongxing.zhu@nxp.com> > Cc: p.zabel@pengutronix.de; l.stach@pengutronix.de; bhelgaas@google.com; > lorenzo.pieralisi@arm.com; robh@kernel.org; shawnguo@kernel.org; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > <linux-imx@nxp.com>; Hongxing Zhu <hongxing.zhu@nxp.com> > Subject: Re: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP PCIe > compatible string > > Hi Richard, > > thanks for providing a patch supporting PCie on iMX8MP. > > Am Montag, 7. März 2022, 07:29:13 CET schrieb Richard Zhu: > > Add i.MX8MP PCIe compatible string. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index > > 36c8a06d17a0..252e5b72aee0 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > @@ -26,6 +26,7 @@ properties: > > - fsl,imx7d-pcie > > - fsl,imx8mq-pcie > > - fsl,imx8mm-pcie > > + - fsl,imx8mp-pcie > > > > reg: > > items: > > Which branch is this based on? I don't have 'fsl,imx8mm-pcie' entry in my tree. > Another patch 7 also doesn't apply cleanly. > Hi Alexander: Thanks for your quick reply. In the past days, I had summit some patches, and wait for ack or reviewed tags. But they might have some conflictions when do the codes merge. I'm waiting for the ack, and will re-base them in a proper sequence later. About the #4 patch apply, it's better to pick the following commit, since it had Lucas' Reviewed-by tag, and wait for merge. https://patchwork.ozlabs.org/project/linux-pci/patch/1646293805-18248-1-git-send-email-hongxing.zhu@nxp.com/ About the #7 patch, I do the changes based on the following patch-set. https://patchwork.ozlabs.org/project/linux-pci/cover/1645760667-10510-1-git-send-email-hongxing.zhu@nxp.com/ I would add the dependency patch-set later in the cover-letter later. Sorry to bring in-conveniency to you. BTW, If you want to tests PCIe on i.MX8MM EVK board too, the following dts changes should be cherry-picked from Shawn's git. b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on imx8mm evk board aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support Best Regards Richard Zhu > Regards > Alexander >
Hi Richard, Am Montag, 7. März 2022, 09:19:52 CET schrieb Hongxing Zhu: > > -----Original Message----- > > From: Alexander Stein <alexander.stein@ew.tq-group.com> > > Sent: 2022年3月7日 16:03 > > To: Hongxing Zhu <hongxing.zhu@nxp.com> > > Cc: p.zabel@pengutronix.de; l.stach@pengutronix.de; bhelgaas@google.com; > > lorenzo.pieralisi@arm.com; robh@kernel.org; shawnguo@kernel.org; > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > > <linux-imx@nxp.com>; Hongxing Zhu <hongxing.zhu@nxp.com> > > Subject: Re: (EXT) [PATCH v1 4/7] dt-bindings: imx6q-pcie: Add iMX8MP > > PCIe > > compatible string > > > > Hi Richard, > > > > thanks for providing a patch supporting PCie on iMX8MP. > > > > Am Montag, 7. März 2022, 07:29:13 CET schrieb Richard Zhu: > > > > > Add i.MX8MP PCIe compatible string. > > > > > > > > > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > > --- > > > > > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index > > > 36c8a06d17a0..252e5b72aee0 100644 > > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > > @@ -26,6 +26,7 @@ properties: > > > > > > - fsl,imx7d-pcie > > > - fsl,imx8mq-pcie > > > - fsl,imx8mm-pcie > > > > > > + - fsl,imx8mp-pcie > > > > > > > > > > > > reg: > > > > > > items: > > > > > > Which branch is this based on? I don't have 'fsl,imx8mm-pcie' entry in my > > tree. Another patch 7 also doesn't apply cleanly. > > > > Hi Alexander: > Thanks for your quick reply. Thanks for your fast response. I just wanted to give it a try on our own custom iMX8MP board. I did see the PCIe RC, but not EP (yet), no link up for now. > In the past days, I had summit some patches, and wait for ack or reviewed > tags. But they might have some conflictions when do the codes merge. > I'm waiting for the ack, and will re-base them in a proper sequence later. > > About the #4 patch apply, it's better to pick the following commit, since it > had Lucas' Reviewed-by tag, and wait for merge. > https://patchwork.ozlabs.org/project/linux-pci/patch/1646293805-18248-1-git-> send-email-hongxing.zhu@nxp.com/ > About the #7 patch, I do the changes based on the following patch-set. > https://patchwork.ozlabs.org/project/linux-pci/cover/1645760667-10510-1-git-> send-email-hongxing.zhu@nxp.com/ > I would add the dependency patch-set later in the cover-letter later. > Sorry to bring in-conveniency to you. Thanks I'll retry with the dependencies updated, so I hopefully won't miss something. > BTW, If you want to tests PCIe on i.MX8MM EVK board too, the following dts > changes should be cherry-picked from Shawn's git. > b4d36c10bf17 arm64: dts: imx8mm-evk: Add the pcie support on imx8mm evk > board aaeba6a8e226 arm64: dts: imx8mm: Add the pcie support > cfc5078432ca arm64: dts: imx8mm: Add the pcie phy support Thanks I'll keep the imx8mm support in mind. Best regards Alexander
diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml index 36c8a06d17a0..252e5b72aee0 100644 --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml @@ -26,6 +26,7 @@ properties: - fsl,imx7d-pcie - fsl,imx8mq-pcie - fsl,imx8mm-pcie + - fsl,imx8mp-pcie reg: items:
Add i.MX8MP PCIe compatible string. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> --- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 + 1 file changed, 1 insertion(+)