| Message ID | 1686154687-29356-2-git-send-email-quic_krichai@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | [v2,1/3] dt-bindings: PCI: qcom: ep: Add interconnects path | expand |
On Wed, 07 Jun 2023 21:48:05 +0530, Krishna chaitanya chundru wrote: > Add the "pcie-mem" interconnect path to the bindings. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.example.dtb: pcie-ep@1c00000: 'interconnects' is a required property From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.example.dtb: pcie-ep@1c00000: 'interconnect-names' is a required property From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1686154687-29356-2-git-send-email-quic_krichai@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Jun 07, 2023 at 09:48:05PM +0530, Krishna chaitanya chundru wrote: > Add the "pcie-mem" interconnect path to the bindings. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index b3c22eb..6fc5440 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -70,6 +70,13 @@ properties: > description: GPIO used as WAKE# output signal > maxItems: 1 > > + interconnects: > + maxItems: 1 > + > + interconnect-names: > + items: > + - const: pcie-mem > + > resets: > maxItems: 1 > > @@ -97,6 +104,8 @@ required: > - interrupts > - interrupt-names > - reset-gpios > + - interconnects > + - interconnect-names You can't add required properties. That's an ABI break. Up to the platform whether that's acceptible, but you have to explain all this in the commmit msg. > - resets > - reset-names > - power-domains > -- > 2.7.4 >
On Thu, Jun 08, 2023 at 09:27:59AM -0600, Rob Herring wrote: > On Wed, Jun 07, 2023 at 09:48:05PM +0530, Krishna chaitanya chundru wrote: > > Add the "pcie-mem" interconnect path to the bindings. > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > --- > > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > > index b3c22eb..6fc5440 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > > @@ -70,6 +70,13 @@ properties: > > description: GPIO used as WAKE# output signal > > maxItems: 1 > > > > + interconnects: > > + maxItems: 1 > > + > > + interconnect-names: > > + items: > > + - const: pcie-mem > > + > > resets: > > maxItems: 1 > > > > @@ -97,6 +104,8 @@ required: > > - interrupts > > - interrupt-names > > - reset-gpios > > + - interconnects > > + - interconnect-names > > You can't add required properties. That's an ABI break. Up to the > platform whether that's acceptible, but you have to explain all this in > the commmit msg. > Some platforms may not boot if a device driver doesn't initialize the interconnect path. Mostly it is all handled by the bootloader but we have starting to see cases where bootloader simply ignores them. So I'd say that these need to be made required (should've been from the start but I take the blame). And yes, this info should be part of the commit message. - Mani > > - resets > > - reset-names > > - power-domains > > -- > > 2.7.4 > >
On 6/7/2023 10:51 PM, Rob Herring wrote: > On Wed, 07 Jun 2023 21:48:05 +0530, Krishna chaitanya chundru wrote: >> Add the "pcie-mem" interconnect path to the bindings. >> >> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.example.dtb: pcie-ep@1c00000: 'interconnects' is a required property > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.example.dtb: pcie-ep@1c00000: 'interconnect-names' is a required property > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1686154687-29356-2-git-send-email-quic_krichai@quicinc.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Fixed the errors. - Krishna chaitanya
On 09/06/2023 13:55, Krishna Chaitanya Chundru wrote: >> >> Please check and re-submit after running the above command yourself. Note >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >> your schema. However, it must be unset to test all examples with your schema. >> > Fixed the errors. Then please test it before sending. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml index b3c22eb..6fc5440 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml @@ -70,6 +70,13 @@ properties: description: GPIO used as WAKE# output signal maxItems: 1 + interconnects: + maxItems: 1 + + interconnect-names: + items: + - const: pcie-mem + resets: maxItems: 1 @@ -97,6 +104,8 @@ required: - interrupts - interrupt-names - reset-gpios + - interconnects + - interconnect-names - resets - reset-names - power-domains
Add the "pcie-mem" interconnect path to the bindings. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)